Title: [153667] trunk/Source/WebKit2
- Revision
- 153667
- Author
- commit-qu...@webkit.org
- Date
- 2013-08-02 14:27:26 -0700 (Fri, 02 Aug 2013)
Log Message
[Forms: color] The positioning of the popover color well is inverted
<rdar://problem/14635621> and https://bugs.webkit.org/show_bug.cgi?id=119455
Patch by Ruth Fong <ruth_f...@apple.com> on 2013-08-02
Reviewed by Tim Horton.
This patch converts the coordinates of the <input type='color'> element to
the window's base coordinate system.
* UIProcess/mac/WebColorPickerMac.mm:
(-[WKColorPopoverMac initWithFrame:inView:]):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (153666 => 153667)
--- trunk/Source/WebKit2/ChangeLog 2013-08-02 21:07:36 UTC (rev 153666)
+++ trunk/Source/WebKit2/ChangeLog 2013-08-02 21:27:26 UTC (rev 153667)
@@ -1,3 +1,16 @@
+2013-08-02 Ruth Fong <ruth_f...@apple.com>
+
+ [Forms: color] The positioning of the popover color well is inverted
+ <rdar://problem/14635621> and https://bugs.webkit.org/show_bug.cgi?id=119455
+
+ Reviewed by Tim Horton.
+
+ This patch converts the coordinates of the <input type='color'> element to
+ the window's base coordinate system.
+
+ * UIProcess/mac/WebColorPickerMac.mm:
+ (-[WKColorPopoverMac initWithFrame:inView:]):
+
2013-08-01 Ruth Fong <ruth_f...@apple.com>
[Forms: color] <input type='color'> popover color well implementation
Modified: trunk/Source/WebKit2/UIProcess/mac/WebColorPickerMac.mm (153666 => 153667)
--- trunk/Source/WebKit2/UIProcess/mac/WebColorPickerMac.mm 2013-08-02 21:07:36 UTC (rev 153666)
+++ trunk/Source/WebKit2/UIProcess/mac/WebColorPickerMac.mm 2013-08-02 21:27:26 UTC (rev 153667)
@@ -145,7 +145,7 @@
if(!(self = [super init]))
return self;
- _popoverWell = adoptNS([[NSPopoverColorWell alloc] initWithFrame:NSRectFromCGRect(rect)]);
+ _popoverWell = adoptNS([[NSPopoverColorWell alloc] initWithFrame:[view convertRect:NSRectFromCGRect(rect) toView:nil]]);
if (!_popoverWell)
return self;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
