Title: [153724] trunk/Source/WebKit2
- Revision
- 153724
- Author
- ander...@apple.com
- Date
- 2013-08-05 14:26:25 -0700 (Mon, 05 Aug 2013)
Log Message
Ignore the Apple Java placeholder plug-in
https://bugs.webkit.org/show_bug.cgi?id=119494
<rdar://problem/14610818>
Reviewed by Beth Dakin.
Never attempt to load the Java placeholder plug-in.
* UIProcess/Plugins/mac/PluginInfoStoreMac.mm:
(WebKit::PluginInfoStore::shouldUsePlugin):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (153723 => 153724)
--- trunk/Source/WebKit2/ChangeLog 2013-08-05 21:20:19 UTC (rev 153723)
+++ trunk/Source/WebKit2/ChangeLog 2013-08-05 21:26:25 UTC (rev 153724)
@@ -1,3 +1,16 @@
+2013-08-05 Anders Carlsson <ander...@apple.com>
+
+ Ignore the Apple Java placeholder plug-in
+ https://bugs.webkit.org/show_bug.cgi?id=119494
+ <rdar://problem/14610818>
+
+ Reviewed by Beth Dakin.
+
+ Never attempt to load the Java placeholder plug-in.
+
+ * UIProcess/Plugins/mac/PluginInfoStoreMac.mm:
+ (WebKit::PluginInfoStore::shouldUsePlugin):
+
2013-08-03 Tim Horton <timothy_hor...@apple.com>
Unreviewed, build and style fix for r153693.
Modified: trunk/Source/WebKit2/UIProcess/Plugins/mac/PluginInfoStoreMac.mm (153723 => 153724)
--- trunk/Source/WebKit2/UIProcess/Plugins/mac/PluginInfoStoreMac.mm 2013-08-05 21:20:19 UTC (rev 153723)
+++ trunk/Source/WebKit2/UIProcess/Plugins/mac/PluginInfoStoreMac.mm 2013-08-05 21:26:25 UTC (rev 153724)
@@ -80,33 +80,6 @@
return NetscapePluginModule::getPluginInfo(pluginPath, plugin);
}
-static size_t findPluginWithBundleIdentifier(const Vector<PluginModuleInfo>& plugins, const String& bundleIdentifier)
-{
- for (size_t i = 0; i < plugins.size(); ++i) {
- if (plugins[i].bundleIdentifier == bundleIdentifier)
- return i;
- }
-
- return notFound;
-}
-
-// Returns true if the given plug-in should be loaded, false otherwise.
-static bool checkForPreferredPlugin(Vector<PluginModuleInfo>& alreadyLoadedPlugins, const PluginModuleInfo& plugin, const String& oldPluginBundleIdentifier, const String& newPluginBundleIdentifier)
-{
- if (plugin.bundleIdentifier == oldPluginBundleIdentifier) {
- // If we've already found the new plug-in, we don't want to load the old plug-in.
- if (findPluginWithBundleIdentifier(alreadyLoadedPlugins, newPluginBundleIdentifier) != notFound)
- return false;
- } else if (plugin.bundleIdentifier == newPluginBundleIdentifier) {
- // If we've already found the old plug-in, remove it from the list of loaded plug-ins.
- size_t oldPluginIndex = findPluginWithBundleIdentifier(alreadyLoadedPlugins, oldPluginBundleIdentifier);
- if (oldPluginIndex != notFound)
- alreadyLoadedPlugins.remove(oldPluginIndex);
- }
-
- return true;
-}
-
static bool shouldBlockPlugin(const PluginModuleInfo& plugin)
{
return PluginInfoStore::defaultLoadPolicyForPlugin(plugin) == PluginModuleBlocked;
@@ -128,8 +101,7 @@
}
}
- // Prefer the Oracle Java plug-in over the Apple java plug-in.
- if (!checkForPreferredPlugin(alreadyLoadedPlugins, plugin, "com.apple.java.JavaAppletPlugin", oracleJavaAppletPluginBundleIdentifier))
+ if (plugin.bundleIdentifier == "com.apple.java.JavaAppletPlugin")
return false;
return true;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
