Title: [153832] trunk/Source/WebCore
- Revision
- 153832
- Author
- rob...@webkit.org
- Date
- 2013-08-08 11:13:22 -0700 (Thu, 08 Aug 2013)
Log Message
REGRESSION(r147019): Page has extra space
https://bugs.webkit.org/show_bug.cgi?id=119424
Reviewed by David Hyatt.
Clear the overflow rect before recomputing it in table sections.
No new tests: the reduction uses jquery and I was unable to simulate the reduction without it.
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::layoutRows):
(WebCore::RenderTableSection::computeOverflowFromCells):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (153831 => 153832)
--- trunk/Source/WebCore/ChangeLog 2013-08-08 17:47:04 UTC (rev 153831)
+++ trunk/Source/WebCore/ChangeLog 2013-08-08 18:13:22 UTC (rev 153832)
@@ -1,3 +1,18 @@
+2013-08-08 Robert Hogan <rob...@webkit.org>
+
+ REGRESSION(r147019): Page has extra space
+ https://bugs.webkit.org/show_bug.cgi?id=119424
+
+ Reviewed by David Hyatt.
+
+ Clear the overflow rect before recomputing it in table sections.
+
+ No new tests: the reduction uses jquery and I was unable to simulate the reduction without it.
+
+ * rendering/RenderTableSection.cpp:
+ (WebCore::RenderTableSection::layoutRows):
+ (WebCore::RenderTableSection::computeOverflowFromCells):
+
2013-08-08 Andreas Kling <akl...@apple.com>
Inserting multiple rules into an empty style sheet should avoid style recalc if possible.
Modified: trunk/Source/WebCore/rendering/RenderTableSection.cpp (153831 => 153832)
--- trunk/Source/WebCore/rendering/RenderTableSection.cpp 2013-08-08 17:47:04 UTC (rev 153831)
+++ trunk/Source/WebCore/rendering/RenderTableSection.cpp 2013-08-08 18:13:22 UTC (rev 153832)
@@ -515,8 +515,6 @@
// Set the width of our section now. The rows will also be this width.
setLogicalWidth(table()->contentLogicalWidth());
- m_overflow.clear();
- m_overflowingCells.clear();
m_forceSlowPaintPathWithOverflowingCell = false;
int vspacing = table()->vBorderSpacing();
@@ -669,6 +667,8 @@
void RenderTableSection::computeOverflowFromCells(unsigned totalRows, unsigned nEffCols)
{
+ m_overflow.clear();
+ m_overflowingCells.clear();
unsigned totalCellsCount = nEffCols * totalRows;
int maxAllowedOverflowingCellsCount = totalCellsCount < gMinTableSizeToUseFastPaintPathWithOverflowingCell ? 0 : gMaxAllowedOverflowingCellRatioForFastPaintPath * totalCellsCount;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
