Diff
Modified: trunk/Source/WebCore/ChangeLog (155832 => 155833)
--- trunk/Source/WebCore/ChangeLog 2013-09-16 01:29:43 UTC (rev 155832)
+++ trunk/Source/WebCore/ChangeLog 2013-09-16 05:40:09 UTC (rev 155833)
@@ -1,3 +1,53 @@
+2013-09-15 Santosh Mahto <santosh...@samsung.com>
+
+ Adding "explicit" keyword in rendering related constructors
+ https://bugs.webkit.org/show_bug.cgi?id=121398
+
+ Reviewed by Andreas Kling.
+
+ Adding explicit in below constructor.
+ All files belong to Source/WebCore/rendering/ path.
+
+ * rendering/AutoTableLayout.h:
+ * rendering/ClipPathOperation.h:
+ (WebCore::ClipPathOperation::ClipPathOperation):
+ (WebCore::ShapeClipPathOperation::ShapeClipPathOperation):
+ * rendering/FixedTableLayout.h:
+ * rendering/FloatingObjects.h:
+ (WebCore::FloatingObject::FloatingObject):
+ * rendering/FlowThreadController.h:
+ * rendering/HitTestResult.h:
+ * rendering/ImageQualityController.h:
+ * rendering/InlineBox.h:
+ (WebCore::InlineBox::InlineBox):
+ (WebCore::InlineBox::InlineBoxBitfields::InlineBoxBitfields):
+ * rendering/InlineFlowBox.h:
+ (WebCore::InlineFlowBox::InlineFlowBox):
+ * rendering/InlineTextBox.h:
+ (WebCore::InlineTextBox::InlineTextBox):
+ * rendering/LayoutState.h:
+ * rendering/LogicalSelectionOffsetCaches.h:
+ (WebCore::LogicalSelectionOffsetCaches::LogicalSelectionOffsetCaches):
+ * rendering/RenderBoxModelObject.h:
+ * rendering/RenderFlexibleBox.h:
+ * rendering/RenderFrameSet.h:
+ (WebCore::FrameEdgeInfo::FrameEdgeInfo):
+ * rendering/RenderGeometryMap.h:
+ * rendering/RenderImage.h:
+ * rendering/RenderImageResourceStyleImage.h:
+ * rendering/RenderLayerFilterInfo.h:
+ * rendering/RenderMultiColumnSet.h:
+ * rendering/RenderNamedFlowThread.h:
+ * rendering/RenderReplaced.h:
+ * rendering/RenderSearchField.h:
+ * rendering/RenderSelectionInfo.h:
+ (WebCore::RenderSelectionInfoBase::RenderSelectionInfoBase):
+ (WebCore::RenderBlockSelectionInfo::RenderBlockSelectionInfo):
+ * rendering/RenderTableSection.h:
+ * rendering/RenderTextControl.h:
+ * rendering/RenderTextControlSingleLine.h:
+ * rendering/TrailingFloatsRootInlineBox.h:
+
2013-09-15 Gustavo Noronha Silva <g...@gnome.org>
Unreviewed make distcheck fix.
Modified: trunk/Source/WebCore/rendering/AutoTableLayout.h (155832 => 155833)
--- trunk/Source/WebCore/rendering/AutoTableLayout.h 2013-09-16 01:29:43 UTC (rev 155832)
+++ trunk/Source/WebCore/rendering/AutoTableLayout.h 2013-09-16 05:40:09 UTC (rev 155833)
@@ -33,7 +33,7 @@
class AutoTableLayout : public TableLayout {
public:
- AutoTableLayout(RenderTable*);
+ explicit AutoTableLayout(RenderTable*);
~AutoTableLayout();
virtual void computeIntrinsicLogicalWidths(LayoutUnit& minWidth, LayoutUnit& maxWidth) OVERRIDE;
Modified: trunk/Source/WebCore/rendering/ClipPathOperation.h (155832 => 155833)
--- trunk/Source/WebCore/rendering/ClipPathOperation.h 2013-09-16 01:29:43 UTC (rev 155832)
+++ trunk/Source/WebCore/rendering/ClipPathOperation.h 2013-09-16 05:40:09 UTC (rev 155833)
@@ -55,7 +55,7 @@
virtual bool isSameType(const ClipPathOperation& o) const { return o.getOperationType() == m_type; }
protected:
- ClipPathOperation(OperationType type)
+ explicit ClipPathOperation(OperationType type)
: m_type(type)
{
}
@@ -120,7 +120,7 @@
return m_shape == other->m_shape;
}
- ShapeClipPathOperation(PassRefPtr<BasicShape> shape)
+ explicit ShapeClipPathOperation(PassRefPtr<BasicShape> shape)
: ClipPathOperation(SHAPE)
, m_shape(shape)
{
Modified: trunk/Source/WebCore/rendering/FixedTableLayout.h (155832 => 155833)
--- trunk/Source/WebCore/rendering/FixedTableLayout.h 2013-09-16 01:29:43 UTC (rev 155832)
+++ trunk/Source/WebCore/rendering/FixedTableLayout.h 2013-09-16 05:40:09 UTC (rev 155833)
@@ -32,7 +32,7 @@
class FixedTableLayout : public TableLayout {
public:
- FixedTableLayout(RenderTable*);
+ explicit FixedTableLayout(RenderTable*);
virtual void computeIntrinsicLogicalWidths(LayoutUnit& minWidth, LayoutUnit& maxWidth) OVERRIDE;
virtual void applyPreferredLogicalWidthQuirks(LayoutUnit& minWidth, LayoutUnit& maxWidth) const OVERRIDE;
Modified: trunk/Source/WebCore/rendering/FloatingObjects.h (155832 => 155833)
--- trunk/Source/WebCore/rendering/FloatingObjects.h 2013-09-16 01:29:43 UTC (rev 155832)
+++ trunk/Source/WebCore/rendering/FloatingObjects.h 2013-09-16 05:40:09 UTC (rev 155833)
@@ -41,7 +41,7 @@
// Note that Type uses bits so you can use FloatLeftRight as a mask to query for both left and right.
enum Type { FloatLeft = 1, FloatRight = 2, FloatLeftRight = 3 };
- FloatingObject(EFloat type)
+ explicit FloatingObject(EFloat type)
: m_renderer(0)
, m_originatingLine(0)
, m_paginationStrut(0)
Modified: trunk/Source/WebCore/rendering/FlowThreadController.h (155832 => 155833)
--- trunk/Source/WebCore/rendering/FlowThreadController.h 2013-09-16 01:29:43 UTC (rev 155832)
+++ trunk/Source/WebCore/rendering/FlowThreadController.h 2013-09-16 05:40:09 UTC (rev 155833)
@@ -93,7 +93,7 @@
#endif
protected:
- FlowThreadController(RenderView*);
+ explicit FlowThreadController(RenderView*);
void updateFlowThreadsChainIfNecessary();
void resetFlowThreadsWithAutoHeightRegions();
Modified: trunk/Source/WebCore/rendering/HitTestResult.h (155832 => 155833)
--- trunk/Source/WebCore/rendering/HitTestResult.h 2013-09-16 01:29:43 UTC (rev 155832)
+++ trunk/Source/WebCore/rendering/HitTestResult.h 2013-09-16 05:40:09 UTC (rev 155833)
@@ -51,10 +51,10 @@
typedef ListHashSet<RefPtr<Node> > NodeSet;
HitTestResult();
- HitTestResult(const LayoutPoint&);
+ explicit HitTestResult(const LayoutPoint&);
// Pass non-negative padding values to perform a rect-based hit test.
HitTestResult(const LayoutPoint& centerPoint, unsigned topPadding, unsigned rightPadding, unsigned bottomPadding, unsigned leftPadding);
- HitTestResult(const HitTestLocation&);
+ explicit HitTestResult(const HitTestLocation&);
HitTestResult(const HitTestResult&);
~HitTestResult();
HitTestResult& operator=(const HitTestResult&);
Modified: trunk/Source/WebCore/rendering/ImageQualityController.h (155832 => 155833)
--- trunk/Source/WebCore/rendering/ImageQualityController.h 2013-09-16 01:29:43 UTC (rev 155832)
+++ trunk/Source/WebCore/rendering/ImageQualityController.h 2013-09-16 05:40:09 UTC (rev 155833)
@@ -51,7 +51,7 @@
typedef HashMap<const void*, LayoutSize> LayerSizeMap;
typedef HashMap<RenderBoxModelObject*, LayerSizeMap> ObjectLayerSizeMap;
- ImageQualityController(const RenderView&);
+ explicit ImageQualityController(const RenderView&);
void removeLayer(RenderBoxModelObject*, LayerSizeMap* innerMap, const void* layer);
void set(RenderBoxModelObject*, LayerSizeMap* innerMap, const void* layer, const LayoutSize&);
Modified: trunk/Source/WebCore/rendering/InlineBox.h (155832 => 155833)
--- trunk/Source/WebCore/rendering/InlineBox.h 2013-09-16 01:29:43 UTC (rev 155832)
+++ trunk/Source/WebCore/rendering/InlineBox.h 2013-09-16 05:40:09 UTC (rev 155833)
@@ -34,7 +34,7 @@
// some RenderObject (i.e., it represents a portion of that RenderObject).
class InlineBox {
public:
- InlineBox(RenderObject& renderer)
+ explicit InlineBox(RenderObject& renderer)
: m_next(0)
, m_prev(0)
, m_parent(0)
@@ -323,7 +323,7 @@
class InlineBoxBitfields {
public:
- InlineBoxBitfields(bool firstLine = false, bool constructed = false, bool dirty = false, bool extracted = false, bool isHorizontal = true)
+ explicit InlineBoxBitfields(bool firstLine = false, bool constructed = false, bool dirty = false, bool extracted = false, bool isHorizontal = true)
: m_firstLine(firstLine)
, m_constructed(constructed)
, m_bidiEmbeddingLevel(0)
Modified: trunk/Source/WebCore/rendering/InlineFlowBox.h (155832 => 155833)
--- trunk/Source/WebCore/rendering/InlineFlowBox.h 2013-09-16 01:29:43 UTC (rev 155832)
+++ trunk/Source/WebCore/rendering/InlineFlowBox.h 2013-09-16 05:40:09 UTC (rev 155833)
@@ -40,7 +40,7 @@
class InlineFlowBox : public InlineBox {
public:
- InlineFlowBox(RenderObject& renderer)
+ explicit InlineFlowBox(RenderObject& renderer)
: InlineBox(renderer)
, m_firstChild(0)
, m_lastChild(0)
Modified: trunk/Source/WebCore/rendering/InlineTextBox.h (155832 => 155833)
--- trunk/Source/WebCore/rendering/InlineTextBox.h 2013-09-16 01:29:43 UTC (rev 155832)
+++ trunk/Source/WebCore/rendering/InlineTextBox.h 2013-09-16 05:40:09 UTC (rev 155833)
@@ -47,7 +47,7 @@
class InlineTextBox : public InlineBox {
public:
- InlineTextBox(RenderObject& renderer)
+ explicit InlineTextBox(RenderObject& renderer)
: InlineBox(renderer)
, m_prevTextBox(0)
, m_nextTextBox(0)
Modified: trunk/Source/WebCore/rendering/LayoutState.h (155832 => 155833)
--- trunk/Source/WebCore/rendering/LayoutState.h 2013-09-16 01:29:43 UTC (rev 155832)
+++ trunk/Source/WebCore/rendering/LayoutState.h 2013-09-16 05:40:09 UTC (rev 155833)
@@ -67,7 +67,7 @@
}
LayoutState(LayoutState*, RenderBox*, const LayoutSize& offset, LayoutUnit pageHeight, bool pageHeightChanged, ColumnInfo*);
- LayoutState(RenderObject*);
+ explicit LayoutState(RenderObject*);
void destroy(RenderArena*);
Modified: trunk/Source/WebCore/rendering/LogicalSelectionOffsetCaches.h (155832 => 155833)
--- trunk/Source/WebCore/rendering/LogicalSelectionOffsetCaches.h 2013-09-16 01:29:43 UTC (rev 155832)
+++ trunk/Source/WebCore/rendering/LogicalSelectionOffsetCaches.h 2013-09-16 05:40:09 UTC (rev 155833)
@@ -133,7 +133,7 @@
};
- LogicalSelectionOffsetCaches(RenderBlock* rootBlock)
+ explicit LogicalSelectionOffsetCaches(RenderBlock* rootBlock)
{
ASSERT(rootBlock->isSelectionRoot());
RenderObject* parent = rootBlock->parent();
Modified: trunk/Source/WebCore/rendering/RenderBoxModelObject.h (155832 => 155833)
--- trunk/Source/WebCore/rendering/RenderBoxModelObject.h 2013-09-16 01:29:43 UTC (rev 155832)
+++ trunk/Source/WebCore/rendering/RenderBoxModelObject.h 2013-09-16 05:40:09 UTC (rev 155833)
@@ -61,7 +61,7 @@
class RenderBoxModelObject : public RenderLayerModelObject {
public:
- RenderBoxModelObject(Element*);
+ explicit RenderBoxModelObject(Element*);
virtual ~RenderBoxModelObject();
LayoutSize relativePositionOffset() const;
Modified: trunk/Source/WebCore/rendering/RenderFlexibleBox.h (155832 => 155833)
--- trunk/Source/WebCore/rendering/RenderFlexibleBox.h 2013-09-16 01:29:43 UTC (rev 155832)
+++ trunk/Source/WebCore/rendering/RenderFlexibleBox.h 2013-09-16 05:40:09 UTC (rev 155833)
@@ -37,7 +37,7 @@
class RenderFlexibleBox : public RenderBlock {
public:
- RenderFlexibleBox(Element*);
+ explicit RenderFlexibleBox(Element*);
virtual ~RenderFlexibleBox();
static RenderFlexibleBox* createAnonymous(Document&);
Modified: trunk/Source/WebCore/rendering/RenderFrameSet.h (155832 => 155833)
--- trunk/Source/WebCore/rendering/RenderFrameSet.h 2013-09-16 01:29:43 UTC (rev 155832)
+++ trunk/Source/WebCore/rendering/RenderFrameSet.h 2013-09-16 05:40:09 UTC (rev 155833)
@@ -34,7 +34,7 @@
enum FrameEdge { LeftFrameEdge, RightFrameEdge, TopFrameEdge, BottomFrameEdge };
struct FrameEdgeInfo {
- FrameEdgeInfo(bool preventResize = false, bool allowBorder = true)
+ explicit FrameEdgeInfo(bool preventResize = false, bool allowBorder = true)
: m_preventResize(4)
, m_allowBorder(4)
{
Modified: trunk/Source/WebCore/rendering/RenderGeometryMap.h (155832 => 155833)
--- trunk/Source/WebCore/rendering/RenderGeometryMap.h 2013-09-16 01:29:43 UTC (rev 155832)
+++ trunk/Source/WebCore/rendering/RenderGeometryMap.h 2013-09-16 05:40:09 UTC (rev 155833)
@@ -74,7 +74,7 @@
class RenderGeometryMap {
WTF_MAKE_NONCOPYABLE(RenderGeometryMap);
public:
- RenderGeometryMap(MapCoordinatesFlags = UseTransforms);
+ explicit RenderGeometryMap(MapCoordinatesFlags = UseTransforms);
~RenderGeometryMap();
MapCoordinatesFlags mapCoordinatesFlags() const { return m_mapCoordinatesFlags; }
Modified: trunk/Source/WebCore/rendering/RenderImage.h (155832 => 155833)
--- trunk/Source/WebCore/rendering/RenderImage.h 2013-09-16 01:29:43 UTC (rev 155832)
+++ trunk/Source/WebCore/rendering/RenderImage.h 2013-09-16 05:40:09 UTC (rev 155833)
@@ -35,7 +35,7 @@
class RenderImage : public RenderReplaced {
public:
- RenderImage(Element*);
+ explicit RenderImage(Element*);
virtual ~RenderImage();
static RenderImage* createAnonymous(Document&);
Modified: trunk/Source/WebCore/rendering/RenderImageResourceStyleImage.h (155832 => 155833)
--- trunk/Source/WebCore/rendering/RenderImageResourceStyleImage.h 2013-09-16 01:29:43 UTC (rev 155832)
+++ trunk/Source/WebCore/rendering/RenderImageResourceStyleImage.h 2013-09-16 05:40:09 UTC (rev 155833)
@@ -60,7 +60,7 @@
virtual WrappedImagePtr imagePtr() const { return m_styleImage->data(); }
private:
- RenderImageResourceStyleImage(StyleImage*);
+ explicit RenderImageResourceStyleImage(StyleImage*);
RefPtr<StyleImage> m_styleImage;
};
Modified: trunk/Source/WebCore/rendering/RenderLayerFilterInfo.h (155832 => 155833)
--- trunk/Source/WebCore/rendering/RenderLayerFilterInfo.h 2013-09-16 01:29:43 UTC (rev 155832)
+++ trunk/Source/WebCore/rendering/RenderLayerFilterInfo.h 2013-09-16 05:40:09 UTC (rev 155833)
@@ -74,7 +74,7 @@
#endif
private:
- FilterInfo(RenderLayer&);
+ explicit FilterInfo(RenderLayer&);
~FilterInfo();
friend void WTF::deleteOwnedPtr<FilterInfo>(FilterInfo*);
Modified: trunk/Source/WebCore/rendering/RenderMultiColumnSet.h (155832 => 155833)
--- trunk/Source/WebCore/rendering/RenderMultiColumnSet.h 2013-09-16 01:29:43 UTC (rev 155832)
+++ trunk/Source/WebCore/rendering/RenderMultiColumnSet.h 2013-09-16 05:40:09 UTC (rev 155833)
@@ -98,7 +98,7 @@
void prepareForLayout();
private:
- RenderMultiColumnSet(RenderFlowThread*);
+ explicit RenderMultiColumnSet(RenderFlowThread*);
virtual void computeLogicalHeight(LayoutUnit logicalHeight, LayoutUnit logicalTop, LogicalExtentComputedValues&) const OVERRIDE;
Modified: trunk/Source/WebCore/rendering/RenderNamedFlowThread.h (155832 => 155833)
--- trunk/Source/WebCore/rendering/RenderNamedFlowThread.h 2013-09-16 01:29:43 UTC (rev 155832)
+++ trunk/Source/WebCore/rendering/RenderNamedFlowThread.h 2013-09-16 05:40:09 UTC (rev 155833)
@@ -85,7 +85,7 @@
void resetMarkForDestruction();
private:
- RenderNamedFlowThread(PassRefPtr<WebKitNamedFlow>);
+ explicit RenderNamedFlowThread(PassRefPtr<WebKitNamedFlow>);
virtual const char* renderName() const OVERRIDE;
virtual bool isRenderNamedFlowThread() const OVERRIDE { return true; }
Modified: trunk/Source/WebCore/rendering/RenderReplaced.h (155832 => 155833)
--- trunk/Source/WebCore/rendering/RenderReplaced.h 2013-09-16 01:29:43 UTC (rev 155832)
+++ trunk/Source/WebCore/rendering/RenderReplaced.h 2013-09-16 05:40:09 UTC (rev 155833)
@@ -28,7 +28,7 @@
class RenderReplaced : public RenderBox {
public:
- RenderReplaced(Element*);
+ explicit RenderReplaced(Element*);
RenderReplaced(Element*, const LayoutSize& intrinsicSize);
virtual ~RenderReplaced();
Modified: trunk/Source/WebCore/rendering/RenderSearchField.h (155832 => 155833)
--- trunk/Source/WebCore/rendering/RenderSearchField.h 2013-09-16 01:29:43 UTC (rev 155832)
+++ trunk/Source/WebCore/rendering/RenderSearchField.h 2013-09-16 05:40:09 UTC (rev 155833)
@@ -33,7 +33,7 @@
class RenderSearchField FINAL : public RenderTextControlSingleLine, private PopupMenuClient {
public:
- RenderSearchField(HTMLInputElement&);
+ explicit RenderSearchField(HTMLInputElement&);
virtual ~RenderSearchField();
void updateCancelButtonVisibility() const;
Modified: trunk/Source/WebCore/rendering/RenderSelectionInfo.h (155832 => 155833)
--- trunk/Source/WebCore/rendering/RenderSelectionInfo.h 2013-09-16 01:29:43 UTC (rev 155832)
+++ trunk/Source/WebCore/rendering/RenderSelectionInfo.h 2013-09-16 05:40:09 UTC (rev 155833)
@@ -40,7 +40,7 @@
{
}
- RenderSelectionInfoBase(RenderObject* o)
+ explicit RenderSelectionInfoBase(RenderObject* o)
: m_object(o)
, m_repaintContainer(o->containerForRepaint())
, m_state(o->selectionState())
@@ -81,7 +81,7 @@
// This struct is used when the selection changes to cache the old and new state of the selection for each RenderBlock.
class RenderBlockSelectionInfo : public RenderSelectionInfoBase {
public:
- RenderBlockSelectionInfo(RenderBlock* b)
+ explicit RenderBlockSelectionInfo(RenderBlock* b)
: RenderSelectionInfoBase(b)
, m_rects(b->canUpdateSelectionOnRootLineBoxes() ? block()->selectionGapRectsForRepaint(m_repaintContainer) : GapRects())
{
Modified: trunk/Source/WebCore/rendering/RenderTableSection.h (155832 => 155833)
--- trunk/Source/WebCore/rendering/RenderTableSection.h 2013-09-16 01:29:43 UTC (rev 155832)
+++ trunk/Source/WebCore/rendering/RenderTableSection.h 2013-09-16 05:40:09 UTC (rev 155833)
@@ -62,7 +62,7 @@
class RenderTableSection FINAL : public RenderBox {
public:
- RenderTableSection(Element*);
+ explicit RenderTableSection(Element*);
virtual ~RenderTableSection();
RenderObject* firstChild() const { return m_children.firstChild(); }
Modified: trunk/Source/WebCore/rendering/RenderTextControl.h (155832 => 155833)
--- trunk/Source/WebCore/rendering/RenderTextControl.h 2013-09-16 01:29:43 UTC (rev 155832)
+++ trunk/Source/WebCore/rendering/RenderTextControl.h 2013-09-16 05:40:09 UTC (rev 155833)
@@ -37,7 +37,7 @@
virtual PassRefPtr<RenderStyle> createInnerTextStyle(const RenderStyle* startStyle) const = 0;
protected:
- RenderTextControl(HTMLTextFormControlElement&);
+ explicit RenderTextControl(HTMLTextFormControlElement&);
// This convenience function should not be made public because innerTextElement may outlive the render tree.
HTMLElement* innerTextElement() const;
Modified: trunk/Source/WebCore/rendering/RenderTextControlSingleLine.h (155832 => 155833)
--- trunk/Source/WebCore/rendering/RenderTextControlSingleLine.h 2013-09-16 01:29:43 UTC (rev 155832)
+++ trunk/Source/WebCore/rendering/RenderTextControlSingleLine.h 2013-09-16 05:40:09 UTC (rev 155833)
@@ -32,7 +32,7 @@
class RenderTextControlSingleLine : public RenderTextControl {
public:
- RenderTextControlSingleLine(HTMLInputElement&);
+ explicit RenderTextControlSingleLine(HTMLInputElement&);
virtual ~RenderTextControlSingleLine();
// FIXME: Move create*Style() to their classes.
virtual PassRefPtr<RenderStyle> createInnerTextStyle(const RenderStyle* startStyle) const;
Modified: trunk/Source/WebCore/rendering/TrailingFloatsRootInlineBox.h (155832 => 155833)
--- trunk/Source/WebCore/rendering/TrailingFloatsRootInlineBox.h 2013-09-16 01:29:43 UTC (rev 155832)
+++ trunk/Source/WebCore/rendering/TrailingFloatsRootInlineBox.h 2013-09-16 05:40:09 UTC (rev 155833)
@@ -32,7 +32,7 @@
class TrailingFloatsRootInlineBox FINAL : public RootInlineBox {
public:
- TrailingFloatsRootInlineBox(RenderBlock& block)
+ explicit TrailingFloatsRootInlineBox(RenderBlock& block)
: RootInlineBox(block)
{
setHasVirtualLogicalHeight();
