Title: [155951] trunk/Source/WebCore
- Revision
- 155951
- Author
- michael.brun...@digia.com
- Date
- 2013-09-17 06:24:28 -0700 (Tue, 17 Sep 2013)
Log Message
Correct range used for Emoji checks.
https://bugs.webkit.org/show_bug.cgi?id=121486
Reviewed by Allan Sandfeld Jensen.
Found and reported by David Binderman via Qt bug tracker.
The check if a character was in the Emoji range always evaluated to
false due to the upper range limit being lower than the lower limit.
Changed the upper limit to the highest assigned character from the
"Transport and Map Symbols" (0x1F6C5) as that seems to have been the
intended upper range limit of this check.
* platform/graphics/Font.cpp:
(WebCore::Font::isCJKIdeographOrSymbol):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (155950 => 155951)
--- trunk/Source/WebCore/ChangeLog 2013-09-17 12:40:37 UTC (rev 155950)
+++ trunk/Source/WebCore/ChangeLog 2013-09-17 13:24:28 UTC (rev 155951)
@@ -1,3 +1,22 @@
+2013-09-17 Michael Brüning <michael.brun...@digia.com>
+
+ Correct range used for Emoji checks.
+ https://bugs.webkit.org/show_bug.cgi?id=121486
+
+ Reviewed by Allan Sandfeld Jensen.
+
+ Found and reported by David Binderman via Qt bug tracker.
+
+ The check if a character was in the Emoji range always evaluated to
+ false due to the upper range limit being lower than the lower limit.
+
+ Changed the upper limit to the highest assigned character from the
+ "Transport and Map Symbols" (0x1F6C5) as that seems to have been the
+ intended upper range limit of this check.
+
+ * platform/graphics/Font.cpp:
+ (WebCore::Font::isCJKIdeographOrSymbol):
+
2013-09-17 Antti Koivisto <an...@apple.com>
Move text caret rect computation to root inline box
Modified: trunk/Source/WebCore/platform/graphics/Font.cpp (155950 => 155951)
--- trunk/Source/WebCore/platform/graphics/Font.cpp 2013-09-17 12:40:37 UTC (rev 155950)
+++ trunk/Source/WebCore/platform/graphics/Font.cpp 2013-09-17 13:24:28 UTC (rev 155951)
@@ -795,7 +795,7 @@
if (c >= 0x1F170 && c <= 0x1F189)
return true;
- if (c >= 0x1F200 && c <= 0x1F6F)
+ if (c >= 0x1F200 && c <= 0x1F6C5)
return true;
return isCJKIdeograph(c);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
