Title: [156337] trunk/Source/WebCore
- Revision
- 156337
- Author
- dba...@webkit.org
- Date
- 2013-09-24 10:12:37 -0700 (Tue, 24 Sep 2013)
Log Message
[iOS] Initialize settings mediaPlayback{AllowsInline, RequiresUserGesture} and
shouldRespectImageOrientation as appropriate
https://bugs.webkit.org/show_bug.cgi?id=121792
Reviewed by Darin Adler.
On iOS we explicitly want to disable mediaPlaybackAllowsInline, and enable
mediaPlaybackRequiresUserGesture and shouldRespectImageOrientation by default.
This differs from other platforms. We need to extract the initialization logic
for these settings into constants whose definition is conditioned on the platform.
* page/Settings.cpp:
* page/Settings.in:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (156336 => 156337)
--- trunk/Source/WebCore/ChangeLog 2013-09-24 16:45:40 UTC (rev 156336)
+++ trunk/Source/WebCore/ChangeLog 2013-09-24 17:12:37 UTC (rev 156337)
@@ -1,3 +1,19 @@
+2013-09-24 Daniel Bates <daba...@apple.com>
+
+ [iOS] Initialize settings mediaPlayback{AllowsInline, RequiresUserGesture} and
+ shouldRespectImageOrientation as appropriate
+ https://bugs.webkit.org/show_bug.cgi?id=121792
+
+ Reviewed by Darin Adler.
+
+ On iOS we explicitly want to disable mediaPlaybackAllowsInline, and enable
+ mediaPlaybackRequiresUserGesture and shouldRespectImageOrientation by default.
+ This differs from other platforms. We need to extract the initialization logic
+ for these settings into constants whose definition is conditioned on the platform.
+
+ * page/Settings.cpp:
+ * page/Settings.in:
+
2013-09-24 pe...@outlook.com <pe...@outlook.com>
[WinCairo] Compile error.
Modified: trunk/Source/WebCore/page/Settings.cpp (156336 => 156337)
--- trunk/Source/WebCore/page/Settings.cpp 2013-09-24 16:45:40 UTC (rev 156336)
+++ trunk/Source/WebCore/page/Settings.cpp 2013-09-24 17:12:37 UTC (rev 156337)
@@ -112,6 +112,16 @@
;
}
+#if PLATFORM(IOS)
+static const bool defaultMediaPlaybackAllowsInline = false;
+static const bool defaultMediaPlaybackRequiresUserGesture = true;
+static const bool defaultShouldRespectImageOrientation = true;
+#else
+static const bool defaultMediaPlaybackAllowsInline = true;
+static const bool defaultMediaPlaybackRequiresUserGesture = false;
+static const bool defaultShouldRespectImageOrientation = false;
+#endif
+
static const double defaultIncrementalRenderingSuppressionTimeoutInSeconds = 5;
#if USE(UNIFIED_TEXT_CHECKING)
static const bool defaultUnifiedTextCheckerEnabled = true;
Modified: trunk/Source/WebCore/page/Settings.in (156336 => 156337)
--- trunk/Source/WebCore/page/Settings.in 2013-09-24 16:45:40 UTC (rev 156336)
+++ trunk/Source/WebCore/page/Settings.in 2013-09-24 17:12:37 UTC (rev 156337)
@@ -126,8 +126,8 @@
fixedElementsLayoutRelativeToFrame initial=false
allowDisplayOfInsecureContent initial=true
allowRunningOfInsecureContent initial=true
-mediaPlaybackRequiresUserGesture initial=false
-mediaPlaybackAllowsInline initial=true
+mediaPlaybackRequiresUserGesture initial=defaultMediaPlaybackRequiresUserGesture
+mediaPlaybackAllowsInline initial=defaultMediaPlaybackAllowsInline
passwordEchoEnabled initial=false
suppressesIncrementalRendering initial=false
incrementalRenderingSuppressionTimeoutInSeconds type=double, initial=defaultIncrementalRenderingSuppressionTimeoutInSeconds
@@ -143,7 +143,7 @@
# Some apps needs isLoadingInAPISense to account for active subresource loaders.
needsIsLoadingInAPISenseQuirk initial=false
-shouldRespectImageOrientation initial=false
+shouldRespectImageOrientation initial=defaultShouldRespectImageOrientation
wantsBalancedSetDefersLoadingBehavior initial=false
requestAnimationFrameEnabled initial=true
deviceSupportsTouch initial=false
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
