Title: [156977] trunk/Source/WebCore
- Revision
- 156977
- Author
- akl...@apple.com
- Date
- 2013-10-05 16:56:12 -0700 (Sat, 05 Oct 2013)
Log Message
FrameView: Remove code for disabling repaints.
<https://webkit.org/b/122393>
Reviewed by Sam Weinig.
Nobody uses this mode for anything so let's just remove it.
It was added back in r110469 to fix an issue with SVGImageCache
and its only user disappeard in the cache overhaul in r142765.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (156976 => 156977)
--- trunk/Source/WebCore/ChangeLog 2013-10-05 23:53:54 UTC (rev 156976)
+++ trunk/Source/WebCore/ChangeLog 2013-10-05 23:56:12 UTC (rev 156977)
@@ -1,5 +1,17 @@
2013-10-05 Andreas Kling <akl...@apple.com>
+ FrameView: Remove code for disabling repaints.
+ <https://webkit.org/b/122393>
+
+ Reviewed by Sam Weinig.
+
+ Nobody uses this mode for anything so let's just remove it.
+
+ It was added back in r110469 to fix an issue with SVGImageCache
+ and its only user disappeard in the cache overhaul in r142765.
+
+2013-10-05 Andreas Kling <akl...@apple.com>
+
Remove IFrameShimSupport, it was only used by dead ports.
Rubber-stamped by Anders Carlsson.
Modified: trunk/Source/WebCore/page/FrameView.cpp (156976 => 156977)
--- trunk/Source/WebCore/page/FrameView.cpp 2013-10-05 23:53:54 UTC (rev 156976)
+++ trunk/Source/WebCore/page/FrameView.cpp 2013-10-05 23:56:12 UTC (rev 156977)
@@ -185,7 +185,6 @@
, m_inProgrammaticScroll(false)
, m_safeToPropagateScrollToParent(true)
, m_deferredRepaintTimer(this, &FrameView::deferredRepaintTimerFired)
- , m_disableRepaints(0)
, m_isTrackingRepaints(false)
, m_shouldUpdateWhileOffscreen(true)
, m_deferSetNeedsLayouts(0)
@@ -293,7 +292,6 @@
m_isVisuallyNonEmpty = false;
m_firstVisuallyNonEmptyLayoutCallbackPending = true;
m_maintainScrollPositionAnchor = 0;
- m_disableRepaints = 0;
}
void FrameView::removeFromAXObjectCache()
@@ -2210,9 +2208,6 @@
if (m_deferredRepaintTimer.isActive())
return;
- if (m_disableRepaints)
- return;
-
m_deferredRepaintTimer.startOneShot(delay);
}
@@ -2237,9 +2232,6 @@
void FrameView::doDeferredRepaints()
{
- if (m_disableRepaints)
- return;
-
ASSERT(!m_deferringRepaints);
if (!shouldUpdate()) {
m_repaintRects.clear();
@@ -2315,17 +2307,6 @@
doDeferredRepaints();
}
-void FrameView::beginDisableRepaints()
-{
- m_disableRepaints++;
-}
-
-void FrameView::endDisableRepaints()
-{
- ASSERT(m_disableRepaints > 0);
- m_disableRepaints--;
-}
-
void FrameView::updateLayerFlushThrottlingInAllFrames()
{
#if USE(ACCELERATED_COMPOSITING)
Modified: trunk/Source/WebCore/page/FrameView.h (156976 => 156977)
--- trunk/Source/WebCore/page/FrameView.h 2013-10-05 23:53:54 UTC (rev 156976)
+++ trunk/Source/WebCore/page/FrameView.h 2013-10-05 23:56:12 UTC (rev 156977)
@@ -247,10 +247,6 @@
void updateLayerFlushThrottlingInAllFrames();
void adjustTiledBackingCoverage();
- void beginDisableRepaints();
- void endDisableRepaints();
- bool repaintsDisabled() { return m_disableRepaints > 0; }
-
#if ENABLE(DASHBOARD_SUPPORT) || ENABLE(DRAGGABLE_REGION)
void updateAnnotatedRegions();
#endif
@@ -605,8 +601,6 @@
double m_deferredRepaintDelay;
double m_lastPaintTime;
- unsigned m_disableRepaints;
-
bool m_isTrackingRepaints; // Used for testing.
Vector<IntRect> m_trackedRepaintRects;
Modified: trunk/Source/WebCore/rendering/RenderView.cpp (156976 => 156977)
--- trunk/Source/WebCore/rendering/RenderView.cpp 2013-10-05 23:53:54 UTC (rev 156976)
+++ trunk/Source/WebCore/rendering/RenderView.cpp 2013-10-05 23:56:12 UTC (rev 156977)
@@ -539,15 +539,9 @@
}
}
-bool RenderView::shouldRepaint(const LayoutRect& r) const
+bool RenderView::shouldRepaint(const LayoutRect& rect) const
{
- if (printing() || r.width() == 0 || r.height() == 0)
- return false;
-
- if (frameView().repaintsDisabled())
- return false;
-
- return true;
+ return !printing() && !rect.isEmpty();
}
void RenderView::repaintRootContents()
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
