[webkit-changes] [157185] trunk/Tools

Wed, 09 Oct 2013 14:33:27 -0700

Title: [157185] trunk/Tools
Revision
157185
Author
[email protected]
Date
2013-10-09 14:34:28 -0700 (Wed, 09 Oct 2013)

Log Message

Attempt to fix faulty Dashboard iteration updating by always rebuilding test result objects.

https://bugs.webkit.org/show_bug.cgi?id=122515

Reviewed by Alexey Proskuryakov.

* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
(BuildbotIteration.prototype.update):

Modified Paths

Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js (157184 => 157185)


--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js	2013-10-09 21:01:10 UTC (rev 157184)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js	2013-10-09 21:34:28 UTC (rev 157185)
@@ -85,7 +85,7 @@
 
             var testResults = {};
 
-            if (!("isFinished" in testStep)) {
+            if (!testStep.isFinished) {
                 // The step never even ran, or hasn't finish running.
                 testResults.finished = false;
                 return testResults;
@@ -93,7 +93,7 @@
 
             testResults.finished = true;
 
-            if (!("results" in testStep) || !testStep.results[0]) {
+            if (!testStep.results || !testStep.results[0]) {
                 // All tests passed.
                 testResults.allPassed = true;
                 return testResults;
@@ -140,35 +140,23 @@
             var internalRevisionProperty = data.properties.findFirst(function(property) { return property[0] === "internal_got_revision"; });
             this.internalRevision = internalRevisionProperty ? parseInt(internalRevisionProperty[1], 10) : null;
 
-            if (!this.layoutTestResults || !this.layoutTestResults.finished) {
-                var layoutTestResults = collectTestResults.call(this, data, "layout-test");
-                this.layoutTestResults = layoutTestResults ? new BuildbotTestResults(this, layoutTestResults) : null;
-            }
+            var layoutTestResults = collectTestResults.call(this, data, "layout-test");
+            this.layoutTestResults = layoutTestResults ? new BuildbotTestResults(this, layoutTestResults) : null;
 
-            if (!this._javascript_TestResults || !this._javascript_TestResults.finished) {
-                var _javascript_TestResults = collectTestResults.call(this, data, "jscore-test");
-                this._javascript_TestResults = _javascript_TestResults ? new BuildbotTestResults(this, _javascript_TestResults) : null;
-            }
+            var _javascript_TestResults = collectTestResults.call(this, data, "jscore-test");
+            this._javascript_TestResults = _javascript_TestResults ? new BuildbotTestResults(this, _javascript_TestResults) : null;
 
-            if (!this.apiTestResults || !this.apiTestResults.finished) {
-                var apiTestResults = collectTestResults.call(this, data, "run-api-tests");
-                this.apiTestResults = apiTestResults ? new BuildbotTestResults(this, apiTestResults) : null;
-            }
+            var apiTestResults = collectTestResults.call(this, data, "run-api-tests");
+            this.apiTestResults = apiTestResults ? new BuildbotTestResults(this, apiTestResults) : null;
 
-            if (!this.pythonTestResults || !this.pythonTestResults.finished) {
-                var pythonTestResults = collectTestResults.call(this, data, "webkitpy-test");
-                this.pythonTestResults = pythonTestResults ? new BuildbotTestResults(this, pythonTestResults) : null;
-            }
+            var pythonTestResults = collectTestResults.call(this, data, "webkitpy-test");
+            this.pythonTestResults = pythonTestResults ? new BuildbotTestResults(this, pythonTestResults) : null;
 
-            if (!this.perlTestResults || !this.perlTestResults.finished) {
-                var perlTestResults = collectTestResults.call(this, data, "webkitperl-test");
-                this.perlTestResults = perlTestResults ? new BuildbotTestResults(this, perlTestResults) : null;
-            }
+            var perlTestResults = collectTestResults.call(this, data, "webkitperl-test");
+            this.perlTestResults = perlTestResults ? new BuildbotTestResults(this, perlTestResults) : null;
 
-            if (!this.bindingTestResults || !this.bindingTestResults.finished) {
-                var bindingTestResults = collectTestResults.call(this, data, "bindings-generation-tests");
-                this.bindingTestResults = bindingTestResults ? new BuildbotTestResults(this, bindingTestResults) : null;
-            }
+            var bindingTestResults = collectTestResults.call(this, data, "bindings-generation-tests");
+            this.bindingTestResults = bindingTestResults ? new BuildbotTestResults(this, bindingTestResults) : null;
 
             this.loaded = true;

Modified: trunk/Tools/ChangeLog (157184 => 157185)


--- trunk/Tools/ChangeLog	2013-10-09 21:01:10 UTC (rev 157184)
+++ trunk/Tools/ChangeLog	2013-10-09 21:34:28 UTC (rev 157185)
@@ -1,3 +1,14 @@
+2013-10-09  Timothy Hatcher  <[email protected]>
+
+        Attempt to fix faulty Dashboard iteration updating by always rebuilding test result objects.
+
+        https://bugs.webkit.org/show_bug.cgi?id=122515
+
+        Reviewed by Alexey Proskuryakov.
+
+        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
+        (BuildbotIteration.prototype.update):
+
 2013-10-09  Alexey Proskuryakov  <[email protected]>
 
         http://build.webkit.org/dashboard/ links to a wrong jscore-test results page

_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to