Title: [157190] trunk/Tools
Revision
157190
Author
[email protected]
Date
2013-10-09 15:32:03 -0700 (Wed, 09 Oct 2013)

Log Message

http://build.webkit.org/dashboard/ doesn't link to webkitpy failures
https://bugs.webkit.org/show_bug.cgi?id=122471

Reviewed by Tim Hatcher.

Added links to webkitpy, webkitperl and bindings-tests results.

* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
(Buildbot.prototype.apiTestResultsURLForIteration):
(Buildbot.prototype.webkitpyTestResultsURLForIteration):
(Buildbot.prototype.webkitperlTestResultsURLForIteration):
(Buildbot.prototype.bindingsTestResultsURLForIteration):
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
(BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):

Modified Paths

Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js (157189 => 157190)


--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js	2013-10-09 22:03:54 UTC (rev 157189)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js	2013-10-09 22:32:03 UTC (rev 157190)
@@ -82,5 +82,20 @@
     apiTestResultsURLForIteration: function(iteration)
     {
         return this.baseURL + "builders/" + encodeURIComponent(iteration.queue.id) + "/builds/" + iteration.id + "/steps/run-api-tests/logs/stdio";
+    },
+
+    webkitpyTestResultsURLForIteration: function(iteration)
+    {
+        return this.baseURL + "builders/" + encodeURIComponent(iteration.queue.id) + "/builds/" + iteration.id + "/steps/webkitpy-test/logs/stdio";
+    },
+
+    webkitperlTestResultsURLForIteration: function(iteration)
+    {
+        return this.baseURL + "builders/" + encodeURIComponent(iteration.queue.id) + "/builds/" + iteration.id + "/steps/webkitperl-test/logs/stdio";
+    },
+
+    bindingsTestResultsURLForIteration: function(iteration)
+    {
+        return this.baseURL + "builders/" + encodeURIComponent(iteration.queue.id) + "/builds/" + iteration.id + "/steps/bindings-generation-test/logs/stdio";
     }
 };

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js (157189 => 157190)


--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js	2013-10-09 22:03:54 UTC (rev 157189)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js	2013-10-09 22:32:03 UTC (rev 157190)
@@ -83,11 +83,14 @@
                     var url = ""
                     var status = new StatusLineView(messageLinkElement, StatusLineView.Status.Bad, apiTestResults.failureCount === 1 ? "api test failure" : "api test failures", apiTestResults.failureCount, url);
                 } else if (!layoutTestResults.failureCount && !_javascript_TestResults.failureCount && !apiTestResults.failureCount && pythonTestResults.failureCount && !perlTestResults.failureCount && !bindingTestResults.errorOccurred) {
-                    var status = new StatusLineView(messageLinkElement, StatusLineView.Status.Bad, pythonTestResults.failureCount === 1 ? "webkitpy test failure" : "webkitpy test failures", pythonTestResults.failureCount);
+                    var url = ""
+                    var status = new StatusLineView(messageLinkElement, StatusLineView.Status.Bad, pythonTestResults.failureCount === 1 ? "webkitpy test failure" : "webkitpy test failures", pythonTestResults.failureCount, url);
                 } else if (!layoutTestResults.failureCount && !_javascript_TestResults.failureCount && !apiTestResults.failureCount && !pythonTestResults.failureCount && perlTestResults.failureCount && !bindingTestResults.errorOccurred) {
-                    var status = new StatusLineView(messageLinkElement, StatusLineView.Status.Bad, perlTestResults.failureCount === 1 ? "webkitperl test failure" : "webkitperl test failures", perlTestResults.failureCount);
+                    var url = ""
+                    var status = new StatusLineView(messageLinkElement, StatusLineView.Status.Bad, perlTestResults.failureCount === 1 ? "webkitperl test failure" : "webkitperl test failures", perlTestResults.failureCount, url);
                 } else if (!layoutTestResults.failureCount && !_javascript_TestResults.failureCount && !apiTestResults.failureCount && !pythonTestResults.failureCount && !perlTestResults.failureCount && bindingTestResults.errorOccurred) {
-                    var status = new StatusLineView(messageLinkElement, StatusLineView.Status.Bad, "binding tests failed");
+                    var url = ""
+                    var status = new StatusLineView(messageLinkElement, StatusLineView.Status.Bad, "bindings tests failed", undefined, url);
                 } else {
                     var url = ""
                     var totalFailures = layoutTestResults.failureCount + _javascript_TestResults.failureCount + apiTestResults.failureCount + pythonTestResults.failureCount + perlTestResults.failureCount + bindingTestResults.errorOccurred;

Modified: trunk/Tools/ChangeLog (157189 => 157190)


--- trunk/Tools/ChangeLog	2013-10-09 22:03:54 UTC (rev 157189)
+++ trunk/Tools/ChangeLog	2013-10-09 22:32:03 UTC (rev 157190)
@@ -1,5 +1,22 @@
 2013-10-09  Alexey Proskuryakov  <[email protected]>
 
+        http://build.webkit.org/dashboard/ doesn't link to webkitpy failures
+        https://bugs.webkit.org/show_bug.cgi?id=122471
+
+        Reviewed by Tim Hatcher.
+
+        Added links to webkitpy, webkitperl and bindings-tests results.
+
+        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
+        (Buildbot.prototype.apiTestResultsURLForIteration):
+        (Buildbot.prototype.webkitpyTestResultsURLForIteration):
+        (Buildbot.prototype.webkitperlTestResultsURLForIteration):
+        (Buildbot.prototype.bindingsTestResultsURLForIteration):
+        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
+        (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
+
+2013-10-09  Alexey Proskuryakov  <[email protected]>
+
         Move some functions from WebKitBuildbot to Buildbot class.
 
         Suggested by Tim Hatcher.
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to