Title: [157394] trunk
- Revision
- 157394
- Author
- ma...@webkit.org
- Date
- 2013-10-14 03:41:26 -0700 (Mon, 14 Oct 2013)
Log Message
[EFL] Present replaced objects with 0xFFFC character
https://bugs.webkit.org/show_bug.cgi?id=122744
Patch by Krzysztof Czech <k.cz...@samsung.com> on 2013-10-14
Reviewed by Mario Sanchez Prada.
Source/WebCore:
Replaced elements should be emitted in GTK/EFL and
marked their presence with the replacement character.
* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::textIteratorBehaviorForTextRange):
LayoutTests:
Added new accessibility expectation after r156532.
* platform/efl-wk2/TestExpectations:
* platform/efl/accessibility/deleting-iframe-destroys-axcache-expected.txt: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (157393 => 157394)
--- trunk/LayoutTests/ChangeLog 2013-10-14 10:36:39 UTC (rev 157393)
+++ trunk/LayoutTests/ChangeLog 2013-10-14 10:41:26 UTC (rev 157394)
@@ -1,3 +1,15 @@
+2013-10-14 Krzysztof Czech <k.cz...@samsung.com>
+
+ [EFL] Present replaced objects with 0xFFFC character
+ https://bugs.webkit.org/show_bug.cgi?id=122744
+
+ Reviewed by Mario Sanchez Prada.
+
+ Added new accessibility expectation after r156532.
+
+ * platform/efl-wk2/TestExpectations:
+ * platform/efl/accessibility/deleting-iframe-destroys-axcache-expected.txt: Added.
+
2013-09-16 Sergio Villar Senin <svil...@igalia.com>
[CSS Grid Layout] Implement support for <flex>
Added: trunk/LayoutTests/platform/efl/accessibility/deleting-iframe-destroys-axcache-expected.txt (0 => 157394)
--- trunk/LayoutTests/platform/efl/accessibility/deleting-iframe-destroys-axcache-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/efl/accessibility/deleting-iframe-destroys-axcache-expected.txt 2013-10-14 10:41:26 UTC (rev 157394)
@@ -0,0 +1,41 @@
+Before
+
+After
+
+End of test
+
+This tests that deleting an iframe doesn't cause the accessibility cache to be destroyed and recreated.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+
+Before:
+AXRole: AXScrollArea
+ AXRole: AXWebArea
+ AXRole: AXParagraph AXValue: Before
+ AXRole: AXGroup AXValue: <obj>
+ AXRole: AXScrollArea
+ AXRole: AXWebArea
+ AXRole: AXGroup AXValue: <obj>Click me
+ AXRole: AXButton
+ AXRole: AXParagraph AXValue: After
+ AXRole: AXParagraph AXValue: End of test
+
+After:
+AXRole: AXScrollArea
+ AXRole: AXWebArea
+ AXRole: AXParagraph AXValue: Before
+ AXRole: AXParagraph AXValue: After
+ AXRole: AXParagraph AXValue: End of test
+
+PASS frameBodyRole == frameBody.role is false
+PASS frameGroupRole == frameGroup.role is false
+PASS frameButtonRole == frameButton.role is false
+PASS root.isEqual(newRoot) is true
+PASS body.isEqual(newBody) is true
+PASS before.isEqual(newBefore) is true
+PASS after.isEqual(newAfter) is true
+
+TEST COMPLETE
+
Modified: trunk/LayoutTests/platform/efl-wk2/TestExpectations (157393 => 157394)
--- trunk/LayoutTests/platform/efl-wk2/TestExpectations 2013-10-14 10:36:39 UTC (rev 157393)
+++ trunk/LayoutTests/platform/efl-wk2/TestExpectations 2013-10-14 10:41:26 UTC (rev 157394)
@@ -180,7 +180,6 @@
webkit.org/b/112019 accessibility/title-ui-element-correctness.html [ Failure ]
-accessibility/deleting-iframe-destroys-axcache.html [ Skip ]
accessibility/img-fallsback-to-title.html [ Skip ]
accessibility/internal-link-anchors2.html [ Skip ]
accessibility/media-element.html [ Skip ]
Modified: trunk/Source/WebCore/ChangeLog (157393 => 157394)
--- trunk/Source/WebCore/ChangeLog 2013-10-14 10:36:39 UTC (rev 157393)
+++ trunk/Source/WebCore/ChangeLog 2013-10-14 10:41:26 UTC (rev 157394)
@@ -1,3 +1,16 @@
+2013-10-14 Krzysztof Czech <k.cz...@samsung.com>
+
+ [EFL] Present replaced objects with 0xFFFC character
+ https://bugs.webkit.org/show_bug.cgi?id=122744
+
+ Reviewed by Mario Sanchez Prada.
+
+ Replaced elements should be emitted in GTK/EFL and
+ marked their presence with the replacement character.
+
+ * accessibility/AccessibilityObject.cpp:
+ (WebCore::AccessibilityObject::textIteratorBehaviorForTextRange):
+
2013-09-16 Sergio Villar Senin <svil...@igalia.com>
[CSS Grid Layout] Implement support for <flex>
Modified: trunk/Source/WebCore/accessibility/AccessibilityObject.cpp (157393 => 157394)
--- trunk/Source/WebCore/accessibility/AccessibilityObject.cpp 2013-10-14 10:36:39 UTC (rev 157393)
+++ trunk/Source/WebCore/accessibility/AccessibilityObject.cpp 2013-10-14 10:41:26 UTC (rev 157394)
@@ -1960,7 +1960,7 @@
{
TextIteratorBehavior behavior = TextIteratorIgnoresStyleVisibility;
-#if PLATFORM(GTK)
+#if PLATFORM(GTK) || PLATFORM(EFL)
// We need to emit replaced elements for GTK, and present
// them with the 'object replacement character' (0xFFFC).
behavior = static_cast<TextIteratorBehavior>(behavior | TextIteratorEmitsObjectReplacementCharacters);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
