Title: [157532] trunk/Source/_javascript_Core
Revision
157532
Author
commit-qu...@webkit.org
Date
2013-10-16 15:10:23 -0700 (Wed, 16 Oct 2013)

Log Message

Remove useless architecture specific implementation in DFG.
https://bugs.webkit.org/show_bug.cgi?id=122917.

Patch by Julien Brianceau <jbria...@cisco.com> on 2013-10-16
Reviewed by Michael Saboff.

With CPU(ARM) && CPU(ARM_HARDFP) architecture, the fallback implementation is fine
as FPRInfo::argumentFPR0 == FPRInfo::returnValueFPR in this case.

* dfg/DFGSpeculativeJIT.h:

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (157531 => 157532)


--- trunk/Source/_javascript_Core/ChangeLog	2013-10-16 22:02:11 UTC (rev 157531)
+++ trunk/Source/_javascript_Core/ChangeLog	2013-10-16 22:10:23 UTC (rev 157532)
@@ -1,5 +1,17 @@
 2013-10-16  Julien Brianceau  <jbria...@cisco.com>
 
+        Remove useless architecture specific implementation in DFG.
+        https://bugs.webkit.org/show_bug.cgi?id=122917.
+
+        Reviewed by Michael Saboff.
+
+        With CPU(ARM) && CPU(ARM_HARDFP) architecture, the fallback implementation is fine
+        as FPRInfo::argumentFPR0 == FPRInfo::returnValueFPR in this case.
+
+        * dfg/DFGSpeculativeJIT.h:
+
+2013-10-16  Julien Brianceau  <jbria...@cisco.com>
+
         Remove unused JIT::restoreArgumentReferenceForTrampoline function.
         https://bugs.webkit.org/show_bug.cgi?id=122916.
 

Modified: trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.h (157531 => 157532)


--- trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.h	2013-10-16 22:02:11 UTC (rev 157531)
+++ trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.h	2013-10-16 22:10:23 UTC (rev 157532)
@@ -1801,27 +1801,11 @@
         }
         return call;
     }
-#elif CPU(ARM)
-#if CPU(ARM_HARDFP)
+#elif CPU(ARM) && !CPU(ARM_HARDFP)
     JITCompiler::Call appendCallWithExceptionCheckSetResult(const FunctionPtr& function, FPRReg result)
     {
         JITCompiler::Call call = appendCallWithExceptionCheck(function);
         if (result != InvalidFPRReg)
-            m_jit.moveDouble(FPRInfo::argumentFPR0, result);
-        return call;
-    }
-    JITCompiler::Call appendCallSetResult(const FunctionPtr& function, FPRReg result)
-    {
-        JITCompiler::Call call = appendCall(function);
-        if (result != InvalidFPRReg)
-            m_jit.moveDouble(FPRInfo::argumentFPR0, result);
-        return call;
-    }
-#else
-    JITCompiler::Call appendCallWithExceptionCheckSetResult(const FunctionPtr& function, FPRReg result)
-    {
-        JITCompiler::Call call = appendCallWithExceptionCheck(function);
-        if (result != InvalidFPRReg)
             m_jit.assembler().vmov(result, GPRInfo::returnValueGPR, GPRInfo::returnValueGPR2);
         return call;
     }
@@ -1832,8 +1816,7 @@
             m_jit.assembler().vmov(result, GPRInfo::returnValueGPR, GPRInfo::returnValueGPR2);
         return call;
     }
-#endif // CPU(ARM_HARDFP)
-#else
+#else // CPU(X86_64) || (CPU(ARM) && CPU(ARM_HARDFP)) || CPU(ARM64) || CPU(MIPS) || CPU(SH4)
     JITCompiler::Call appendCallWithExceptionCheckSetResult(const FunctionPtr& function, FPRReg result)
     {
         JITCompiler::Call call = appendCallWithExceptionCheck(function);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to