Title: [157554] trunk/Source/_javascript_Core
Revision
157554
Author
fpi...@apple.com
Date
2013-10-16 20:01:49 -0700 (Wed, 16 Oct 2013)

Log Message

JIT::appendCall() needs to killLastResultRegister() or equivalent since there's some really bad code that expects it
https://bugs.webkit.org/show_bug.cgi?id=122937

Reviewed by Geoffrey Garen.
        
JITStubCall used to do it.
        
This makes mozilla-tests.yaml/ecma/Statements/12.10-1.js.mozilla-baseline pass.

* jit/JIT.h:
(JSC::JIT::appendCall):

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (157553 => 157554)


--- trunk/Source/_javascript_Core/ChangeLog	2013-10-17 02:36:48 UTC (rev 157553)
+++ trunk/Source/_javascript_Core/ChangeLog	2013-10-17 03:01:49 UTC (rev 157554)
@@ -1,3 +1,17 @@
+2013-10-16  Filip Pizlo  <fpi...@apple.com>
+
+        JIT::appendCall() needs to killLastResultRegister() or equivalent since there's some really bad code that expects it
+        https://bugs.webkit.org/show_bug.cgi?id=122937
+
+        Reviewed by Geoffrey Garen.
+        
+        JITStubCall used to do it.
+        
+        This makes mozilla-tests.yaml/ecma/Statements/12.10-1.js.mozilla-baseline pass.
+
+        * jit/JIT.h:
+        (JSC::JIT::appendCall):
+
 2013-10-16  Michael Saboff  <msab...@apple.com>
 
         transition void cti_op_put_by_val* stubs to JIT operations

Modified: trunk/Source/_javascript_Core/jit/JIT.h (157553 => 157554)


--- trunk/Source/_javascript_Core/jit/JIT.h	2013-10-17 02:36:48 UTC (rev 157553)
+++ trunk/Source/_javascript_Core/jit/JIT.h	2013-10-17 03:01:49 UTC (rev 157554)
@@ -362,6 +362,11 @@
         {
             Call functionCall = call();
             m_calls.append(CallRecord(functionCall, m_bytecodeOffset, function.value()));
+#if USE(JSVALUE32_64)
+            unmap();
+#else
+            killLastResultRegister();
+#endif
             return functionCall;
         }
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to