Title: [157572] trunk/Source/_javascript_Core
Revision
157572
Author
mark....@apple.com
Date
2013-10-17 06:47:25 -0700 (Thu, 17 Oct 2013)

Log Message

Remove JITStackFrame references in the C Loop LLINT.
https://bugs.webkit.org/show_bug.cgi?id=122950.

Reviewed by Michael Saboff.

* jit/JITStubs.h:
* llint/LowLevelInterpreter.cpp:
(JSC::CLoop::execute):
* offlineasm/cloop.rb:

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (157571 => 157572)


--- trunk/Source/_javascript_Core/ChangeLog	2013-10-17 13:43:20 UTC (rev 157571)
+++ trunk/Source/_javascript_Core/ChangeLog	2013-10-17 13:47:25 UTC (rev 157572)
@@ -1,5 +1,17 @@
 2013-10-17  Mark Lam  <mark....@apple.com>
 
+        Remove JITStackFrame references in the C Loop LLINT.
+        https://bugs.webkit.org/show_bug.cgi?id=122950.
+
+        Reviewed by Michael Saboff.
+
+        * jit/JITStubs.h:
+        * llint/LowLevelInterpreter.cpp:
+        (JSC::CLoop::execute):
+        * offlineasm/cloop.rb:
+
+2013-10-17  Mark Lam  <mark....@apple.com>
+
         Remove JITStackFrame references in JIT probes.
         https://bugs.webkit.org/show_bug.cgi?id=122947.
 

Modified: trunk/Source/_javascript_Core/jit/JITStubs.h (157571 => 157572)


--- trunk/Source/_javascript_Core/jit/JITStubs.h	2013-10-17 13:43:20 UTC (rev 157571)
+++ trunk/Source/_javascript_Core/jit/JITStubs.h	2013-10-17 13:47:25 UTC (rev 157572)
@@ -367,14 +367,8 @@
 
 } // extern "C"
 
-#elif ENABLE(LLINT_C_LOOP)
+#endif // ENABLE(JIT)
 
-struct JITStackFrame {
-    VM* vm;
-};
-
-#endif // ENABLE(LLINT_C_LOOP)
-
 } // namespace JSC
 
 #endif // JITStubs_h

Modified: trunk/Source/_javascript_Core/llint/LowLevelInterpreter.cpp (157571 => 157572)


--- trunk/Source/_javascript_Core/llint/LowLevelInterpreter.cpp	2013-10-17 13:43:20 UTC (rev 157571)
+++ trunk/Source/_javascript_Core/llint/LowLevelInterpreter.cpp	2013-10-17 13:47:25 UTC (rev 157572)
@@ -314,17 +314,8 @@
     t0.i = 0;
     t1.i = 0;
 
-    // Instantiate the pseudo JIT stack frame used by the LLINT C Loop backend:
-    JITStackFrame jitStackFrame;
+    VM* vm = &callFrame->vm();
 
-    // The llint expects the native stack pointer, sp, to be pointing to the
-    // jitStackFrame (which is the simulation of the native stack frame):
-    JITStackFrame* const sp = &jitStackFrame;
-    sp->vm = &callFrame->vm();
-
-    // Set up an alias for the vm ptr in the JITStackFrame:
-    VM* &vm = sp->vm;
-
     CodeBlock* codeBlock = callFrame->codeBlock();
     Instruction* vPC;
 

Modified: trunk/Source/_javascript_Core/offlineasm/cloop.rb (157571 => 157572)


--- trunk/Source/_javascript_Core/offlineasm/cloop.rb	2013-10-17 13:43:20 UTC (rev 157571)
+++ trunk/Source/_javascript_Core/offlineasm/cloop.rb	2013-10-17 13:47:25 UTC (rev 157572)
@@ -176,10 +176,7 @@
         end
     end
     def pointerExpr
-        if base.is_a? RegisterID and base.name == "sp" 
-            offsetValue = "#{offset.value}"
-            "(ASSERT(#{offsetValue} == offsetof(JITStackFrame, vm)), &sp->vm)"
-        elsif offset.value == 0
+        if  offset.value == 0
             "#{base.clValue(:int8Ptr)}"
         elsif offset.value > 0
             "#{base.clValue(:int8Ptr)} + #{offset.value}"
@@ -248,12 +245,7 @@
         end
     end
     def pointerExpr
-        if base.is_a? RegisterID and base.name == "sp"
-            offsetValue = "(#{index.clValue} << #{scaleShift}) + #{offset.clValue})"
-            "(ASSERT(#{offsetValue} == offsetof(JITStackFrame, vm)), &sp->vm)"
-        else
-            "#{base.clValue(:int8Ptr)} + (#{index.clValue} << #{scaleShift}) + #{offset.clValue}"
-        end
+        "#{base.clValue(:int8Ptr)} + (#{index.clValue} << #{scaleShift}) + #{offset.clValue}"
     end
     def int8MemRef
         "*CAST<int8_t*>(#{pointerExpr})"
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to