Title: [157602] trunk/Source/WebKit/blackberry
- Revision
- 157602
- Author
- zhaji...@rim.com
- Date
- 2013-10-17 14:38:41 -0700 (Thu, 17 Oct 2013)
Log Message
[BlackBerry] Improve the viewport of some websites like mobilesyrup.com/2013/08/25/moto-x-review/
https://bugs.webkit.org/show_bug.cgi?id=122995
Patch by Jacky Jiang <zhaji...@blackberry.com> on 2013-10-17.
Reviewed by George Staikos.
Internally reviewed by George Staikos and Eli Fidler.
JIRA 523949
Force to respect the viewport when there is viewport meta tag but width
is not specified even though the viewport is broken. By doing that, We
want to improve the user experience of some websites that use a reasonable
initial-scale, but have some overly-wide contents
The contents of those websites like mobilesyrup.com/2013/08/25/moto-x-review
should be improved by the contents provider eventually.
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::recomputeVirtualViewportFromViewportArguments):
Modified Paths
Diff
Modified: trunk/Source/WebKit/blackberry/Api/WebPage.cpp (157601 => 157602)
--- trunk/Source/WebKit/blackberry/Api/WebPage.cpp 2013-10-17 21:38:21 UTC (rev 157601)
+++ trunk/Source/WebKit/blackberry/Api/WebPage.cpp 2013-10-17 21:38:41 UTC (rev 157602)
@@ -3385,6 +3385,11 @@
if (m_viewportArguments == defaultViewportArguments)
return IntSize();
+ // We want to respect viewport when width is not specified in the viewport meta tag in order to improve the
+ // user experience of some websites that use a reasonable initial-scale, but have some overly-wide contents.
+ if (m_viewportArguments.width == ViewportArguments::ValueAuto)
+ m_forceRespectViewportArguments = true;
+
int desktopWidth = DEFAULT_MAX_LAYOUT_WIDTH;
int deviceWidth = Platform::Graphics::Screen::primaryScreen()->width();
int deviceHeight = Platform::Graphics::Screen::primaryScreen()->height();
Modified: trunk/Source/WebKit/blackberry/ChangeLog (157601 => 157602)
--- trunk/Source/WebKit/blackberry/ChangeLog 2013-10-17 21:38:21 UTC (rev 157601)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2013-10-17 21:38:41 UTC (rev 157602)
@@ -1,3 +1,23 @@
+2013-10-17 Jacky Jiang <zhaji...@blackberry.com>
+
+ [BlackBerry] Improve the viewport of some websites like mobilesyrup.com/2013/08/25/moto-x-review/
+ https://bugs.webkit.org/show_bug.cgi?id=122995
+
+ Reviewed by George Staikos.
+ Internally reviewed by George Staikos and Eli Fidler.
+
+ JIRA 523949
+ Force to respect the viewport when there is viewport meta tag but width
+ is not specified even though the viewport is broken. By doing that, We
+ want to improve the user experience of some websites that use a reasonable
+ initial-scale, but have some overly-wide contents
+
+ The contents of those websites like mobilesyrup.com/2013/08/25/moto-x-review
+ should be improved by the contents provider eventually.
+
+ * Api/WebPage.cpp:
+ (BlackBerry::WebKit::WebPagePrivate::recomputeVirtualViewportFromViewportArguments):
+
2013-10-16 Jochen Eisinger <joc...@chromium.org>
A page should exit fullscreen mode if it opens a new popup
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
