Title: [157615] trunk/Source/WebCore
- Revision
- 157615
- Author
- a...@apple.com
- Date
- 2013-10-17 17:52:54 -0700 (Thu, 17 Oct 2013)
Log Message
Don't add an include for return type of a [Custom] function in generated bindings code
https://bugs.webkit.org/show_bug.cgi?id=122972
Reviewed by Sam Weinig.
* bindings/scripts/CodeGeneratorJS.pm: (GenerateImplementation): Don't.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (157614 => 157615)
--- trunk/Source/WebCore/ChangeLog 2013-10-17 23:35:47 UTC (rev 157614)
+++ trunk/Source/WebCore/ChangeLog 2013-10-18 00:52:54 UTC (rev 157615)
@@ -1,3 +1,12 @@
+2013-10-17 Alexey Proskuryakov <a...@apple.com>
+
+ Don't add an include for return type of a [Custom] function in generated bindings code
+ https://bugs.webkit.org/show_bug.cgi?id=122972
+
+ Reviewed by Sam Weinig.
+
+ * bindings/scripts/CodeGeneratorJS.pm: (GenerateImplementation): Don't.
+
2013-10-17 Andreas Kling <akl...@apple.com>
CTTE: RenderMathMLSpace always has a MathMLTextElement.
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (157614 => 157615)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2013-10-17 23:35:47 UTC (rev 157614)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2013-10-18 00:52:54 UTC (rev 157615)
@@ -2330,14 +2330,14 @@
# Functions
if ($numFunctions > 0) {
foreach my $function (@{$interface->functions}) {
- AddIncludesForTypeInImpl($function->signature->type);
-
my $isCustom = HasCustomMethod($function->signature->extendedAttributes);
my $isOverloaded = $function->{overloads} && @{$function->{overloads}} > 1;
my $raisesException = $function->signature->extendedAttributes->{"RaisesException"};
next if $isCustom && $isOverloaded && $function->{overloadIndex} > 1;
+ AddIncludesForTypeInImpl($function->signature->type) unless $isCustom;
+
my $functionName = GetFunctionName($className, $function);
my $conditional = $function->signature->extendedAttributes->{"Conditional"};
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
