[webkit-changes] [158151] trunk/Tools

Mon, 28 Oct 2013 18:36:45 -0700

Title: [158151] trunk/Tools
Revision
158151
Author
[email protected]
Date
2013-10-28 18:38:06 -0700 (Mon, 28 Oct 2013)

Log Message

Add tooltips to the platform icons in Dashboard
https://bugs.webkit.org/show_bug.cgi?id=123429

Reviewed by Alexey Proskuryakov.

Add a human readable name to Buildbot.Platform entries, and use it to
show a tooltip on the ring image.

* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
(documentReady):

Modified Paths

Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js (158150 => 158151)


--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js	2013-10-29 01:38:05 UTC (rev 158150)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js	2013-10-29 01:38:06 UTC (rev 158151)
@@ -41,15 +41,15 @@
 
 // Ordered importance/recency.
 Buildbot.Platform = {
-    MacOSXMavericks: { name: "mac-os-x-mavericks", order: 10 },
-    MacOSXMountainLion: { name: "mac-os-x-mountain-lion", order: 20 },
-    MacOSXLion: { name : "mac-os-x-lion", order: 30 },
-    Windows8: { name: "windows-8", order: 40 },
-    Windows7: { name: "windows-7", order: 50 },
-    WindowsXP: { name: "windows-xp", order: 60 },
-    LinuxQt: { name : "linux-qt", order: 70 },
-    LinuxGTK: { name : "linux-gtk", order: 80 },
-    LinuxEFL: { name: "linux-efl", order : 90 }
+    MacOSXMavericks: { name: "mac-os-x-mavericks", readableName: "OS X Mavericks", order: 10 },
+    MacOSXMountainLion: { name: "mac-os-x-mountain-lion", readableName: "OS X Mountain Lion", order: 20 },
+    MacOSXLion: { name : "mac-os-x-lion", readableName: "Mac OS X MountainLion", order: 30 },
+    Windows8: { name: "windows-8", readableName: "Windows 8", order: 40 },
+    Windows7: { name: "windows-7", readableName: "Windows 7", order: 50 },
+    WindowsXP: { name: "windows-xp", readableName: "Windows XP", order: 60 },
+    LinuxQt: { name : "linux-qt", readableName: "Linux Qt", order: 70 },
+    LinuxGTK: { name : "linux-gtk", readableName: "Linux GTK", order: 80 },
+    LinuxEFL: { name: "linux-efl", readableName: "Linux EFL", order : 90 }
 };
 
 // Ordered importance.

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js (158150 => 158151)


--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js	2013-10-29 01:38:05 UTC (rev 158150)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js	2013-10-29 01:38:06 UTC (rev 158151)
@@ -115,6 +115,7 @@
 
         var ringImage = document.createElement("img");
         ringImage.classList.add("ring");
+        ringImage.title = platform.readableName;
         cell.appendChild(ringImage);
 
         var logoImage = document.createElement("img");

Modified: trunk/Tools/ChangeLog (158150 => 158151)


--- trunk/Tools/ChangeLog	2013-10-29 01:38:05 UTC (rev 158150)
+++ trunk/Tools/ChangeLog	2013-10-29 01:38:06 UTC (rev 158151)
@@ -1,5 +1,19 @@
 2013-10-28  Simon Fraser  <[email protected]>
 
+        Add tooltips to the platform icons in Dashboard
+        https://bugs.webkit.org/show_bug.cgi?id=123429
+
+        Reviewed by Alexey Proskuryakov.
+        
+        Add a human readable name to Buildbot.Platform entries, and use it to
+        show a tooltip on the ring image.
+
+        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
+        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
+        (documentReady):
+
+2013-10-28  Simon Fraser  <[email protected]>
+
         Allow explicit sort order for Dashboard platforms
         https://bugs.webkit.org/show_bug.cgi?id=123419
 

_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to