Title: [158292] trunk/Source/WebCore
Revision
158292
Author
commit-qu...@webkit.org
Date
2013-10-30 11:22:34 -0700 (Wed, 30 Oct 2013)

Log Message

Favicons are flipped in vertical direction in WinCairo builds.
https://bugs.webkit.org/show_bug.cgi?id=102077

Patch by pe...@outlook.com <pe...@outlook.com> on 2013-10-30
Reviewed by Brent Fulgham.

* platform/graphics/win/ImageCairoWin.cpp:
(WebCore::BitmapImage::getHBITMAPOfSize):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (158291 => 158292)


--- trunk/Source/WebCore/ChangeLog	2013-10-30 18:18:28 UTC (rev 158291)
+++ trunk/Source/WebCore/ChangeLog	2013-10-30 18:22:34 UTC (rev 158292)
@@ -1,3 +1,13 @@
+2013-10-30  pe...@outlook.com  <pe...@outlook.com>
+
+        Favicons are flipped in vertical direction in WinCairo builds.
+        https://bugs.webkit.org/show_bug.cgi?id=102077
+
+        Reviewed by Brent Fulgham.
+
+        * platform/graphics/win/ImageCairoWin.cpp:
+        (WebCore::BitmapImage::getHBITMAPOfSize):
+
 2013-10-30  Jer Noble  <jer.no...@apple.com>
 
         [MSE] Add MediaSource compatable loading functions to MediaPlayer

Modified: trunk/Source/WebCore/platform/graphics/win/ImageCairoWin.cpp (158291 => 158292)


--- trunk/Source/WebCore/platform/graphics/win/ImageCairoWin.cpp	2013-10-30 18:18:28 UTC (rev 158291)
+++ trunk/Source/WebCore/platform/graphics/win/ImageCairoWin.cpp	2013-10-30 18:22:34 UTC (rev 158292)
@@ -68,12 +68,9 @@
         memset(bmpInfo.bmBits, 255, bufferSize);
     }
 
-    cairo_surface_t* image = cairo_image_surface_create_for_data((unsigned char*)bmpInfo.bmBits,
-                                               CAIRO_FORMAT_ARGB32,
-                                               bmpInfo.bmWidth,
-                                               bmpInfo.bmHeight,
-                                               bmpInfo.bmWidthBytes);
+    unsigned char* bmpdata = (unsigned char*)bmpInfo.bmBits + bmpInfo.bmWidthBytes*(bmpInfo.bmHeight-1);
 
+    cairo_surface_t* image = cairo_image_surface_create_for_data(bmpdata, CAIRO_FORMAT_ARGB32, bmpInfo.bmWidth, bmpInfo.bmHeight, -bmpInfo.bmWidthBytes);
 
     cairo_t* targetRef = cairo_create(image);
     cairo_surface_destroy(image);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to