Title: [158332] trunk
- Revision
- 158332
- Author
- samuel_wh...@apple.com
- Date
- 2013-10-30 17:31:43 -0700 (Wed, 30 Oct 2013)
Log Message
AX: AXFocused not exposed on ARIA menuitems
https://bugs.webkit.org/show_bug.cgi?id=123494
Reviewed by Chris Fleizach.
Source/WebCore:
ARIA menuitems should expose AXFocused accessibility attribute.
Test: platform/mac/accessibility/aria-menuitem-focus.html
* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityAttributeNames]):
LayoutTests:
Adding test to make sure ARIA menuitems expose each piece of their focus state correctly.
* platform/mac/accessibility/aria-menuitem-focus-expected.txt: Added.
* platform/mac/accessibility/aria-menuitem-focus.html: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (158331 => 158332)
--- trunk/LayoutTests/ChangeLog 2013-10-31 00:26:12 UTC (rev 158331)
+++ trunk/LayoutTests/ChangeLog 2013-10-31 00:31:43 UTC (rev 158332)
@@ -1,3 +1,15 @@
+2013-10-30 Samuel White <samuel_wh...@apple.com>
+
+ AX: AXFocused not exposed on ARIA menuitems
+ https://bugs.webkit.org/show_bug.cgi?id=123494
+
+ Reviewed by Chris Fleizach.
+
+ Adding test to make sure ARIA menuitems expose each piece of their focus state correctly.
+
+ * platform/mac/accessibility/aria-menuitem-focus-expected.txt: Added.
+ * platform/mac/accessibility/aria-menuitem-focus.html: Added.
+
2013-10-30 Ryosuke Niwa <rn...@webkit.org>
Delete the expected results for Lion.
Added: trunk/LayoutTests/platform/mac/accessibility/aria-menuitem-focus-expected.txt (0 => 158332)
--- trunk/LayoutTests/platform/mac/accessibility/aria-menuitem-focus-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/mac/accessibility/aria-menuitem-focus-expected.txt 2013-10-31 00:31:43 UTC (rev 158332)
@@ -0,0 +1,19 @@
+Item 0
+Item 1
+This tests that ARIA menuitems expose AXFocused correctly.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS item.isAttributeSupported('AXFocused') is true
+PASS item.isAttributeSettable('AXFocused') is true
+PASS item.boolAttributeValue('AXFocused') is false
+PASS item.boolAttributeValue('AXFocused') is true
+PASS item.isAttributeSupported('AXFocused') is true
+PASS item.isAttributeSettable('AXFocused') is true
+PASS item.boolAttributeValue('AXFocused') is false
+PASS item.boolAttributeValue('AXFocused') is true
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/platform/mac/accessibility/aria-menuitem-focus.html (0 => 158332)
--- trunk/LayoutTests/platform/mac/accessibility/aria-menuitem-focus.html (rev 0)
+++ trunk/LayoutTests/platform/mac/accessibility/aria-menuitem-focus.html 2013-10-31 00:31:43 UTC (rev 158332)
@@ -0,0 +1,39 @@
+<!DOCTYPE html>
+<html>
+<head>
+<script src=""
+<title>ARIA menuitem Focus</title>
+</head>
+<body>
+
+<div role="menu">
+<div class="item" id="i0" role="menuitem" tabindex="-1">Item 0</div>
+<div class="item" id="i1" role="menuitem" tabindex="-1">Item 1</div>
+</div>
+
+<p id="description"></p>
+<div id="console"></div>
+
+<script>
+ description("This tests that ARIA menuitems expose AXFocused correctly.");
+
+ if (window.accessibilityController) {
+ var itemCount = document.getElementsByClassName("item").length;
+ for (var i = 0; i < itemCount; ++i) {
+ var item = accessibilityController.accessibleElementById("i" + i);
+
+ shouldBeTrue("item.isAttributeSupported('AXFocused')");
+ shouldBeTrue("item.isAttributeSettable('AXFocused')");
+ shouldBeFalse("item.boolAttributeValue('AXFocused')");
+
+ // Set focus.
+ document.getElementById("i" + i).focus();
+
+ shouldBeTrue("item.boolAttributeValue('AXFocused')");
+ }
+ }
+</script>
+
+<script src=""
+</body>
+</html>
Modified: trunk/Source/WebCore/ChangeLog (158331 => 158332)
--- trunk/Source/WebCore/ChangeLog 2013-10-31 00:26:12 UTC (rev 158331)
+++ trunk/Source/WebCore/ChangeLog 2013-10-31 00:31:43 UTC (rev 158332)
@@ -1,3 +1,17 @@
+2013-10-30 Samuel White <samuel_wh...@apple.com>
+
+ AX: AXFocused not exposed on ARIA menuitems
+ https://bugs.webkit.org/show_bug.cgi?id=123494
+
+ Reviewed by Chris Fleizach.
+
+ ARIA menuitems should expose AXFocused accessibility attribute.
+
+ Test: platform/mac/accessibility/aria-menuitem-focus.html
+
+ * accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
+ (-[WebAccessibilityObjectWrapper accessibilityAttributeNames]):
+
2013-10-30 Joseph Pecoraro <pecor...@apple.com>
Web Inspector: Remove basic uses of InspectorState from agents
Modified: trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm (158331 => 158332)
--- trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm 2013-10-31 00:26:12 UTC (rev 158331)
+++ trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm 2013-10-31 00:31:43 UTC (rev 158332)
@@ -1249,6 +1249,7 @@
[tempArray addObject:(NSString*)kAXMenuItemMarkCharAttribute];
[tempArray addObject:(NSString*)kAXMenuItemPrimaryUIElementAttribute];
[tempArray addObject:NSAccessibilityServesAsTitleForUIElementsAttribute];
+ [tempArray addObject:NSAccessibilityFocusedAttribute];
menuItemAttrs = [[NSArray alloc] initWithArray:tempArray];
[tempArray release];
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
