Title: [158437] trunk/Source/WebKit2
Revision
158437
Author
commit-qu...@webkit.org
Date
2013-11-01 10:44:00 -0700 (Fri, 01 Nov 2013)

Log Message

[GTK] [WK2] Crash in webkitWebViewLoadFailedWithTLSErrors
https://bugs.webkit.org/show_bug.cgi?id=123618

Patch by Brian Holt <brian.h...@samsung.com> on 2013-11-01
Reviewed by Mario Sanchez Prada.

The GOwnPtrSoup header was not included which meant that the
specialization for GOwnPtr<SoupURI> was not used and instead the
default freeOwnedGPtr which calls g_free is used and crashes.

* UIProcess/API/gtk/WebKitWebView.cpp:

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (158436 => 158437)


--- trunk/Source/WebKit2/ChangeLog	2013-11-01 16:30:03 UTC (rev 158436)
+++ trunk/Source/WebKit2/ChangeLog	2013-11-01 17:44:00 UTC (rev 158437)
@@ -1,3 +1,16 @@
+2013-11-01  Brian Holt  <brian.h...@samsung.com>
+
+        [GTK] [WK2] Crash in webkitWebViewLoadFailedWithTLSErrors
+        https://bugs.webkit.org/show_bug.cgi?id=123618
+
+        Reviewed by Mario Sanchez Prada.
+
+        The GOwnPtrSoup header was not included which meant that the
+        specialization for GOwnPtr<SoupURI> was not used and instead the
+        default freeOwnedGPtr which calls g_free is used and crashes.
+
+        * UIProcess/API/gtk/WebKitWebView.cpp:
+
 2013-10-31  Tim Horton  <timothy_hor...@apple.com>
 
         Fix a typo/review comment from Dan, in http://trac.webkit.org/changeset/158413

Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp (158436 => 158437)


--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp	2013-11-01 16:30:03 UTC (rev 158436)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp	2013-11-01 17:44:00 UTC (rev 158437)
@@ -62,6 +62,7 @@
 #include <_javascript_Core/APICast.h>
 #include <WebCore/DragIcon.h>
 #include <WebCore/GOwnPtrGtk.h>
+#include <WebCore/GOwnPtrSoup.h>
 #include <WebCore/GtkUtilities.h>
 #include <WebCore/RefPtrCairo.h>
 #include <glib/gi18n-lib.h>
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to