Title: [158469] trunk/Source/WebCore
- Revision
- 158469
- Author
- akl...@apple.com
- Date
- 2013-11-01 18:03:21 -0700 (Fri, 01 Nov 2013)
Log Message
CSSAspectRatioValue construction helper should return PassRef.
<https://webkit.org/b/123645>
Return PassRef instead of PassRefPtr from functions that return
ownership-passing pointers that are known to be non-null.
Reviewed by Darin Adler.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (158468 => 158469)
--- trunk/Source/WebCore/ChangeLog 2013-11-02 00:55:13 UTC (rev 158468)
+++ trunk/Source/WebCore/ChangeLog 2013-11-02 01:03:21 UTC (rev 158469)
@@ -1,3 +1,13 @@
+2013-11-01 Andreas Kling <akl...@apple.com>
+
+ CSSAspectRatioValue construction helper should return PassRef.
+ <https://webkit.org/b/123645>
+
+ Return PassRef instead of PassRefPtr from functions that return
+ ownership-passing pointers that are known to be non-null.
+
+ Reviewed by Darin Adler.
+
2013-11-01 Myles C. Maxfield <mmaxfi...@apple.com>
Initial implementation of text-decoration-skip ink
Modified: trunk/Source/WebCore/css/CSSAspectRatioValue.h (158468 => 158469)
--- trunk/Source/WebCore/css/CSSAspectRatioValue.h 2013-11-02 00:55:13 UTC (rev 158468)
+++ trunk/Source/WebCore/css/CSSAspectRatioValue.h 2013-11-02 01:03:21 UTC (rev 158469)
@@ -36,9 +36,9 @@
class CSSAspectRatioValue : public CSSValue {
public:
- static PassRefPtr<CSSAspectRatioValue> create(float numeratorValue, float denominatorValue)
+ static PassRef<CSSAspectRatioValue> create(float numeratorValue, float denominatorValue)
{
- return adoptRef(new CSSAspectRatioValue(numeratorValue, denominatorValue));
+ return adoptRef(*new CSSAspectRatioValue(numeratorValue, denominatorValue));
}
String customCSSText() const;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
