Title: [158858] trunk/Source/_javascript_Core
- Revision
- 158858
- Author
- [email protected]
- Date
- 2013-11-07 11:33:17 -0800 (Thu, 07 Nov 2013)
Log Message
returnFromJavaScript() for ARM_THUMB2 uses push()s which should be pop()s
https://bugs.webkit.org/show_bug.cgi?id=124006
Rubber stamped by Mark Hahnenberg.
Changed the push() calls to pop().
* jit/ThunkGenerators.cpp:
(JSC::returnFromJavaScript):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (158857 => 158858)
--- trunk/Source/_javascript_Core/ChangeLog 2013-11-07 19:23:12 UTC (rev 158857)
+++ trunk/Source/_javascript_Core/ChangeLog 2013-11-07 19:33:17 UTC (rev 158858)
@@ -1,5 +1,17 @@
2013-11-07 Michael Saboff <[email protected]>
+ returnFromJavaScript() for ARM_THUMB2 uses push()s which should be pop()s
+ https://bugs.webkit.org/show_bug.cgi?id=124006
+
+ Rubber stamped by Mark Hahnenberg.
+
+ Changed the push() calls to pop().
+
+ * jit/ThunkGenerators.cpp:
+ (JSC::returnFromJavaScript):
+
+2013-11-07 Michael Saboff <[email protected]>
+
Remove unneeded moving of ESP to ECX in callToJavaScript for COMPILER(MSVC)
https://bugs.webkit.org/show_bug.cgi?id=123998
Modified: trunk/Source/_javascript_Core/jit/ThunkGenerators.cpp (158857 => 158858)
--- trunk/Source/_javascript_Core/jit/ThunkGenerators.cpp 2013-11-07 19:23:12 UTC (rev 158857)
+++ trunk/Source/_javascript_Core/jit/ThunkGenerators.cpp 2013-11-07 19:33:17 UTC (rev 158858)
@@ -116,15 +116,15 @@
# define EXTRA_STACK_SIZE 28
jit.addPtr(CCallHelpers::TrustedImm32(EXTRA_STACK_SIZE), ARMRegisters::sp);
- jit.push(ARMRegisters::r11);
- jit.push(ARMRegisters::r10);
- jit.push(ARMRegisters::r9);
- jit.push(ARMRegisters::r8);
- jit.push(ARMRegisters::r7);
- jit.push(ARMRegisters::r6);
- jit.push(ARMRegisters::r5);
- jit.push(ARMRegisters::r4);
- jit.push(ARMRegisters::lr);
+ jit.pop(ARMRegisters::r11);
+ jit.pop(ARMRegisters::r10);
+ jit.pop(ARMRegisters::r9);
+ jit.pop(ARMRegisters::r8);
+ jit.pop(ARMRegisters::r7);
+ jit.pop(ARMRegisters::r6);
+ jit.pop(ARMRegisters::r5);
+ jit.pop(ARMRegisters::r4);
+ jit.pop(ARMRegisters::lr);
#elif CPU(ARM64)
jit.pop(ARM64Registers::x28);
jit.pop(ARM64Registers::x27);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
