Title: [158872] trunk/Source/WebKit2
- Revision
- 158872
- Author
- [email protected]
- Date
- 2013-11-07 13:54:36 -0800 (Thu, 07 Nov 2013)
Log Message
Don't repaint the view when the web process crashes
https://bugs.webkit.org/show_bug.cgi?id=124013
Reviewed by Dan Bernstein.
It's up to each individual port to decide whether the view should be repainted when the web process crashes.
* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::setViewNeedsDisplay):
(WebKit::PageClientImpl::displayView):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::resetStateAfterProcessExited):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (158871 => 158872)
--- trunk/Source/WebKit2/ChangeLog 2013-11-07 21:51:49 UTC (rev 158871)
+++ trunk/Source/WebKit2/ChangeLog 2013-11-07 21:54:36 UTC (rev 158872)
@@ -1,3 +1,18 @@
+2013-11-07 Anders Carlsson <[email protected]>
+
+ Don't repaint the view when the web process crashes
+ https://bugs.webkit.org/show_bug.cgi?id=124013
+
+ Reviewed by Dan Bernstein.
+
+ It's up to each individual port to decide whether the view should be repainted when the web process crashes.
+
+ * UIProcess/API/mac/PageClientImpl.mm:
+ (WebKit::PageClientImpl::setViewNeedsDisplay):
+ (WebKit::PageClientImpl::displayView):
+ * UIProcess/WebPageProxy.cpp:
+ (WebKit::WebPageProxy::resetStateAfterProcessExited):
+
2013-11-07 Tamas Gergely <[email protected]>
Report error on unknown template class usage.
Modified: trunk/Source/WebKit2/UIProcess/API/mac/PageClientImpl.mm (158871 => 158872)
--- trunk/Source/WebKit2/UIProcess/API/mac/PageClientImpl.mm 2013-11-07 21:51:49 UTC (rev 158871)
+++ trunk/Source/WebKit2/UIProcess/API/mac/PageClientImpl.mm 2013-11-07 21:54:36 UTC (rev 158872)
@@ -140,12 +140,12 @@
void PageClientImpl::setViewNeedsDisplay(const WebCore::IntRect& rect)
{
- [m_wkView setNeedsDisplayInRect:rect];
+ ASSERT_NOT_REACHED();
}
void PageClientImpl::displayView()
{
- [m_wkView displayIfNeeded];
+ ASSERT_NOT_REACHED();
}
bool PageClientImpl::canScrollView()
Modified: trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp (158871 => 158872)
--- trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp 2013-11-07 21:51:49 UTC (rev 158871)
+++ trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp 2013-11-07 21:54:36 UTC (rev 158872)
@@ -3796,12 +3796,6 @@
m_pageClient->clearAllEditCommands();
m_pendingLearnOrIgnoreWordMessageCount = 0;
- // If the call out to the loader client didn't cause the web process to be relaunched,
- // we'll call setNeedsDisplay on the view so that we won't have the old contents showing.
- // If the call did cause the web process to be relaunched, we'll keep the old page contents showing
- // until the new web process has painted its contents.
- setViewNeedsDisplay(IntRect(IntPoint(), viewSize()));
-
// Can't expect DidReceiveEvent notifications from a crashed web process.
m_keyEventQueue.clear();
m_wheelEventQueue.clear();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
