Title: [159282] trunk/Tools
- Revision
- 159282
- Author
- [email protected]
- Date
- 2013-11-14 04:50:07 -0800 (Thu, 14 Nov 2013)
Log Message
Fix Tools/Scripts/webkitpy/port/factory.py --help to display which configuration is default
https://bugs.webkit.org/show_bug.cgi?id=124143
Patch by Éva Balázsfalvi <[email protected]> on 2013-11-14
Reviewed by Csaba Osztrogonác.
* Scripts/webkitpy/port/factory.py:
(configuration_options):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (159281 => 159282)
--- trunk/Tools/ChangeLog 2013-11-14 11:25:40 UTC (rev 159281)
+++ trunk/Tools/ChangeLog 2013-11-14 12:50:07 UTC (rev 159282)
@@ -1,3 +1,13 @@
+2013-11-14 Éva Balázsfalvi <[email protected]>
+
+ Fix Tools/Scripts/webkitpy/port/factory.py --help to display which configuration is default
+ https://bugs.webkit.org/show_bug.cgi?id=124143
+
+ Reviewed by Csaba Osztrogonác.
+
+ * Scripts/webkitpy/port/factory.py:
+ (configuration_options):
+
2013-11-13 Anders Carlsson <[email protected]>
Add a Vector constructor that takes an std::initializer_list
Modified: trunk/Tools/Scripts/webkitpy/port/factory.py (159281 => 159282)
--- trunk/Tools/Scripts/webkitpy/port/factory.py 2013-11-14 11:25:40 UTC (rev 159281)
+++ trunk/Tools/Scripts/webkitpy/port/factory.py 2013-11-14 12:50:07 UTC (rev 159282)
@@ -34,6 +34,9 @@
import re
from webkitpy.port import builders
+from webkitpy.port import config
+from webkitpy.common.system import executive
+from webkitpy.common.system import filesystem
def platform_options(use_globs=False):
@@ -51,8 +54,7 @@
def configuration_options():
return [
- optparse.make_option("-t", "--target", dest="configuration", help="(DEPRECATED)"),
- # FIXME: --help should display which configuration is default.
+ optparse.make_option("-t", "--target", default=config.Config(executive.Executive(), filesystem.FileSystem()).default_configuration(), dest="configuration", help="(DEPRECATED) (default: %default)"),
optparse.make_option('--debug', action='', const='Debug', dest="configuration",
help='Set the configuration to Debug'),
optparse.make_option('--release', action='', const='Release', dest="configuration",
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
