Title: [159285] trunk/Tools
Revision
159285
Author
[email protected]
Date
2013-11-14 07:38:12 -0800 (Thu, 14 Nov 2013)

Log Message

run-perf-tests should warn loudly if you're using a Debug build.
https://bugs.webkit.org/show_bug.cgi?id=105236

Patch by Éva Balázsfalvi <[email protected]> on 2013-11-14
Reviewed by Csaba Osztrogonác.

* Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner.run):

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (159284 => 159285)


--- trunk/Tools/ChangeLog	2013-11-14 13:48:09 UTC (rev 159284)
+++ trunk/Tools/ChangeLog	2013-11-14 15:38:12 UTC (rev 159285)
@@ -1,5 +1,15 @@
 2013-11-14  Éva Balázsfalvi  <[email protected]>
 
+        run-perf-tests should warn loudly if you're using a Debug build.
+        https://bugs.webkit.org/show_bug.cgi?id=105236
+
+        Reviewed by Csaba Osztrogonác.
+
+        * Scripts/webkitpy/performance_tests/perftestsrunner.py:
+        (PerfTestsRunner.run):
+
+2013-11-14  Éva Balázsfalvi  <[email protected]>
+
         Fix Tools/Scripts/webkitpy/port/factory.py --help to display which configuration is default
         https://bugs.webkit.org/show_bug.cgi?id=124143
 

Modified: trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py (159284 => 159285)


--- trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py	2013-11-14 13:48:09 UTC (rev 159284)
+++ trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py	2013-11-14 15:38:12 UTC (rev 159285)
@@ -166,6 +166,11 @@
         return tests
 
     def run(self):
+        if "Debug" == self._port.get_option("configuration"):
+            _log.warning("""****************************************************
+* WARNING: run-perf-tests is running in DEBUG mode *
+****************************************************""")
+
         if not self._port.check_build(needs_http=False):
             _log.error("Build not up to date for %s" % self._port._path_to_driver())
             return self.EXIT_CODE_BAD_BUILD
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to