Diff
Modified: trunk/Source/WebKit2/ChangeLog (159332 => 159333)
--- trunk/Source/WebKit2/ChangeLog 2013-11-15 11:03:03 UTC (rev 159332)
+++ trunk/Source/WebKit2/ChangeLog 2013-11-15 13:09:28 UTC (rev 159333)
@@ -1,3 +1,55 @@
+2013-11-15 Tibor Meszaros <mti...@inf.u-szeged.hu>
+
+ Cleanup the build from unused parameters in WebKit2
+ https://bugs.webkit.org/show_bug.cgi?id=124201
+
+ Reviewed by Darin Adler.
+
+ * Shared/Plugins/Netscape/PluginInformation.cpp:
+ (WebKit::getPluginModuleInformation):
+ * UIProcess/API/C/WKBatteryManager.cpp:
+ (WKBatteryManagerSetProvider):
+ (WKBatteryManagerProviderDidChangeBatteryStatus):
+ (WKBatteryManagerProviderUpdateBatteryStatus):
+ * UIProcess/API/C/WKBatteryStatus.cpp:
+ (WKBatteryStatusCreate):
+ * UIProcess/API/C/WKColorPickerResultListener.cpp:
+ (WKColorPickerResultListenerSetColor):
+ * UIProcess/API/C/WKContext.cpp:
+ (WKContextGetBatteryManager):
+ (WKContextGetDatabaseManager):
+ (WKContextGetNetworkInfoManager):
+ * UIProcess/API/C/WKDatabaseManager.cpp:
+ (WKDatabaseManagerSetClient):
+ (WKDatabaseManagerGetDatabasesByOrigin):
+ (WKDatabaseManagerGetDatabaseOrigins):
+ (WKDatabaseManagerDeleteDatabasesWithNameForOrigin):
+ (WKDatabaseManagerDeleteDatabasesForOrigin):
+ (WKDatabaseManagerDeleteAllDatabases):
+ (WKDatabaseManagerSetQuotaForOrigin):
+ * UIProcess/API/C/WKNetworkInfo.cpp:
+ (WKNetworkInfoCreate):
+ * UIProcess/API/C/WKNetworkInfoManager.cpp:
+ (WKNetworkInfoManagerSetProvider):
+ (WKNetworkInfoManagerProviderDidChangeNetworkInformation):
+ * UIProcess/API/C/WKOpenPanelParameters.cpp:
+ (WKOpenPanelParametersCopyCapture):
+ * UIProcess/API/C/WKVibration.cpp:
+ (WKVibrationSetProvider):
+ * UIProcess/API/efl/EwkView.cpp:
+ (EwkView::createNewPage):
+ * UIProcess/WebPageProxy.cpp:
+ (WebKit::WebPageProxy::setVisibilityState):
+ (WebKit::WebPageProxy::unavailablePluginButtonClicked):
+ * UIProcess/efl/ViewClientEfl.cpp:
+ (WebKit::ViewClientEfl::didChangeContentsPosition):
+ (WebKit::ViewClientEfl::didRenderFrame):
+ (WebKit::ViewClientEfl::didChangeViewportAttributes):
+ * WebProcess/InjectedBundle/InjectedBundle.cpp:
+ (WebKit::InjectedBundle::setDatabaseQuota):
+ * WebProcess/WebCoreSupport/WebChromeClient.cpp:
+ (WebKit::WebChromeClient::createWindow):
+
2013-11-14 Dan Bernstein <m...@apple.com>
[Cocoa] WKBrowsingContextController's policy client implementation over-releases WKURLRequests and WKURLResponses
Modified: trunk/Source/WebKit2/Shared/Plugins/Netscape/PluginInformation.cpp (159332 => 159333)
--- trunk/Source/WebKit2/Shared/Plugins/Netscape/PluginInformation.cpp 2013-11-15 11:03:03 UTC (rev 159332)
+++ trunk/Source/WebKit2/Shared/Plugins/Netscape/PluginInformation.cpp 2013-11-15 13:09:28 UTC (rev 159333)
@@ -114,6 +114,9 @@
map.set(pluginInformationDefaultLoadPolicyKey(), WebUInt64::create(toWKPluginLoadPolicy(PluginInfoStore::defaultLoadPolicyForPlugin(plugin))));
getPlatformPluginModuleInformation(plugin, map);
+#else
+ UNUSED_PARAM(plugin);
+ UNUSED_PARAM(map);
#endif
}
Modified: trunk/Source/WebKit2/UIProcess/API/C/WKBatteryManager.cpp (159332 => 159333)
--- trunk/Source/WebKit2/UIProcess/API/C/WKBatteryManager.cpp 2013-11-15 11:03:03 UTC (rev 159332)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKBatteryManager.cpp 2013-11-15 13:09:28 UTC (rev 159333)
@@ -48,6 +48,9 @@
{
#if ENABLE(BATTERY_STATUS)
toImpl(batteryManager)->initializeProvider(provider);
+#else
+ UNUSED_PARAM(batteryManager);
+ UNUSED_PARAM(provider);
#endif
}
@@ -55,6 +58,10 @@
{
#if ENABLE(BATTERY_STATUS)
toImpl(batteryManager)->providerDidChangeBatteryStatus(AtomicString(toImpl(eventType)->string()), toImpl(status));
+#else
+ UNUSED_PARAM(batteryManager);
+ UNUSED_PARAM(eventType);
+ UNUSED_PARAM(status);
#endif
}
@@ -62,5 +69,8 @@
{
#if ENABLE(BATTERY_STATUS)
toImpl(batteryManager)->providerUpdateBatteryStatus(toImpl(status));
+#else
+ UNUSED_PARAM(batteryManager);
+ UNUSED_PARAM(status);
#endif
}
Modified: trunk/Source/WebKit2/UIProcess/API/C/WKBatteryStatus.cpp (159332 => 159333)
--- trunk/Source/WebKit2/UIProcess/API/C/WKBatteryStatus.cpp 2013-11-15 11:03:03 UTC (rev 159332)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKBatteryStatus.cpp 2013-11-15 13:09:28 UTC (rev 159333)
@@ -49,6 +49,10 @@
RefPtr<WebBatteryStatus> status = WebBatteryStatus::create(isCharging, chargingTime, dischargingTime, level);
return toAPI(status.release().leakRef());
#else
+ UNUSED_PARAM(isCharging);
+ UNUSED_PARAM(chargingTime);
+ UNUSED_PARAM(dischargingTime);
+ UNUSED_PARAM(level);
return 0;
#endif
}
Modified: trunk/Source/WebKit2/UIProcess/API/C/WKColorPickerResultListener.cpp (159332 => 159333)
--- trunk/Source/WebKit2/UIProcess/API/C/WKColorPickerResultListener.cpp 2013-11-15 11:03:03 UTC (rev 159332)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKColorPickerResultListener.cpp 2013-11-15 13:09:28 UTC (rev 159333)
@@ -44,5 +44,8 @@
{
#if ENABLE(INPUT_TYPE_COLOR)
toImpl(listenerRef)->setColor(toWTFString(color));
+#else
+ UNUSED_PARAM(listenerRef);
+ UNUSED_PARAM(color);
#endif
}
Modified: trunk/Source/WebKit2/UIProcess/API/C/WKContext.cpp (159332 => 159333)
--- trunk/Source/WebKit2/UIProcess/API/C/WKContext.cpp 2013-11-15 11:03:03 UTC (rev 159332)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKContext.cpp 2013-11-15 13:09:28 UTC (rev 159333)
@@ -214,6 +214,7 @@
#if ENABLE(BATTERY_STATUS)
return toAPI(toImpl(contextRef)->supplement<WebBatteryManagerProxy>());
#else
+ UNUSED_PARAM(contextRef);
return 0;
#endif
}
@@ -223,6 +224,7 @@
#if ENABLE(SQL_DATABASE)
return toAPI(toImpl(contextRef)->supplement<WebDatabaseManagerProxy>());
#else
+ UNUSED_PARAM(contextRef);
return 0;
#endif
}
@@ -237,6 +239,7 @@
#if ENABLE(NETWORK_INFO)
return toAPI(toImpl(contextRef)->supplement<WebNetworkInfoManagerProxy>());
#else
+ UNUSED_PARAM(contextRef);
return 0;
#endif
}
Modified: trunk/Source/WebKit2/UIProcess/API/C/WKDatabaseManager.cpp (159332 => 159333)
--- trunk/Source/WebKit2/UIProcess/API/C/WKDatabaseManager.cpp 2013-11-15 11:03:03 UTC (rev 159332)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKDatabaseManager.cpp 2013-11-15 13:09:28 UTC (rev 159333)
@@ -126,6 +126,9 @@
if (wkClient && wkClient->version)
return;
toImpl(databaseManagerRef)->initializeClient(wkClient);
+#else
+ UNUSED_PARAM(databaseManagerRef);
+ UNUSED_PARAM(wkClient);
#endif
}
@@ -133,6 +136,10 @@
{
#if ENABLE(SQL_DATABASE)
toImpl(databaseManagerRef)->getDatabasesByOrigin(ArrayCallback::create(context, callback));
+#else
+ UNUSED_PARAM(databaseManagerRef);
+ UNUSED_PARAM(context);
+ UNUSED_PARAM(callback);
#endif
}
@@ -140,6 +147,10 @@
{
#if ENABLE(SQL_DATABASE)
toImpl(databaseManagerRef)->getDatabaseOrigins(ArrayCallback::create(context, callback));
+#else
+ UNUSED_PARAM(databaseManagerRef);
+ UNUSED_PARAM(context);
+ UNUSED_PARAM(callback);
#endif
}
@@ -147,6 +158,10 @@
{
#if ENABLE(SQL_DATABASE)
toImpl(databaseManagerRef)->deleteDatabaseWithNameForOrigin(toWTFString(databaseNameRef), toImpl(originRef));
+#else
+ UNUSED_PARAM(databaseManagerRef);
+ UNUSED_PARAM(databaseNameRef);
+ UNUSED_PARAM(originRef);
#endif
}
@@ -154,6 +169,9 @@
{
#if ENABLE(SQL_DATABASE)
toImpl(databaseManagerRef)->deleteDatabasesForOrigin(toImpl(originRef));
+#else
+ UNUSED_PARAM(databaseManagerRef);
+ UNUSED_PARAM(originRef);
#endif
}
@@ -161,6 +179,8 @@
{
#if ENABLE(SQL_DATABASE)
toImpl(databaseManagerRef)->deleteAllDatabases();
+#else
+ UNUSED_PARAM(databaseManagerRef);
#endif
}
@@ -168,5 +188,9 @@
{
#if ENABLE(SQL_DATABASE)
toImpl(databaseManagerRef)->setQuotaForOrigin(toImpl(originRef), quota);
+#else
+ UNUSED_PARAM(databaseManagerRef);
+ UNUSED_PARAM(originRef);
+ UNUSED_PARAM(quota);
#endif
}
Modified: trunk/Source/WebKit2/UIProcess/API/C/WKNetworkInfo.cpp (159332 => 159333)
--- trunk/Source/WebKit2/UIProcess/API/C/WKNetworkInfo.cpp 2013-11-15 11:03:03 UTC (rev 159332)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKNetworkInfo.cpp 2013-11-15 13:09:28 UTC (rev 159333)
@@ -48,6 +48,8 @@
RefPtr<WebNetworkInfo> networkInfo = WebNetworkInfo::create(bandwidth, isMetered);
return toAPI(networkInfo.release().leakRef());
#else
+ UNUSED_PARAM(bandwidth);
+ UNUSED_PARAM(isMetered);
return 0;
#endif
}
Modified: trunk/Source/WebKit2/UIProcess/API/C/WKNetworkInfoManager.cpp (159332 => 159333)
--- trunk/Source/WebKit2/UIProcess/API/C/WKNetworkInfoManager.cpp 2013-11-15 11:03:03 UTC (rev 159332)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKNetworkInfoManager.cpp 2013-11-15 13:09:28 UTC (rev 159333)
@@ -44,6 +44,9 @@
{
#if ENABLE(NETWORK_INFO)
toImpl(networkInfoManager)->initializeProvider(provider);
+#else
+ UNUSED_PARAM(networkInfoManager);
+ UNUSED_PARAM(provider);
#endif
}
@@ -51,5 +54,9 @@
{
#if ENABLE(NETWORK_INFO)
toImpl(networkInfoManager)->providerDidChangeNetworkInformation(AtomicString(toImpl(eventType)->string()), toImpl(networkInfo));
+#else
+ UNUSED_PARAM(networkInfoManager);
+ UNUSED_PARAM(eventType);
+ UNUSED_PARAM(networkInfo);
#endif
}
Modified: trunk/Source/WebKit2/UIProcess/API/C/WKOpenPanelParameters.cpp (159332 => 159333)
--- trunk/Source/WebKit2/UIProcess/API/C/WKOpenPanelParameters.cpp 2013-11-15 11:03:03 UTC (rev 159332)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKOpenPanelParameters.cpp 2013-11-15 13:09:28 UTC (rev 159333)
@@ -53,6 +53,7 @@
#if ENABLE(MEDIA_CAPTURE)
return toCopiedAPI(toImpl(parametersRef)->capture());
#else
+ UNUSED_PARAM(parametersRef);
return 0;
#endif
}
Modified: trunk/Source/WebKit2/UIProcess/API/C/WKVibration.cpp (159332 => 159333)
--- trunk/Source/WebKit2/UIProcess/API/C/WKVibration.cpp 2013-11-15 11:03:03 UTC (rev 159332)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKVibration.cpp 2013-11-15 13:09:28 UTC (rev 159333)
@@ -47,5 +47,8 @@
{
#if ENABLE(VIBRATION)
toImpl(vibrationRef)->initializeProvider(wkProvider);
+#else
+ UNUSED_PARAM(vibrationRef);
+ UNUSED_PARAM(wkProvider);
#endif
}
Modified: trunk/Source/WebKit2/UIProcess/API/efl/EwkView.cpp (159332 => 159333)
--- trunk/Source/WebKit2/UIProcess/API/efl/EwkView.cpp 2013-11-15 11:03:03 UTC (rev 159332)
+++ trunk/Source/WebKit2/UIProcess/API/efl/EwkView.cpp 2013-11-15 13:09:28 UTC (rev 159333)
@@ -1075,7 +1075,7 @@
return m_windowFeatures.get();
}
-WKPageRef EwkView::createNewPage(PassRefPtr<EwkUrlRequest> request, WKDictionaryRef windowFeatures)
+WKPageRef EwkView::createNewPage(PassRefPtr<EwkUrlRequest>, WKDictionaryRef windowFeatures)
{
Ewk_View_Smart_Data* sd = smartData();
ASSERT(sd->api);
Modified: trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp (159332 => 159333)
--- trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp 2013-11-15 11:03:03 UTC (rev 159332)
+++ trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp 2013-11-15 13:09:28 UTC (rev 159333)
@@ -1741,6 +1741,9 @@
m_visibilityState = visibilityState;
m_process->send(Messages::WebPage::SetVisibilityState(visibilityState, isInitialState), m_pageID);
}
+#else
+ UNUSED_PARAM(visibilityState);
+ UNUSED_PARAM(isInitialState);
#endif
}
@@ -2643,6 +2646,8 @@
String newMimeType = mimeType;
PluginModuleInfo plugin = m_process->context()->pluginInfoStore().findPlugin(newMimeType, URL(URL(), pluginURLString));
pluginInformation = createPluginInformationDictionary(plugin, frameURLString, mimeType, pageURLString, pluginspageAttributeURLString, pluginURLString);
+#else
+ UNUSED_PARAM(mimeType);
#endif
WKPluginUnavailabilityReason pluginUnavailabilityReason = kWKPluginUnavailabilityReasonPluginMissing;
Modified: trunk/Source/WebKit2/UIProcess/efl/ViewClientEfl.cpp (159332 => 159333)
--- trunk/Source/WebKit2/UIProcess/efl/ViewClientEfl.cpp 2013-11-15 11:03:03 UTC (rev 159332)
+++ trunk/Source/WebKit2/UIProcess/efl/ViewClientEfl.cpp 2013-11-15 13:09:28 UTC (rev 159333)
@@ -104,6 +104,8 @@
if (WKPageUseFixedLayout(ewkView->wkPage())) {
#if USE(ACCELERATED_COMPOSITING)
ewkView->pageViewportController()->pageDidRequestScroll(toIntPoint(position));
+#else
+ UNUSED_PARAM(position);
#endif
return;
}
@@ -117,6 +119,9 @@
if (WKPageUseFixedLayout(ewkView->wkPage())) {
#if USE(ACCELERATED_COMPOSITING)
ewkView->pageViewportController()->didRenderFrame(toIntSize(contentsSize), toIntRect(coveredRect));
+#else
+ UNUSED_PARAM(contentsSize);
+ UNUSED_PARAM(coveredRect);
#endif
return;
}
@@ -144,6 +149,8 @@
#if USE(ACCELERATED_COMPOSITING)
// FIXME: pageViewportController should accept WKViewportAttributesRef.
ewkView->pageViewportController()->didChangeViewportAttributes(toImpl(attributes)->originalAttributes());
+#else
+ UNUSED_PARAM(attributes);
#endif
return;
}
Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp (159332 => 159333)
--- trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp 2013-11-15 11:03:03 UTC (rev 159332)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp 2013-11-15 13:09:28 UTC (rev 159333)
@@ -366,6 +366,8 @@
// Historically, we've used the following (somewhat non-sensical) string
// for the databaseIdentifier of local files.
WebProcess::shared().supplement<WebDatabaseManager>()->setQuotaForOrigin("file__0", quota);
+#else
+ UNUSED_PARAM(quota);
#endif
}
Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp (159332 => 159333)
--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp 2013-11-15 11:03:03 UTC (rev 159332)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp 2013-11-15 13:09:28 UTC (rev 159333)
@@ -193,6 +193,8 @@
#if ENABLE(FULLSCREEN_API)
if (frame->document() && frame->document()->webkitCurrentFullScreenElement())
frame->document()->webkitCancelFullScreen();
+#else
+ UNUSED_PARAM(frame);
#endif
uint64_t newPageID = 0;
