Title: [159364] trunk/Tools
- Revision
- 159364
- Author
- timothy_hor...@apple.com
- Date
- 2013-11-15 15:42:41 -0800 (Fri, 15 Nov 2013)
Log Message
Occasionally, hundreds of tests fail with small text diffs on Mavericks
https://bugs.webkit.org/show_bug.cgi?id=124312
Reviewed by Alexey Proskuryakov.
Try reverting the part of r158652 that deleted all of the persistent
defaults, in the thought that there might be some sort of race between
processes causing some settings to be left in the wrong state.
* DumpRenderTree/mac/DumpRenderTree.mm:
(setDefaultsToConsistentValuesForTesting):
* WebKitTestRunner/mac/main.mm:
(setDefaultsToConsistentValuesForTesting):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (159363 => 159364)
--- trunk/Tools/ChangeLog 2013-11-15 23:38:48 UTC (rev 159363)
+++ trunk/Tools/ChangeLog 2013-11-15 23:42:41 UTC (rev 159364)
@@ -1,3 +1,19 @@
+2013-11-15 Tim Horton <timothy_hor...@apple.com>
+
+ Occasionally, hundreds of tests fail with small text diffs on Mavericks
+ https://bugs.webkit.org/show_bug.cgi?id=124312
+
+ Reviewed by Alexey Proskuryakov.
+
+ Try reverting the part of r158652 that deleted all of the persistent
+ defaults, in the thought that there might be some sort of race between
+ processes causing some settings to be left in the wrong state.
+
+ * DumpRenderTree/mac/DumpRenderTree.mm:
+ (setDefaultsToConsistentValuesForTesting):
+ * WebKitTestRunner/mac/main.mm:
+ (setDefaultsToConsistentValuesForTesting):
+
2013-11-15 Dan Bernstein <m...@apple.com>
Give the policy client the originating frame of a navigation action
Modified: trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm (159363 => 159364)
--- trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm 2013-11-15 23:38:48 UTC (rev 159363)
+++ trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm 2013-11-15 23:42:41 UTC (rev 159364)
@@ -679,8 +679,6 @@
static const int NoFontSmoothing = 0;
static const int BlueTintedAppearance = 1;
- [[NSUserDefaults standardUserDefaults] removePersistentDomainForName:@"DumpRenderTree"];
-
NSString *libraryPath = libraryPathForDumpRenderTree();
NSDictionary *dict = @{
Modified: trunk/Tools/WebKitTestRunner/mac/main.mm (159363 => 159364)
--- trunk/Tools/WebKitTestRunner/mac/main.mm 2013-11-15 23:38:48 UTC (rev 159363)
+++ trunk/Tools/WebKitTestRunner/mac/main.mm 2013-11-15 23:42:41 UTC (rev 159364)
@@ -29,8 +29,6 @@
static void setDefaultsToConsistentValuesForTesting()
{
- [[NSUserDefaults standardUserDefaults] removePersistentDomainForName:@"WebKitTestRunner"];
-
NSDictionary *dict = @{
@"AppleKeyboardUIMode": @1,
@"AppleMagnifiedMode": @YES,
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
