Title: [159443] trunk/Source
- Revision
- 159443
- Author
- jer.no...@apple.com
- Date
- 2013-11-18 11:59:42 -0800 (Mon, 18 Nov 2013)
Log Message
[WTF] Media time should not have a constructor which accepts a single int or float.
https://bugs.webkit.org/show_bug.cgi?id=124470
Source/WebCore:
Reviewed by Eric Carlson.
Fix the compile error exposed by removing the default parameter in the MediaTime constructor.
* Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::setTimestampOffset):
Source/WTF:
Having a constructor taking a single number value, as it's very easy to accidentially mis-
initialize a MediaTime with a double (automatically casted to a int64_t).
Reviewed by Eric Carlson.
* wtf/MediaTime.h:
Modified Paths
Diff
Modified: trunk/Source/WTF/ChangeLog (159442 => 159443)
--- trunk/Source/WTF/ChangeLog 2013-11-18 19:53:06 UTC (rev 159442)
+++ trunk/Source/WTF/ChangeLog 2013-11-18 19:59:42 UTC (rev 159443)
@@ -1,3 +1,15 @@
+2013-11-17 Jer Noble <jer.no...@apple.com>
+
+ [WTF] Media time should not have a constructor which accepts a single int or float.
+ https://bugs.webkit.org/show_bug.cgi?id=124470
+
+ Having a constructor taking a single number value, as it's very easy to accidentially mis-
+ initialize a MediaTime with a double (automatically casted to a int64_t).
+
+ Reviewed by Eric Carlson.
+
+ * wtf/MediaTime.h:
+
2013-11-18 Csaba Osztrogonác <o...@webkit.org>
URTBF after r159432 to make WinCairo build happy.
Modified: trunk/Source/WTF/wtf/MediaTime.h (159442 => 159443)
--- trunk/Source/WTF/wtf/MediaTime.h 2013-11-18 19:53:06 UTC (rev 159442)
+++ trunk/Source/WTF/wtf/MediaTime.h 2013-11-18 19:59:42 UTC (rev 159443)
@@ -50,7 +50,7 @@
};
MediaTime();
- MediaTime(int64_t value, int32_t scale = DefaultTimeScale, uint32_t flags = Valid);
+ MediaTime(int64_t value, int32_t scale, uint32_t flags = Valid);
MediaTime(const MediaTime& rhs);
~MediaTime();
Modified: trunk/Source/WebCore/ChangeLog (159442 => 159443)
--- trunk/Source/WebCore/ChangeLog 2013-11-18 19:53:06 UTC (rev 159442)
+++ trunk/Source/WebCore/ChangeLog 2013-11-18 19:59:42 UTC (rev 159443)
@@ -1,3 +1,15 @@
+2013-11-17 Jer Noble <jer.no...@apple.com>
+
+ [WTF] Media time should not have a constructor which accepts a single int or float.
+ https://bugs.webkit.org/show_bug.cgi?id=124470
+
+ Reviewed by Eric Carlson.
+
+ Fix the compile error exposed by removing the default parameter in the MediaTime constructor.
+
+ * Modules/mediasource/SourceBuffer.cpp:
+ (WebCore::SourceBuffer::setTimestampOffset):
+
2013-11-18 Nick Diego Yamane <nick.yam...@openbossa.org>
Change webaudio to use nullptr for null pointers
Modified: trunk/Source/WebCore/Modules/mediasource/SourceBuffer.cpp (159442 => 159443)
--- trunk/Source/WebCore/Modules/mediasource/SourceBuffer.cpp 2013-11-18 19:53:06 UTC (rev 159442)
+++ trunk/Source/WebCore/Modules/mediasource/SourceBuffer.cpp 2013-11-18 19:59:42 UTC (rev 159443)
@@ -160,7 +160,7 @@
}
// 6. Update the attribute to the new value.
- m_timestampOffset = offset;
+ m_timestampOffset = MediaTime::createWithDouble(offset);
}
void SourceBuffer::appendBuffer(PassRefPtr<ArrayBuffer> data, ExceptionCode& ec)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
