Title: [159612] trunk/Tools
- Revision
- 159612
- Author
- [email protected]
- Date
- 2013-11-20 23:46:13 -0800 (Wed, 20 Nov 2013)
Log Message
check-webkit-style should support C++11 rvalue references.
https://bugs.webkit.org/show_bug.cgi?id=123406
Patch by László Langó <[email protected]> on 2013-11-20
Reviewed by Brent Fulgham.
* Scripts/webkitpy/style/checkers/cpp.py:
(check_style):
* Scripts/webkitpy/style/checkers/cpp_unittest.py:
(Cpp11StyleTest):
(Cpp11StyleTest.test_rvaule_reference_at_end_of_line):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (159611 => 159612)
--- trunk/Tools/ChangeLog 2013-11-21 07:04:12 UTC (rev 159611)
+++ trunk/Tools/ChangeLog 2013-11-21 07:46:13 UTC (rev 159612)
@@ -1,3 +1,16 @@
+2013-11-20 László Langó <[email protected]>
+
+ check-webkit-style should support C++11 rvalue references.
+ https://bugs.webkit.org/show_bug.cgi?id=123406
+
+ Reviewed by Brent Fulgham.
+
+ * Scripts/webkitpy/style/checkers/cpp.py:
+ (check_style):
+ * Scripts/webkitpy/style/checkers/cpp_unittest.py:
+ (Cpp11StyleTest):
+ (Cpp11StyleTest.test_rvaule_reference_at_end_of_line):
+
2013-11-20 Dean Jackson <[email protected]>
Allow settings to be shown/hidden on build.webkit.org/dashboard
Modified: trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py (159611 => 159612)
--- trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py 2013-11-21 07:04:12 UTC (rev 159611)
+++ trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py 2013-11-21 07:46:13 UTC (rev 159612)
@@ -2623,7 +2623,7 @@
error(line_number, 'whitespace/newline', 4,
'More than one command on the same line')
- if cleansed_line.strip().endswith('||') or cleansed_line.strip().endswith('&&'):
+ if cleansed_line.strip().endswith('||') or cleansed_line.strip().endswith(' &&'):
error(line_number, 'whitespace/operators', 4,
'Boolean expressions that span multiple lines should have their '
'operators on the left side of the line instead of the right side.')
Modified: trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py (159611 => 159612)
--- trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py 2013-11-21 07:04:12 UTC (rev 159611)
+++ trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py 2013-11-21 07:46:13 UTC (rev 159612)
@@ -624,6 +624,11 @@
detection_line=2)
+class Cpp11StyleTest(CppStyleTestBase):
+ def test_rvaule_reference_at_end_of_line(self):
+ self.assert_lint('T&&', '')
+
+
class CppStyleTest(CppStyleTestBase):
def test_asm_lines_ignored(self):
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
