Title: [159616] trunk/Tools
- Revision
- 159616
- Author
- [email protected]
- Date
- 2013-11-21 04:26:06 -0800 (Thu, 21 Nov 2013)
Log Message
REGRESSION(r159599): webkitdirs.pm spits out warnings at lines 851 and 852
https://bugs.webkit.org/show_bug.cgi?id=124697
Reviewed by Ryosuke Niwa.
* Scripts/webkitdirs.pm:
(checkForArgumentAndRemoveFromARGVGettingValue): Fix check of array size
before trying to access to the first element.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (159615 => 159616)
--- trunk/Tools/ChangeLog 2013-11-21 08:52:32 UTC (rev 159615)
+++ trunk/Tools/ChangeLog 2013-11-21 12:26:06 UTC (rev 159616)
@@ -1,3 +1,14 @@
+2013-11-21 Manuel Rego Casasnovas <[email protected]>
+
+ REGRESSION(r159599): webkitdirs.pm spits out warnings at lines 851 and 852
+ https://bugs.webkit.org/show_bug.cgi?id=124697
+
+ Reviewed by Ryosuke Niwa.
+
+ * Scripts/webkitdirs.pm:
+ (checkForArgumentAndRemoveFromARGVGettingValue): Fix check of array size
+ before trying to access to the first element.
+
2013-11-21 Carlos Garcia Campos <[email protected]>
[GTK] Mark all deprecated symbols in GObject DOM bindings
Modified: trunk/Tools/Scripts/webkitdirs.pm (159615 => 159616)
--- trunk/Tools/Scripts/webkitdirs.pm 2013-11-21 08:52:32 UTC (rev 159615)
+++ trunk/Tools/Scripts/webkitdirs.pm 2013-11-21 12:26:06 UTC (rev 159616)
@@ -847,7 +847,7 @@
{
my ($argToCheck, $valueRef) = @_;
my @matchingIndices = findMatchingArguments($argToCheck, \@ARGV);
- return 0 unless ($#matchingIndices != 1);
+ return 0 if ($#matchingIndices != 1);
splice(@ARGV, $matchingIndices[0], 1);
return $$valueRef = splice(@ARGV, $matchingIndices[0], 1);
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
