Title: [160051] trunk/Tools
Revision
160051
Author
[email protected]
Date
2013-12-03 15:26:46 -0800 (Tue, 03 Dec 2013)

Log Message

REGRESSION: repro scripts disappear when you rerun tests
https://bugs.webkit.org/show_bug.cgi?id=125184

Reviewed by Mark Hahnenberg.
        
This bug made it difficult to quickly see if a test that recently failed is still
failing while also running a new batch of tests.

Repro scripts are supposed to stay around until you delete them explicitly. This
patch accomplishes that.

* Scripts/run-jsc-stress-tests:

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (160050 => 160051)


--- trunk/Tools/ChangeLog	2013-12-03 23:25:19 UTC (rev 160050)
+++ trunk/Tools/ChangeLog	2013-12-03 23:26:46 UTC (rev 160051)
@@ -1,3 +1,18 @@
+2013-12-03  Filip Pizlo  <[email protected]>
+
+        REGRESSION: repro scripts disappear when you rerun tests
+        https://bugs.webkit.org/show_bug.cgi?id=125184
+
+        Reviewed by Mark Hahnenberg.
+        
+        This bug made it difficult to quickly see if a test that recently failed is still
+        failing while also running a new batch of tests.
+
+        Repro scripts are supposed to stay around until you delete them explicitly. This
+        patch accomplishes that.
+
+        * Scripts/run-jsc-stress-tests:
+
 2013-12-03  [email protected]  <[email protected]>
 
         [Win] run-jsc-stress-tests has a great number of failures (2026/7606) on Windows

Modified: trunk/Tools/Scripts/run-jsc-stress-tests (160050 => 160051)


--- trunk/Tools/Scripts/run-jsc-stress-tests	2013-12-03 23:25:19 UTC (rev 160050)
+++ trunk/Tools/Scripts/run-jsc-stress-tests	2013-12-03 23:26:46 UTC (rev 160051)
@@ -907,7 +907,7 @@
 
 def eachResultFile(startingDir, &block)
     dirsToClean = [startingDir]
-    until dirsToClean.empty? do
+    until dirsToClean.empty?
         nextDir = dirsToClean.pop
         Dir.foreach(nextDir) {
             | entry |
@@ -1139,20 +1139,24 @@
     raise unless system(cmd)
 end
 
-FileUtils.rm_rf $outputDir if $outputDir.directory? and not $bundle
+def clean(file)
+    FileUtils.rm_rf file unless $bundle
+end
+
+clean($outputDir + "failed")
+clean($outputDir + ".vm")
+clean($outputDir + ".runner")
+clean($outputDir + ".tests")
+clean($outputDir + "_payload")
+
 Dir.mkdir($outputDir) unless $outputDir.directory?
 
-begin
-    File.delete($outputDir + "failed")
-rescue
-end
-
 $outputDir = $outputDir.realpath
 $runnerDir = $outputDir + ".runner"
 
 prepareBundle unless $bundle
 
-puts " "
+puts
 
 prepareTestRunner unless $bundle
 cleanRunnerDirectory if $bundle
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to