Title: [160100] trunk/Source/_javascript_Core
Revision
160100
Author
commit-qu...@webkit.org
Date
2013-12-04 10:30:49 -0800 (Wed, 04 Dec 2013)

Log Message

REGRESSION (r160094): Fix lots of crashes for sh4 architecture.
https://bugs.webkit.org/show_bug.cgi?id=125227

Patch by Julien Brianceau <jbria...@cisco.com> on 2013-12-04
Reviewed by Michael Saboff.

* llint/LowLevelInterpreter32_64.asm: Do not use t4 and t5 as they match a0 and a1.
* offlineasm/registers.rb: Add t7, t8 and t9 in register list for sh4 port.
* offlineasm/sh4.rb: Rearrange RegisterID list and add the missing ones.

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (160099 => 160100)


--- trunk/Source/_javascript_Core/ChangeLog	2013-12-04 18:20:37 UTC (rev 160099)
+++ trunk/Source/_javascript_Core/ChangeLog	2013-12-04 18:30:49 UTC (rev 160100)
@@ -1,3 +1,14 @@
+2013-12-04  Julien Brianceau  <jbria...@cisco.com>
+
+        REGRESSION (r160094): Fix lots of crashes for sh4 architecture.
+        https://bugs.webkit.org/show_bug.cgi?id=125227
+
+        Reviewed by Michael Saboff.
+
+        * llint/LowLevelInterpreter32_64.asm: Do not use t4 and t5 as they match a0 and a1.
+        * offlineasm/registers.rb: Add t7, t8 and t9 in register list for sh4 port.
+        * offlineasm/sh4.rb: Rearrange RegisterID list and add the missing ones.
+
 2013-12-03  Joseph Pecoraro  <pecor...@apple.com>
 
         Web Inspector: Push Remote Inspector debugging connection management into _javascript_Core

Modified: trunk/Source/_javascript_Core/llint/LowLevelInterpreter32_64.asm (160099 => 160100)


--- trunk/Source/_javascript_Core/llint/LowLevelInterpreter32_64.asm	2013-12-04 18:20:37 UTC (rev 160099)
+++ trunk/Source/_javascript_Core/llint/LowLevelInterpreter32_64.asm	2013-12-04 18:30:49 UTC (rev 160100)
@@ -233,8 +233,8 @@
         const previousPC = lr
         const temp1 = t3 # Same as previousCFR
         const temp2 = a3 # Same as topOfStack
-        const temp3 = t4
-        const temp4 = t5
+        const temp3 = t8
+        const temp4 = t9
     end
 
     if X86

Modified: trunk/Source/_javascript_Core/offlineasm/registers.rb (160099 => 160100)


--- trunk/Source/_javascript_Core/offlineasm/registers.rb	2013-12-04 18:20:37 UTC (rev 160099)
+++ trunk/Source/_javascript_Core/offlineasm/registers.rb	2013-12-04 18:30:49 UTC (rev 160100)
@@ -31,6 +31,10 @@
      "t3",
      "t4",
      "t5",
+     "t6",
+     "t7",
+     "t8",
+     "t9",
      "cfr",
      "a0",
      "a1",
@@ -42,7 +46,6 @@
      "lr",
      
      # 64-bit only registers:
-     "t6",
      "csr1",  # tag type number register
      "csr2"   # tag mask register
     ]

Modified: trunk/Source/_javascript_Core/offlineasm/sh4.rb (160099 => 160100)


--- trunk/Source/_javascript_Core/offlineasm/sh4.rb	2013-12-04 18:20:37 UTC (rev 160099)
+++ trunk/Source/_javascript_Core/offlineasm/sh4.rb	2013-12-04 18:30:49 UTC (rev 160100)
@@ -57,14 +57,6 @@
 class RegisterID
     def sh4Operand
         case name
-        when "a0"
-            "r4"
-        when "a1"
-            "r5"
-        when "a2"
-            "r6"
-        when "a3"
-            "r7"
         when "t0"
             "r0"
         when "t1"
@@ -73,10 +65,18 @@
             "r2"
         when "t3"
             "r10"
-        when "t4"
+        when "t4", "a0"
             "r4"
-        when "t5"
+        when "t5", "a1"
             "r5"
+        when "t6", "a2"
+            "r6"
+        when "t7", "a3"
+            "r7"
+        when "t8"
+            "r8"
+        when "t9"
+            "r9"
         when "cfr"
             "r14"
         when "sp"
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to