Title: [160380] trunk
Revision
160380
Author
mario.pr...@samsung.com
Date
2013-12-10 12:12:56 -0800 (Tue, 10 Dec 2013)

Log Message

[ATK] Expose splitter elements with ATK_ROLE_SEPARATOR
https://bugs.webkit.org/show_bug.cgi?id=125522

Reviewed by Chris Fleizach.

Source/WebCore:

Expose objects with SplitterRole role as ATK_ROLE_SEPARATOR.

* accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(atkRole):

Tools:

Update strings representing ATK_ROLE_SEPARATOR for layout tests.

* DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
* WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

LayoutTests:

Update expected results in layout test for EFL and GTK.

* platform/efl-wk1/accessibility/lists-expected.txt:
* platform/efl-wk2/accessibility/lists-expected.txt:
* platform/gtk/accessibility/lists-expected.txt:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (160379 => 160380)


--- trunk/LayoutTests/ChangeLog	2013-12-10 20:11:18 UTC (rev 160379)
+++ trunk/LayoutTests/ChangeLog	2013-12-10 20:12:56 UTC (rev 160380)
@@ -1,5 +1,18 @@
 2013-12-10  Mario Sanchez Prada  <mario.pr...@samsung.com>
 
+        [ATK] Expose splitter elements with ATK_ROLE_SEPARATOR
+        https://bugs.webkit.org/show_bug.cgi?id=125522
+
+        Reviewed by Chris Fleizach.
+
+        Update expected results in layout test for EFL and GTK.
+
+        * platform/efl-wk1/accessibility/lists-expected.txt:
+        * platform/efl-wk2/accessibility/lists-expected.txt:
+        * platform/gtk/accessibility/lists-expected.txt:
+
+2013-12-10  Mario Sanchez Prada  <mario.pr...@samsung.com>
+
         [ATK] Elements with role 'alertdialog' should be ATK_ROLE_ALERT
         https://bugs.webkit.org/show_bug.cgi?id=125521
 

Modified: trunk/LayoutTests/platform/efl-wk1/accessibility/lists-expected.txt (160379 => 160380)


--- trunk/LayoutTests/platform/efl-wk1/accessibility/lists-expected.txt	2013-12-10 20:11:18 UTC (rev 160379)
+++ trunk/LayoutTests/platform/efl-wk1/accessibility/lists-expected.txt	2013-12-10 20:12:56 UTC (rev 160380)
@@ -84,7 +84,7 @@
 AXChecked: 0
 AXPlatformAttributes: toolkit:WebKitEfl
 ------------
-AXRole: AXHorizontalRule
+AXRole: AXSeparator
 AXParent: AXWebArea
 AXChildren: 0
 AXPosition: { 8.000000, 288.000000 }

Modified: trunk/LayoutTests/platform/efl-wk2/accessibility/lists-expected.txt (160379 => 160380)


--- trunk/LayoutTests/platform/efl-wk2/accessibility/lists-expected.txt	2013-12-10 20:11:18 UTC (rev 160379)
+++ trunk/LayoutTests/platform/efl-wk2/accessibility/lists-expected.txt	2013-12-10 20:12:56 UTC (rev 160380)
@@ -84,7 +84,7 @@
 AXChecked: 0
 AXPlatformAttributes: toolkit:WebKitEfl
 ------------
-AXRole: AXHorizontalRule
+AXRole: AXSeparator
 AXParent: AXWebArea
 AXChildren: 0
 AXPosition: { 0.000000, 0.000000 }

Modified: trunk/LayoutTests/platform/gtk/accessibility/lists-expected.txt (160379 => 160380)


--- trunk/LayoutTests/platform/gtk/accessibility/lists-expected.txt	2013-12-10 20:11:18 UTC (rev 160379)
+++ trunk/LayoutTests/platform/gtk/accessibility/lists-expected.txt	2013-12-10 20:12:56 UTC (rev 160380)
@@ -84,7 +84,7 @@
 AXChecked: 0
 AXPlatformAttributes: toolkit:WebKitGtk
 ------------
-AXRole: AXHorizontalRule
+AXRole: AXSeparator
 AXParent: AXWebArea
 AXChildren: 0
 AXPosition: { 8.000000, 276.000000 }

Modified: trunk/Source/WebCore/ChangeLog (160379 => 160380)


--- trunk/Source/WebCore/ChangeLog	2013-12-10 20:11:18 UTC (rev 160379)
+++ trunk/Source/WebCore/ChangeLog	2013-12-10 20:12:56 UTC (rev 160380)
@@ -1,5 +1,17 @@
 2013-12-10  Mario Sanchez Prada  <mario.pr...@samsung.com>
 
+        [ATK] Expose splitter elements with ATK_ROLE_SEPARATOR
+        https://bugs.webkit.org/show_bug.cgi?id=125522
+
+        Reviewed by Chris Fleizach.
+
+        Expose objects with SplitterRole role as ATK_ROLE_SEPARATOR.
+
+        * accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
+        (atkRole):
+
+2013-12-10  Mario Sanchez Prada  <mario.pr...@samsung.com>
+
         [ATK] Elements with role 'alertdialog' should be ATK_ROLE_ALERT
         https://bugs.webkit.org/show_bug.cgi?id=125521
 

Modified: trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp (160379 => 160380)


--- trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp	2013-12-10 20:11:18 UTC (rev 160379)
+++ trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp	2013-12-10 20:12:56 UTC (rev 160380)
@@ -600,7 +600,7 @@
     case SplitGroupRole:
         return ATK_ROLE_SPLIT_PANE;
     case SplitterRole:
-        return ATK_ROLE_UNKNOWN;
+        return ATK_ROLE_SEPARATOR;
     case ColorWellRole:
         return ATK_ROLE_COLOR_CHOOSER;
     case ListRole:

Modified: trunk/Tools/ChangeLog (160379 => 160380)


--- trunk/Tools/ChangeLog	2013-12-10 20:11:18 UTC (rev 160379)
+++ trunk/Tools/ChangeLog	2013-12-10 20:12:56 UTC (rev 160380)
@@ -1,3 +1,15 @@
+2013-12-10  Mario Sanchez Prada  <mario.pr...@samsung.com>
+
+        [ATK] Expose splitter elements with ATK_ROLE_SEPARATOR
+        https://bugs.webkit.org/show_bug.cgi?id=125522
+
+        Reviewed by Chris Fleizach.
+
+        Update strings representing ATK_ROLE_SEPARATOR for layout tests.
+
+        * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
+        * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
+
 2013-12-10  Laszlo Vidacs  <l...@inf.u-szeged.hu>
 
         Add --makeargs option to build-jsc

Modified: trunk/Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp (160379 => 160380)


--- trunk/Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp	2013-12-10 20:11:18 UTC (rev 160379)
+++ trunk/Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp	2013-12-10 20:12:56 UTC (rev 160380)
@@ -260,7 +260,7 @@
     case ATK_ROLE_SECTION:
         return "AXSection";
     case ATK_ROLE_SEPARATOR:
-        return "AXHorizontalRule";
+        return "AXSeparator";
     case ATK_ROLE_SLIDER:
         return "AXSlider";
     case ATK_ROLE_SPIN_BUTTON:

Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp (160379 => 160380)


--- trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp	2013-12-10 20:11:18 UTC (rev 160379)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp	2013-12-10 20:12:56 UTC (rev 160380)
@@ -349,7 +349,7 @@
     case ATK_ROLE_SECTION:
         return "AXSection";
     case ATK_ROLE_SEPARATOR:
-        return "AXHorizontalRule";
+        return "AXSeparator";
     case ATK_ROLE_SLIDER:
         return "AXSlider";
     case ATK_ROLE_SPIN_BUTTON:
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to