[webkit-changes] [160910] trunk/Source/WebCore

Fri, 20 Dec 2013 07:33:52 -0800

Title: [160910] trunk/Source/WebCore
Revision
160910
Author
zandober...@gmail.com
Date
2013-12-20 07:36:56 -0800 (Fri, 20 Dec 2013)

Log Message

Unreviewed GTK build fix after r160909.
Remove remaining uses of AttachLazily in code specific to the GTK port.

* html/shadow/MediaControlsGtk.cpp:
(WebCore::MediaControlsGtk::initializeControls):
(WebCore::MediaControlsGtk::createTextTrackDisplay):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (160909 => 160910)


--- trunk/Source/WebCore/ChangeLog	2013-12-20 14:58:40 UTC (rev 160909)
+++ trunk/Source/WebCore/ChangeLog	2013-12-20 15:36:56 UTC (rev 160910)
@@ -1,3 +1,12 @@
+2013-12-20  Zan Dobersek  <zdober...@igalia.com>
+
+        Unreviewed GTK build fix after r160909.
+        Remove remaining uses of AttachLazily in code specific to the GTK port.
+
+        * html/shadow/MediaControlsGtk.cpp:
+        (WebCore::MediaControlsGtk::initializeControls):
+        (WebCore::MediaControlsGtk::createTextTrackDisplay):
+
 2013-12-19  Antti Koivisto  <an...@apple.com>
 
         Create render tree lazily

Modified: trunk/Source/WebCore/html/shadow/MediaControlsGtk.cpp (160909 => 160910)


--- trunk/Source/WebCore/html/shadow/MediaControlsGtk.cpp	2013-12-20 14:58:40 UTC (rev 160909)
+++ trunk/Source/WebCore/html/shadow/MediaControlsGtk.cpp	2013-12-20 15:36:56 UTC (rev 160910)
@@ -94,26 +94,26 @@
 
     RefPtr<MediaControlPlayButtonElement> playButton = MediaControlPlayButtonElement::create(document);
     m_playButton = playButton.get();
-    panel->appendChild(playButton.release(), exceptionCode, AttachLazily);
+    panel->appendChild(playButton.release(), exceptionCode);
     if (exceptionCode)
         return false;
 
     RefPtr<MediaControlTimelineElement> timeline = MediaControlTimelineElement::create(document, this);
     m_timeline = timeline.get();
-    panel->appendChild(timeline.release(), exceptionCode, AttachLazily);
+    panel->appendChild(timeline.release(), exceptionCode);
     if (exceptionCode)
         return false;
 
     RefPtr<MediaControlCurrentTimeDisplayElement> currentTimeDisplay = MediaControlCurrentTimeDisplayElement::create(document);
     m_currentTimeDisplay = currentTimeDisplay.get();
     m_currentTimeDisplay->hide();
-    panel->appendChild(currentTimeDisplay.release(), exceptionCode, AttachLazily);
+    panel->appendChild(currentTimeDisplay.release(), exceptionCode);
     if (exceptionCode)
         return false;
 
     RefPtr<MediaControlTimeRemainingDisplayElement> durationDisplay = MediaControlTimeRemainingDisplayElement::create(document);
     m_durationDisplay = durationDisplay.get();
-    panel->appendChild(durationDisplay.release(), exceptionCode, AttachLazily);
+    panel->appendChild(durationDisplay.release(), exceptionCode);
     if (exceptionCode)
         return false;
 
@@ -122,54 +122,54 @@
 
         RefPtr<MediaControlClosedCaptionsTrackListElement> closedCaptionsTrackList = MediaControlClosedCaptionsTrackListElement::create(document, this);
         m_closedCaptionsTrackList = closedCaptionsTrackList.get();
-        closedCaptionsContainer->appendChild(closedCaptionsTrackList.release(), exceptionCode, AttachLazily);
+        closedCaptionsContainer->appendChild(closedCaptionsTrackList.release(), exceptionCode);
         if (exceptionCode)
             return false;
 
         RefPtr<MediaControlToggleClosedCaptionsButtonElement> toggleClosedCaptionsButton = MediaControlToggleClosedCaptionsButtonElement::create(document, this);
         m_toggleClosedCaptionsButton = toggleClosedCaptionsButton.get();
-        panel->appendChild(toggleClosedCaptionsButton.release(), exceptionCode, AttachLazily);
+        panel->appendChild(toggleClosedCaptionsButton.release(), exceptionCode);
         if (exceptionCode)
             return false;
 
         m_closedCaptionsContainer = closedCaptionsContainer.get();
-        appendChild(closedCaptionsContainer.release(), exceptionCode, AttachLazily);
+        appendChild(closedCaptionsContainer.release(), exceptionCode);
         if (exceptionCode)
             return false;
     }
 
     RefPtr<MediaControlFullscreenButtonElement> fullscreenButton = MediaControlFullscreenButtonElement::create(document);
     m_fullScreenButton = fullscreenButton.get();
-    panel->appendChild(fullscreenButton.release(), exceptionCode, AttachLazily);
+    panel->appendChild(fullscreenButton.release(), exceptionCode);
     if (exceptionCode)
         return false;
 
     RefPtr<MediaControlPanelMuteButtonElement> panelMuteButton = MediaControlPanelMuteButtonElement::create(document, this);
     m_panelMuteButton = panelMuteButton.get();
-    panel->appendChild(panelMuteButton.release(), exceptionCode, AttachLazily);
+    panel->appendChild(panelMuteButton.release(), exceptionCode);
     if (exceptionCode)
         return false;
 
     RefPtr<MediaControlVolumeSliderContainerElement> sliderContainer = MediaControlVolumeSliderContainerElement::create(document);
     m_volumeSliderContainer = sliderContainer.get();
-    panel->appendChild(sliderContainer.release(), exceptionCode, AttachLazily);
+    panel->appendChild(sliderContainer.release(), exceptionCode);
     if (exceptionCode)
         return false;
 
     RefPtr<MediaControlPanelVolumeSliderElement> slider = MediaControlPanelVolumeSliderElement::create(document);
     m_volumeSlider = slider.get();
     m_volumeSlider->setClearMutedOnUserInteraction(true);
-    m_volumeSliderContainer->appendChild(slider.release(), exceptionCode, AttachLazily);
+    m_volumeSliderContainer->appendChild(slider.release(), exceptionCode);
     if (exceptionCode)
         return false;
 
     m_panel = panel.get();
-    enclosure->appendChild(panel.release(), exceptionCode, AttachLazily);
+    enclosure->appendChild(panel.release(), exceptionCode);
     if (exceptionCode)
         return false;
 
     m_enclosure = enclosure.get();
-    appendChild(enclosure.release(), exceptionCode, AttachLazily);
+    appendChild(enclosure.release(), exceptionCode);
     if (exceptionCode)
         return false;
 
@@ -285,7 +285,7 @@
         m_textDisplayContainer->setMediaController(m_mediaController);
 
     // Insert it before the first controller element so it always displays behind the controls.
-    insertBefore(textDisplayContainer.release(), m_enclosure, ASSERT_NO_EXCEPTION, AttachLazily);
+    insertBefore(textDisplayContainer.release(), m_enclosure, ASSERT_NO_EXCEPTION);
 }
 #endif
 

_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to