Title: [161203] trunk/Source
- Revision
- 161203
- Author
- [email protected]
- Date
- 2014-01-01 19:22:05 -0800 (Wed, 01 Jan 2014)
Log Message
Remove ChromeClient::fullScreenRendererChanged().
<https://webkit.org/b/126370>
This hook was added in r75277 to notify WebFullScreenController when
the full screen renderer changed. In r110216 the code was refactored,
making this notification unnecessary.
Reviewed by Antti Koivisto.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (161202 => 161203)
--- trunk/Source/WebCore/ChangeLog 2014-01-02 02:07:10 UTC (rev 161202)
+++ trunk/Source/WebCore/ChangeLog 2014-01-02 03:22:05 UTC (rev 161203)
@@ -1,3 +1,14 @@
+2014-01-01 Andreas Kling <[email protected]>
+
+ Remove ChromeClient::fullScreenRendererChanged().
+ <https://webkit.org/b/126370>
+
+ This hook was added in r75277 to notify WebFullScreenController when
+ the full screen renderer changed. In r110216 the code was refactored,
+ making this notification unnecessary.
+
+ Reviewed by Antti Koivisto.
+
2014-01-01 Simon Fraser <[email protected]>
Fix the build by exposing some more scrolling state node headers
Modified: trunk/Source/WebCore/dom/Document.cpp (161202 => 161203)
--- trunk/Source/WebCore/dom/Document.cpp 2014-01-02 02:07:10 UTC (rev 161202)
+++ trunk/Source/WebCore/dom/Document.cpp 2014-01-02 03:22:05 UTC (rev 161203)
@@ -5465,18 +5465,11 @@
ASSERT(!m_fullScreenRenderer);
m_fullScreenRenderer = renderer;
-
- // This notification can come in after the page has been destroyed.
- if (page())
- page()->chrome().client().fullScreenRendererChanged(m_fullScreenRenderer);
}
void Document::fullScreenRendererDestroyed()
{
m_fullScreenRenderer = nullptr;
-
- if (page())
- page()->chrome().client().fullScreenRendererChanged(nullptr);
}
void Document::fullScreenChangeDelayTimerFired(Timer<Document>*)
Modified: trunk/Source/WebCore/page/ChromeClient.h (161202 => 161203)
--- trunk/Source/WebCore/page/ChromeClient.h 2014-01-02 02:07:10 UTC (rev 161202)
+++ trunk/Source/WebCore/page/ChromeClient.h 2014-01-02 03:22:05 UTC (rev 161203)
@@ -335,7 +335,6 @@
virtual bool supportsFullScreenForElement(const Element*, bool) { return false; }
virtual void enterFullScreenForElement(Element*) { }
virtual void exitFullScreenForElement(Element*) { }
- virtual void fullScreenRendererChanged(RenderBox*) { }
virtual void setRootFullScreenLayer(GraphicsLayer*) { }
#endif
Modified: trunk/Source/WebKit/mac/WebCoreSupport/WebChromeClient.h (161202 => 161203)
--- trunk/Source/WebKit/mac/WebCoreSupport/WebChromeClient.h 2014-01-02 02:07:10 UTC (rev 161202)
+++ trunk/Source/WebKit/mac/WebCoreSupport/WebChromeClient.h 2014-01-02 03:22:05 UTC (rev 161203)
@@ -191,7 +191,6 @@
virtual bool supportsFullScreenForElement(const WebCore::Element*, bool withKeyboard) OVERRIDE;
virtual void enterFullScreenForElement(WebCore::Element*) OVERRIDE;
virtual void exitFullScreenForElement(WebCore::Element*) OVERRIDE;
- virtual void fullScreenRendererChanged(WebCore::RenderBox*) OVERRIDE;
#endif
virtual bool selectItemWritingDirectionIsNatural() OVERRIDE;
Modified: trunk/Source/WebKit/mac/WebCoreSupport/WebChromeClient.mm (161202 => 161203)
--- trunk/Source/WebKit/mac/WebCoreSupport/WebChromeClient.mm 2014-01-02 02:07:10 UTC (rev 161202)
+++ trunk/Source/WebKit/mac/WebCoreSupport/WebChromeClient.mm 2014-01-02 03:22:05 UTC (rev 161203)
@@ -1032,11 +1032,4 @@
#endif
}
-void WebChromeClient::fullScreenRendererChanged(RenderBox* renderer)
-{
- SEL selector = @selector(webView:fullScreenRendererChanged:);
- if ([[m_webView UIDelegate] respondsToSelector:selector])
- CallUIDelegate(m_webView, selector, (id)renderer);
-}
-
#endif
Modified: trunk/Source/WebKit/mac/WebView/WebViewInternal.h (161202 => 161203)
--- trunk/Source/WebKit/mac/WebView/WebViewInternal.h 2014-01-02 02:07:10 UTC (rev 161202)
+++ trunk/Source/WebKit/mac/WebView/WebViewInternal.h 2014-01-02 03:22:05 UTC (rev 161203)
@@ -245,7 +245,6 @@
- (BOOL)_supportsFullScreenForElement:(WebCore::Element*)element withKeyboard:(BOOL)withKeyboard;
- (void)_enterFullScreenForElement:(WebCore::Element*)element;
- (void)_exitFullScreenForElement:(WebCore::Element*)element;
-- (void)_fullScreenRendererChanged:(WebCore::RenderBox*)renderer;
#endif
// Conversion functions between WebCore root view coordinates and web view coordinates.
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
