Title: [161304] trunk/Source/_javascript_Core
- Revision
- 161304
- Author
- [email protected]
- Date
- 2014-01-03 18:18:26 -0800 (Fri, 03 Jan 2014)
Log Message
[super dealloc] missing in Source/_javascript_Core/API/tests/testapi.mm, fails to build with -Werror,-Wobjc-missing-super-calls
https://bugs.webkit.org/show_bug.cgi?id=126454
Reviewed by Geoffrey Garen.
* API/tests/testapi.mm:
(-[TextXYZ dealloc]):
add [super dealloc]
(-[EvilAllocationObject dealloc]):
add [super dealloc]
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/API/tests/testapi.mm (161303 => 161304)
--- trunk/Source/_javascript_Core/API/tests/testapi.mm 2014-01-04 02:04:34 UTC (rev 161303)
+++ trunk/Source/_javascript_Core/API/tests/testapi.mm 2014-01-04 02:18:26 UTC (rev 161304)
@@ -169,6 +169,9 @@
- (void)dealloc
{
[[m_onclickHandler value].context.virtualMachine removeManagedReference:m_onclickHandler withOwner:self];
+#if !__has_feature(objc_arc)
+ [super dealloc];
+#endif
}
@end
@@ -437,6 +440,9 @@
{
[self doEvilThingsWithContext:m_context];
evilAllocationObjectWasDealloced = true;
+#if !__has_feature(objc_arc)
+ [super dealloc];
+#endif
}
- (JSValue *)doEvilThingsWithContext:(JSContext *)context
Modified: trunk/Source/_javascript_Core/ChangeLog (161303 => 161304)
--- trunk/Source/_javascript_Core/ChangeLog 2014-01-04 02:04:34 UTC (rev 161303)
+++ trunk/Source/_javascript_Core/ChangeLog 2014-01-04 02:18:26 UTC (rev 161304)
@@ -1,3 +1,16 @@
+2014-01-03 David Farler <[email protected]>
+
+ [super dealloc] missing in Source/_javascript_Core/API/tests/testapi.mm, fails to build with -Werror,-Wobjc-missing-super-calls
+ https://bugs.webkit.org/show_bug.cgi?id=126454
+
+ Reviewed by Geoffrey Garen.
+
+ * API/tests/testapi.mm:
+ (-[TextXYZ dealloc]):
+ add [super dealloc]
+ (-[EvilAllocationObject dealloc]):
+ add [super dealloc]
+
2014-01-02 Carlos Garcia Campos <[email protected]>
REGRESSION(r160304): [GTK] Disable libtool fast install
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
