Title: [161363] trunk/Tools
Revision
161363
Author
[email protected]
Date
2014-01-06 12:35:58 -0800 (Mon, 06 Jan 2014)

Log Message

Gtk and Efl API test results confuse the dashboard
https://bugs.webkit.org/show_bug.cgi?id=126535

Reviewed by Tim Horton.

Added "API tests" step as "platform api tests".

* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
(Buildbot.prototype.platformAPITestResultsURLForIteration):
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
(BuildbotIteration):
(BuildbotIteration.prototype.update):
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
(BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
(BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds):

Modified Paths

Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js (161362 => 161363)


--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js	2014-01-06 20:33:03 UTC (rev 161362)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js	2014-01-06 20:35:58 UTC (rev 161363)
@@ -71,6 +71,11 @@
         return this.baseURL + "builders/" + encodeURIComponent(iteration.queue.id) + "/builds/" + iteration.id + "/steps/run-api-tests/logs/stdio";
     },
 
+    platformAPITestResultsURLForIteration: function(iteration)
+    {
+        return this.baseURL + "builders/" + encodeURIComponent(iteration.queue.id) + "/builds/" + iteration.id + "/steps/API%20tests/logs/stdio";
+    },
+
     webkitpyTestResultsURLForIteration: function(iteration)
     {
         return this.baseURL + "builders/" + encodeURIComponent(iteration.queue.id) + "/builds/" + iteration.id + "/steps/webkitpy-test/logs/stdio";

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js (161362 => 161363)


--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js	2014-01-06 20:33:03 UTC (rev 161362)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js	2014-01-06 20:35:58 UTC (rev 161363)
@@ -39,6 +39,8 @@
 
     this.layoutTestResults = null;
     this._javascript_TestResults = null;
+    this.apiTestResults = null;
+    this.platformAPITestResults = null;
     this.pythonTestResults = null;
     this.perlTestResults = null;
     this.bindingTestResults = null;
@@ -175,6 +177,9 @@
             var apiTestResults = collectTestResults.call(this, data, "run-api-tests");
             this.apiTestResults = apiTestResults ? new BuildbotTestResults(this, apiTestResults) : null;
 
+            var platformAPITestResults = collectTestResults.call(this, data, "API tests");
+            this.platformAPITestResults = platformAPITestResults ? new BuildbotTestResults(this, platformAPITestResults) : null;
+
             var pythonTestResults = collectTestResults.call(this, data, "webkitpy-test");
             this.pythonTestResults = pythonTestResults ? new BuildbotTestResults(this, pythonTestResults) : null;
 

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js (161362 => 161363)


--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js	2014-01-06 20:33:03 UTC (rev 161362)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js	2014-01-06 20:35:58 UTC (rev 161363)
@@ -61,6 +61,7 @@
                 var layoutTestResults = iteration.layoutTestResults || {failureCount: 0};
                 var _javascript_TestResults = iteration._javascript_TestResults || {failureCount: 0};
                 var apiTestResults = iteration.apiTestResults || {failureCount: 0};
+                var platformAPITestResults = iteration.platformAPITestResults || {failureCount: 0};
                 var pythonTestResults = iteration.pythonTestResults || {failureCount: 0};
                 var perlTestResults = iteration.perlTestResults || {failureCount: 0};
                 var bindingTestResults = iteration.bindingTestResults || {errorOccurred: false};
@@ -71,32 +72,35 @@
                 } else if (!iteration.productive) {
                     var url = ""
                     var status = new StatusLineView(messageElement, StatusLineView.Status.Danger, iteration.text, undefined, url);
-                } else if (!layoutTestResults.failureCount && !_javascript_TestResults.failureCount && !apiTestResults.failureCount && !pythonTestResults.failureCount && !perlTestResults.failureCount && !bindingTestResults.errorOccurred) {
+                } else if (!layoutTestResults.failureCount && !_javascript_TestResults.failureCount && !apiTestResults.failureCount && !platformAPITestResults.failureCount && !pythonTestResults.failureCount && !perlTestResults.failureCount && !bindingTestResults.errorOccurred) {
                     // Something wrong happened, but it was not a test failure.
                     var url = ""
                     var status = new StatusLineView(messageElement, StatusLineView.Status.Danger, iteration.text, undefined, url);
-                } else if (layoutTestResults.failureCount && !_javascript_TestResults.failureCount && !apiTestResults.failureCount && !pythonTestResults.failureCount && !perlTestResults.failureCount && !bindingTestResults.errorOccurred) {
+                } else if (layoutTestResults.failureCount && !_javascript_TestResults.failureCount && !apiTestResults.failureCount && !platformAPITestResults.failureCount && !pythonTestResults.failureCount && !perlTestResults.failureCount && !bindingTestResults.errorOccurred) {
                     var url = ""
                     var status = new StatusLineView(messageElement, StatusLineView.Status.Bad, layoutTestResults.failureCount === 1 ? "layout test failure" : "layout test failures", layoutTestResults.tooManyFailures ? layoutTestResults.failureCount + "\uff0b" : layoutTestResults.failureCount, url);
                     new PopoverTracker(status.statusBubbleElement, this._presentPopoverForLayoutTestRegressions.bind(this), iteration);
-                } else if (!layoutTestResults.failureCount && _javascript_TestResults.failureCount && !apiTestResults.failureCount && !pythonTestResults.failureCount && !perlTestResults.failureCount && !bindingTestResults.errorOccurred) {
+                } else if (!layoutTestResults.failureCount && _javascript_TestResults.failureCount && !apiTestResults.failureCount && !platformAPITestResults.failureCount && !pythonTestResults.failureCount && !perlTestResults.failureCount && !bindingTestResults.errorOccurred) {
                     var url = ""
                     var status = new StatusLineView(messageElement, StatusLineView.Status.Bad, _javascript_TestResults.failureCount === 1 ? "_javascript_ test failure" : "_javascript_ test failures", _javascript_TestResults.failureCount, url);
-                } else if (!layoutTestResults.failureCount && !_javascript_TestResults.failureCount && apiTestResults.failureCount && !pythonTestResults.failureCount && !perlTestResults.failureCount && !bindingTestResults.errorOccurred) {
+                } else if (!layoutTestResults.failureCount && !_javascript_TestResults.failureCount && apiTestResults.failureCount && !platformAPITestResults.failureCount && !pythonTestResults.failureCount && !perlTestResults.failureCount && !bindingTestResults.errorOccurred) {
                     var url = ""
                     var status = new StatusLineView(messageElement, StatusLineView.Status.Bad, apiTestResults.failureCount === 1 ? "api test failure" : "api test failures", apiTestResults.failureCount, url);
-                } else if (!layoutTestResults.failureCount && !_javascript_TestResults.failureCount && !apiTestResults.failureCount && pythonTestResults.failureCount && !perlTestResults.failureCount && !bindingTestResults.errorOccurred) {
+                } else if (!layoutTestResults.failureCount && !_javascript_TestResults.failureCount && !apiTestResults.failureCount && platformAPITestResults.failureCount && !pythonTestResults.failureCount && !perlTestResults.failureCount && !bindingTestResults.errorOccurred) {
+                    var url = ""
+                    var status = new StatusLineView(messageElement, StatusLineView.Status.Bad, platformAPITestResults.failureCount === 1 ? "platform api test failure" : "api test failures", platformAPITestResults.failureCount, url);
+                } else if (!layoutTestResults.failureCount && !_javascript_TestResults.failureCount && !apiTestResults.failureCount && !platformAPITestResults.failureCount && pythonTestResults.failureCount && !perlTestResults.failureCount && !bindingTestResults.errorOccurred) {
                     var url = ""
                     var status = new StatusLineView(messageElement, StatusLineView.Status.Bad, pythonTestResults.failureCount === 1 ? "webkitpy test failure" : "webkitpy test failures", pythonTestResults.failureCount, url);
-                } else if (!layoutTestResults.failureCount && !_javascript_TestResults.failureCount && !apiTestResults.failureCount && !pythonTestResults.failureCount && perlTestResults.failureCount && !bindingTestResults.errorOccurred) {
+                } else if (!layoutTestResults.failureCount && !_javascript_TestResults.failureCount && !apiTestResults.failureCount && !platformAPITestResults.failureCount && !pythonTestResults.failureCount && perlTestResults.failureCount && !bindingTestResults.errorOccurred) {
                     var url = ""
                     var status = new StatusLineView(messageElement, StatusLineView.Status.Bad, perlTestResults.failureCount === 1 ? "webkitperl test failure" : "webkitperl test failures", perlTestResults.failureCount, url);
-                } else if (!layoutTestResults.failureCount && !_javascript_TestResults.failureCount && !apiTestResults.failureCount && !pythonTestResults.failureCount && !perlTestResults.failureCount && bindingTestResults.errorOccurred) {
+                } else if (!layoutTestResults.failureCount && !_javascript_TestResults.failureCount && !apiTestResults.failureCount && !platformAPITestResults.failureCount && !pythonTestResults.failureCount && !perlTestResults.failureCount && bindingTestResults.errorOccurred) {
                     var url = ""
                     var status = new StatusLineView(messageElement, StatusLineView.Status.Bad, "bindings tests failed", undefined, url);
                 } else {
                     var url = ""
-                    var totalFailures = layoutTestResults.failureCount + _javascript_TestResults.failureCount + apiTestResults.failureCount + pythonTestResults.failureCount + perlTestResults.failureCount + bindingTestResults.errorOccurred;
+                    var totalFailures = layoutTestResults.failureCount + _javascript_TestResults.failureCount + apiTestResults.failureCount + platformAPITestResults.failureCount + pythonTestResults.failureCount + perlTestResults.failureCount + bindingTestResults.errorOccurred;
                     var status = new StatusLineView(messageElement, StatusLineView.Status.Bad, totalFailures === 1 ? "test failure" : "test failures", totalFailures, url);
                     new PopoverTracker(status.statusBubbleElement, this._presentPopoverForMultipleFailureKinds.bind(this), iteration);
                 }
@@ -224,6 +228,7 @@
         var layoutTestResults = iteration.layoutTestResults || {failureCount: 0};
         var _javascript_TestResults = iteration._javascript_TestResults || {failureCount: 0};
         var apiTestResults = iteration.apiTestResults || {failureCount: 0};
+        var platformAPITestResults = iteration.platformAPITestResults || {failureCount: 0};
         var pythonTestResults = iteration.pythonTestResults || {failureCount: 0};
         var perlTestResults = iteration.perlTestResults || {failureCount: 0};
         var bindingTestResults = iteration.bindingTestResults || {errorOccurred: false};
@@ -247,6 +252,11 @@
             addResultKind(message, iteration.queue.buildbot.apiTestResultsURLForIteration(iteration));
         }
 
+        if (platformAPITestResults.failureCount) {
+            var message = platformAPITestResults.failureCount + "\u00a0" + (platformAPITestResults.failureCount === 1 ? "platform api test failure" : "platform api test failures");
+            addResultKind(message, iteration.queue.buildbot.platformAPITestResultsURLForIteration(iteration));
+        }
+
         if (pythonTestResults.failureCount) {
             var message = pythonTestResults.failureCount + "\u00a0" + (pythonTestResults.failureCount === 1 ? "webkitpy test failure" : "webkitpy test failures");
             addResultKind(message, iteration.queue.buildbot.bindingsTestResultsURLForIteration(iteration));

Modified: trunk/Tools/ChangeLog (161362 => 161363)


--- trunk/Tools/ChangeLog	2014-01-06 20:33:03 UTC (rev 161362)
+++ trunk/Tools/ChangeLog	2014-01-06 20:35:58 UTC (rev 161363)
@@ -1,3 +1,21 @@
+2014-01-06  Alexey Proskuryakov  <[email protected]>
+
+        Gtk and Efl API test results confuse the dashboard
+        https://bugs.webkit.org/show_bug.cgi?id=126535
+
+        Reviewed by Tim Horton.
+
+        Added "API tests" step as "platform api tests".
+
+        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
+        (Buildbot.prototype.platformAPITestResultsURLForIteration):
+        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
+        (BuildbotIteration):
+        (BuildbotIteration.prototype.update):
+        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
+        (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
+        (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds):
+
 2014-01-06  Tim Horton  <[email protected]>
 
         build.webkit.org/dashboard should still function if localStorage is disabled
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to