Title: [161372] branches/jsCStack/Source/_javascript_Core
- Revision
- 161372
- Author
- [email protected]
- Date
- 2014-01-06 14:18:07 -0800 (Mon, 06 Jan 2014)
Log Message
CStack: JSLock drop and grab lock APIs should be private.
https://bugs.webkit.org/show_bug.cgi?id=126539.
Reviewed by Mark Hahnenberg.
We want the dropping and re-acquisition of the VM API lock to be via the
DropAllLocks raii object. Hence, we should not publicly publishing the
APIs for dropping and re-acquiring the locks.
* runtime/JSLock.h:
Modified Paths
Diff
Modified: branches/jsCStack/Source/_javascript_Core/ChangeLog (161371 => 161372)
--- branches/jsCStack/Source/_javascript_Core/ChangeLog 2014-01-06 22:03:46 UTC (rev 161371)
+++ branches/jsCStack/Source/_javascript_Core/ChangeLog 2014-01-06 22:18:07 UTC (rev 161372)
@@ -1,5 +1,18 @@
2014-01-06 Mark Lam <[email protected]>
+ CStack: JSLock drop and grab lock APIs should be private.
+ https://bugs.webkit.org/show_bug.cgi?id=126539.
+
+ Reviewed by Mark Hahnenberg.
+
+ We want the dropping and re-acquisition of the VM API lock to be via the
+ DropAllLocks raii object. Hence, we should not publicly publishing the
+ APIs for dropping and re-acquiring the locks.
+
+ * runtime/JSLock.h:
+
+2014-01-06 Mark Lam <[email protected]>
+
Follow up patch to remove the need for VMEntryScope::m_prevFirstEntryScope.
https://bugs.webkit.org/show_bug.cgi?id=126266.
Modified: branches/jsCStack/Source/_javascript_Core/runtime/JSLock.h (161371 => 161372)
--- branches/jsCStack/Source/_javascript_Core/runtime/JSLock.h 2014-01-06 22:03:46 UTC (rev 161371)
+++ branches/jsCStack/Source/_javascript_Core/runtime/JSLock.h 2014-01-06 22:18:07 UTC (rev 161372)
@@ -95,10 +95,6 @@
JS_EXPORT_PRIVATE bool currentThreadIsHoldingLock();
- unsigned dropAllLocks(SpinLock&);
- unsigned dropAllLocksUnconditionally(SpinLock&);
- void grabAllLocks(unsigned lockCount, SpinLock&);
-
void willDestroyVM(VM*);
class DropAllLocks {
@@ -117,6 +113,10 @@
};
private:
+ unsigned dropAllLocks(SpinLock&);
+ unsigned dropAllLocksUnconditionally(SpinLock&);
+ void grabAllLocks(unsigned lockCount, SpinLock&);
+
SpinLock m_spinLock;
Mutex m_lock;
ThreadIdentifier m_ownerThread;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
