Title: [161378] trunk/Source/WebCore
- Revision
- 161378
- Author
- [email protected]
- Date
- 2014-01-06 15:23:07 -0800 (Mon, 06 Jan 2014)
Log Message
[WebGL] Revise String Concatenation (Follow-up to r161247)
https://bugs.webkit.org/show_bug.cgi?id=126411
Reviewed by Dean Jackson.
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::getUniformLocation): Use more efficient string
concatenation per Darin Adler's suggestion.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (161377 => 161378)
--- trunk/Source/WebCore/ChangeLog 2014-01-06 23:04:25 UTC (rev 161377)
+++ trunk/Source/WebCore/ChangeLog 2014-01-06 23:23:07 UTC (rev 161378)
@@ -1,5 +1,16 @@
2014-01-06 Brent Fulgham <[email protected]>
+ [WebGL] Revise String Concatenation (Follow-up to r161247)
+ https://bugs.webkit.org/show_bug.cgi?id=126411
+
+ Reviewed by Dean Jackson.
+
+ * html/canvas/WebGLRenderingContext.cpp:
+ (WebCore::WebGLRenderingContext::getUniformLocation): Use more efficient string
+ concatenation per Darin Adler's suggestion.
+
+2014-01-06 Brent Fulgham <[email protected]>
+
[WebGL] FBO Depth Buffer Attachment Function Improperly Clearing with 0
https://bugs.webkit.org/show_bug.cgi?id=126538
<rdar://problem/15201336>
Modified: trunk/Source/WebCore/html/canvas/WebGLRenderingContext.cpp (161377 => 161378)
--- trunk/Source/WebCore/html/canvas/WebGLRenderingContext.cpp 2014-01-06 23:04:25 UTC (rev 161377)
+++ trunk/Source/WebCore/html/canvas/WebGLRenderingContext.cpp 2014-01-06 23:23:07 UTC (rev 161378)
@@ -3174,8 +3174,7 @@
info.name = info.name.left(info.name.length() - 3);
// If it's an array, we need to iterate through each element, appending "[index]" to the name.
for (GC3Dint index = 0; index < info.size; ++index) {
- String arrayBrackets = "[" + String::number(index) + "]";
- String uniformName = info.name + arrayBrackets;
+ String uniformName = info.name + "[" + String::number(index) + "]";
if (name == uniformName || name == info.name)
return WebGLUniformLocation::create(program, uniformLocation, info.type);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
