Title: [161457] trunk/Source/WebCore
Revision
161457
Author
jer.no...@apple.com
Date
2014-01-07 14:31:49 -0800 (Tue, 07 Jan 2014)

Log Message

PlatformLayer containing scrollbars does not disappear when setting overflow:hidden on page root, until resize.
https://bugs.webkit.org/show_bug.cgi?id=116051

Reviewed by Simon Fraser.

Move the pre-existing call to addedOrRemovedScrollbar() outside of the else-statement
in updateScrollbars() so that changes made in the if-statement cause the scrollbar
layers to be updated. The scrollbarAddedOrRemoved local variable guarding access to
addedOrRemovedScrollbar() is already being set (but never checked) inside the if-statement.

* platform/ScrollView.cpp:
(WebCore::ScrollView::updateScrollbars):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (161456 => 161457)


--- trunk/Source/WebCore/ChangeLog	2014-01-07 22:27:44 UTC (rev 161456)
+++ trunk/Source/WebCore/ChangeLog	2014-01-07 22:31:49 UTC (rev 161457)
@@ -1,3 +1,18 @@
+2014-01-07  Jer Noble  <jer.no...@apple.com>
+
+        PlatformLayer containing scrollbars does not disappear when setting overflow:hidden on page root, until resize.
+        https://bugs.webkit.org/show_bug.cgi?id=116051
+
+        Reviewed by Simon Fraser.
+
+        Move the pre-existing call to addedOrRemovedScrollbar() outside of the else-statement
+        in updateScrollbars() so that changes made in the if-statement cause the scrollbar
+        layers to be updated. The scrollbarAddedOrRemoved local variable guarding access to
+        addedOrRemovedScrollbar() is already being set (but never checked) inside the if-statement.
+
+        * platform/ScrollView.cpp:
+        (WebCore::ScrollView::updateScrollbars):
+
 2014-01-06  Jer Noble  <jer.no...@apple.com>
 
         HTML5 video tag Does Not Load in Apache htaccess/htpasswd Protected Directory

Modified: trunk/Source/WebCore/platform/ScrollView.cpp (161456 => 161457)


--- trunk/Source/WebCore/platform/ScrollView.cpp	2014-01-07 22:27:44 UTC (rev 161456)
+++ trunk/Source/WebCore/platform/ScrollView.cpp	2014-01-07 22:31:49 UTC (rev 161457)
@@ -607,11 +607,11 @@
             }
             m_updateScrollbarsPass--;
         }
+    }
 
-        if (scrollbarAddedOrRemoved)
-            addedOrRemovedScrollbar();
-    }
-    
+    if (scrollbarAddedOrRemoved)
+        addedOrRemovedScrollbar();
+
     // Set up the range (and page step/line step), but only do this if we're not in a nested call (to avoid
     // doing it multiple times).
     if (m_updateScrollbarsPass)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to