Title: [161492] trunk/Source/WebCore
- Revision
- 161492
- Author
- mario.pr...@samsung.com
- Date
- 2014-01-08 02:58:37 -0800 (Wed, 08 Jan 2014)
Log Message
AX: Make roleValue() return DescriptionListRole for <dl> elements
https://bugs.webkit.org/show_bug.cgi?id=126579
Reviewed by Chris Fleizach.
Implement AccessibilityList::roleValue() so it will return
ListRole or DescriptionListRole depending on the type of list.
No new tests needed, as no new functionality was added and ports
should still be exposing the right role for <dl> elements
* accessibility/AccessibilityList.cpp:
(WebCore::AccessibilityList::roleValue): Implemented.
* accessibility/AccessibilityList.h:
* accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(atkRole): Removed extra checks for objects with ListRole role.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (161491 => 161492)
--- trunk/Source/WebCore/ChangeLog 2014-01-08 09:47:59 UTC (rev 161491)
+++ trunk/Source/WebCore/ChangeLog 2014-01-08 10:58:37 UTC (rev 161492)
@@ -1,3 +1,23 @@
+2014-01-08 Mario Sanchez Prada <mario.pr...@samsung.com>
+
+ AX: Make roleValue() return DescriptionListRole for <dl> elements
+ https://bugs.webkit.org/show_bug.cgi?id=126579
+
+ Reviewed by Chris Fleizach.
+
+ Implement AccessibilityList::roleValue() so it will return
+ ListRole or DescriptionListRole depending on the type of list.
+
+ No new tests needed, as no new functionality was added and ports
+ should still be exposing the right role for <dl> elements
+
+ * accessibility/AccessibilityList.cpp:
+ (WebCore::AccessibilityList::roleValue): Implemented.
+ * accessibility/AccessibilityList.h:
+
+ * accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
+ (atkRole): Removed extra checks for objects with ListRole role.
+
2014-01-08 Andreas Kling <akl...@apple.com>
createMathMLOperator() should return RenderPtr.
Modified: trunk/Source/WebCore/accessibility/AccessibilityList.cpp (161491 => 161492)
--- trunk/Source/WebCore/accessibility/AccessibilityList.cpp 2014-01-08 09:47:59 UTC (rev 161491)
+++ trunk/Source/WebCore/accessibility/AccessibilityList.cpp 2014-01-08 10:58:37 UTC (rev 161492)
@@ -93,6 +93,13 @@
Node* node = m_renderer->node();
return node && node->hasTagName(dlTag);
}
+
+AccessibilityRole AccessibilityList::roleValue() const
+{
+ if (isDescriptionList())
+ return DescriptionListRole;
+ return ListRole;
+}
} // namespace WebCore
Modified: trunk/Source/WebCore/accessibility/AccessibilityList.h (161491 => 161492)
--- trunk/Source/WebCore/accessibility/AccessibilityList.h 2014-01-08 09:47:59 UTC (rev 161491)
+++ trunk/Source/WebCore/accessibility/AccessibilityList.h 2014-01-08 10:58:37 UTC (rev 161492)
@@ -46,7 +46,7 @@
bool isOrderedList() const;
bool isDescriptionList() const;
- virtual AccessibilityRole roleValue() const OVERRIDE { return ListRole; }
+ virtual AccessibilityRole roleValue() const OVERRIDE FINAL;
private:
virtual bool computeAccessibilityIsIgnored() const OVERRIDE;
};
Modified: trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp (161491 => 161492)
--- trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp 2014-01-08 09:47:59 UTC (rev 161491)
+++ trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp 2014-01-08 10:58:37 UTC (rev 161492)
@@ -634,10 +634,6 @@
case ColorWellRole:
return ATK_ROLE_COLOR_CHOOSER;
case ListRole:
-#if ATK_CHECK_VERSION(2, 11, 4)
- if (coreObject->isList() && toAccessibilityList(coreObject)->isDescriptionList())
- return ATK_ROLE_DESCRIPTION_LIST;
-#endif
return ATK_ROLE_LIST;
case ScrollBarRole:
return ATK_ROLE_SCROLL_BAR;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
