Title: [163269] trunk/Source/WebKit2
Revision
163269
Author
enr...@apple.com
Date
2014-02-02 12:37:17 -0800 (Sun, 02 Feb 2014)

Log Message

WK2: Cannot focus a second field in a page after the first has been focused.
https://bugs.webkit.org/show_bug.cgi?id=128055
<rdar://problem/15943652>

Reviewed by Simon Fraser.

When handling singleTap, we always need to send
a click to WebKit when we are already interacting with text.
Also, when we stop assisting the node, we should not call
resign responder, since that will trigger another unwanted blur.

* UIProcess/API/ios/WKInteractionView.mm:
(-[WKInteractionView _singleTapRecognized:]):
(-[WKInteractionView _stopAssistingNode]):

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (163268 => 163269)


--- trunk/Source/WebKit2/ChangeLog	2014-02-02 20:31:03 UTC (rev 163268)
+++ trunk/Source/WebKit2/ChangeLog	2014-02-02 20:37:17 UTC (rev 163269)
@@ -1,3 +1,20 @@
+2014-02-02  Enrica Casucci  <enr...@apple.com>
+
+        WK2: Cannot focus a second field in a page after the first has been focused.
+        https://bugs.webkit.org/show_bug.cgi?id=128055
+        <rdar://problem/15943652>
+
+        Reviewed by Simon Fraser.
+
+        When handling singleTap, we always need to send
+        a click to WebKit when we are already interacting with text.
+        Also, when we stop assisting the node, we should not call
+        resign responder, since that will trigger another unwanted blur.
+
+        * UIProcess/API/ios/WKInteractionView.mm:
+        (-[WKInteractionView _singleTapRecognized:]):
+        (-[WKInteractionView _stopAssistingNode]):
+
 2014-02-02  Brady Eidson  <beid...@apple.com>
 
         IDB: Support IDBFactory.deleteDatabase()

Modified: trunk/Source/WebKit2/UIProcess/API/ios/WKInteractionView.mm (163268 => 163269)


--- trunk/Source/WebKit2/UIProcess/API/ios/WKInteractionView.mm	2014-02-02 20:31:03 UTC (rev 163268)
+++ trunk/Source/WebKit2/UIProcess/API/ios/WKInteractionView.mm	2014-02-02 20:37:17 UTC (rev 163269)
@@ -608,7 +608,7 @@
 {
     ASSERT(gestureRecognizer == _singleTapGestureRecognizer);
 
-    if (![_webSelectionAssistant shouldHandleSingleTapAtPoint:gestureRecognizer.location])
+    if (_webSelectionAssistant && ![_webSelectionAssistant shouldHandleSingleTapAtPoint:gestureRecognizer.location])
         return;
 
     [_webSelectionAssistant clearSelection];
@@ -1704,9 +1704,7 @@
 - (void)_stopAssistingNode
 {
     _isEditable = NO;
-    if ([self isFirstResponder])
-        [self resignFirstResponder];
-    
+
     [self _stopAssistingKeyboard];
     [self reloadInputViews];
     [self _updateAccessory];
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to