Title: [163273] trunk/Source/WebKit2
Revision
163273
Author
enr...@apple.com
Date
2014-02-02 15:46:01 -0800 (Sun, 02 Feb 2014)

Log Message

WK2: Selection is non editable content is not cleared when navigating to a different page.
https://bugs.webkit.org/show_bug.cgi?id=128084
<rdar://problem/15966166>

Reviewed by Dan Bernstein.

When resigning first responder, we need to cleanup the selection.

* UIProcess/API/ios/WKInteractionView.mm:
(-[WKInteractionView resignFirstResponder]):

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (163272 => 163273)


--- trunk/Source/WebKit2/ChangeLog	2014-02-02 21:59:01 UTC (rev 163272)
+++ trunk/Source/WebKit2/ChangeLog	2014-02-02 23:46:01 UTC (rev 163273)
@@ -1,5 +1,18 @@
 2014-02-02  Enrica Casucci  <enr...@apple.com>
 
+        WK2: Selection is non editable content is not cleared when navigating to a different page.
+        https://bugs.webkit.org/show_bug.cgi?id=128084
+        <rdar://problem/15966166>
+
+        Reviewed by Dan Bernstein.
+
+        When resigning first responder, we need to cleanup the selection.
+
+        * UIProcess/API/ios/WKInteractionView.mm:
+        (-[WKInteractionView resignFirstResponder]):
+
+2014-02-02  Enrica Casucci  <enr...@apple.com>
+
         WK2: Cannot focus a second field in a page after the first has been focused.
         https://bugs.webkit.org/show_bug.cgi?id=128055
         <rdar://problem/15943652>

Modified: trunk/Source/WebKit2/UIProcess/API/ios/WKInteractionView.mm (163272 => 163273)


--- trunk/Source/WebKit2/UIProcess/API/ios/WKInteractionView.mm	2014-02-02 21:59:01 UTC (rev 163272)
+++ trunk/Source/WebKit2/UIProcess/API/ios/WKInteractionView.mm	2014-02-02 23:46:01 UTC (rev 163273)
@@ -266,8 +266,12 @@
 
 - (BOOL)resignFirstResponder
 {
+    // FIXME: Maybe we should call resignFirstResponder on the superclass
+    // and do nothing if the return value is NO.
     _page->blurAssistedNode();
     [self _cancelInteraction];
+    [_webSelectionAssistant resignedFirstResponder];
+
     return [super resignFirstResponder];
 }
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to