Title: [163651] trunk/Source/WebCore
- Revision
- 163651
- Author
- bjone...@adobe.com
- Date
- 2014-02-07 15:01:19 -0800 (Fri, 07 Feb 2014)
Log Message
FloatingObject::unsafeClone should not copy m_originatingLine
https://bugs.webkit.org/show_bug.cgi?id=128381
Reviewed by Andreas Kling.
Copying the originatingLine allows to break the invariant that the
floating object must only contain lines that are owned by the renderer
it is attached to.
* rendering/FloatingObjects.cpp:
(WebCore::FloatingObject::unsafeClone):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (163650 => 163651)
--- trunk/Source/WebCore/ChangeLog 2014-02-07 22:56:57 UTC (rev 163650)
+++ trunk/Source/WebCore/ChangeLog 2014-02-07 23:01:19 UTC (rev 163651)
@@ -1,3 +1,17 @@
+2014-02-07 Bem Jones-Bey <bjone...@adobe.com>
+
+ FloatingObject::unsafeClone should not copy m_originatingLine
+ https://bugs.webkit.org/show_bug.cgi?id=128381
+
+ Reviewed by Andreas Kling.
+
+ Copying the originatingLine allows to break the invariant that the
+ floating object must only contain lines that are owned by the renderer
+ it is attached to.
+
+ * rendering/FloatingObjects.cpp:
+ (WebCore::FloatingObject::unsafeClone):
+
2014-02-07 Brendan Long <b.l...@cablelabs.com>
Update TextTrack API to current spec
Modified: trunk/Source/WebCore/rendering/FloatingObjects.cpp (163650 => 163651)
--- trunk/Source/WebCore/rendering/FloatingObjects.cpp 2014-02-07 22:56:57 UTC (rev 163650)
+++ trunk/Source/WebCore/rendering/FloatingObjects.cpp 2014-02-07 23:01:19 UTC (rev 163651)
@@ -93,7 +93,6 @@
{
// FIXME: Use make_unique here, once we can get it to compile on all platforms we support.
std::unique_ptr<FloatingObject> cloneObject(new FloatingObject(renderer(), type(), m_frameRect, m_shouldPaint, m_isDescendant));
- cloneObject->m_originatingLine = m_originatingLine;
cloneObject->m_paginationStrut = m_paginationStrut;
cloneObject->m_isPlaced = m_isPlaced;
return cloneObject;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
