Title: [163875] trunk/Source/WebKit2
- Revision
- 163875
- Author
- be...@igalia.com
- Date
- 2014-02-11 08:14:55 -0800 (Tue, 11 Feb 2014)
Log Message
O_CLOEXEC in shm_open does not work on FreeBSD
https://bugs.webkit.org/show_bug.cgi?id=128572
Reviewed by Darin Adler.
The O_CLOEXEC is not supported by shm_open() and is also not
necessary since FD_CLOEXEC is already set by default when the new
file descriptor is created.
* Platform/unix/SharedMemoryUnix.cpp:
(WebKit::SharedMemory::create):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (163874 => 163875)
--- trunk/Source/WebKit2/ChangeLog 2014-02-11 16:12:22 UTC (rev 163874)
+++ trunk/Source/WebKit2/ChangeLog 2014-02-11 16:14:55 UTC (rev 163875)
@@ -1,3 +1,17 @@
+2014-02-11 Alberto Garcia <be...@igalia.com>
+
+ O_CLOEXEC in shm_open does not work on FreeBSD
+ https://bugs.webkit.org/show_bug.cgi?id=128572
+
+ Reviewed by Darin Adler.
+
+ The O_CLOEXEC is not supported by shm_open() and is also not
+ necessary since FD_CLOEXEC is already set by default when the new
+ file descriptor is created.
+
+ * Platform/unix/SharedMemoryUnix.cpp:
+ (WebKit::SharedMemory::create):
+
2014-02-10 Commit Queue <commit-qu...@webkit.org>
Unreviewed, rolling out r163856.
Modified: trunk/Source/WebKit2/Platform/unix/SharedMemoryUnix.cpp (163874 => 163875)
--- trunk/Source/WebKit2/Platform/unix/SharedMemoryUnix.cpp 2014-02-11 16:12:22 UTC (rev 163874)
+++ trunk/Source/WebKit2/Platform/unix/SharedMemoryUnix.cpp 2014-02-11 16:14:55 UTC (rev 163875)
@@ -107,7 +107,7 @@
tempName = name.utf8();
do {
- fileDescriptor = shm_open(tempName.data(), O_CREAT | O_CLOEXEC | O_RDWR, S_IRUSR | S_IWUSR);
+ fileDescriptor = shm_open(tempName.data(), O_CREAT | O_RDWR, S_IRUSR | S_IWUSR);
} while (fileDescriptor == -1 && errno == EINTR);
}
if (fileDescriptor == -1) {
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
