Title: [163937] trunk/Source/_javascript_Core
- Revision
- 163937
- Author
- fpi...@apple.com
- Date
- 2014-02-11 20:13:48 -0800 (Tue, 11 Feb 2014)
Log Message
Unreviewed, trivial change to silence FTL assertions
Normally, lowJSValue() should only be used for UntypedUse only. Here we are using it
on ObjectOrOtherUse because we execute the speculation ourselves. The way you're
supposed to do this is by passing ManualOperandSpeculation to tell lowJSValue() not
to assert.
* ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compareEqObjectOrOtherToObject):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (163936 => 163937)
--- trunk/Source/_javascript_Core/ChangeLog 2014-02-12 04:08:22 UTC (rev 163936)
+++ trunk/Source/_javascript_Core/ChangeLog 2014-02-12 04:13:48 UTC (rev 163937)
@@ -1,5 +1,17 @@
2014-02-11 Filip Pizlo <fpi...@apple.com>
+ Unreviewed, trivial change to silence FTL assertions
+
+ Normally, lowJSValue() should only be used for UntypedUse only. Here we are using it
+ on ObjectOrOtherUse because we execute the speculation ourselves. The way you're
+ supposed to do this is by passing ManualOperandSpeculation to tell lowJSValue() not
+ to assert.
+
+ * ftl/FTLLowerDFGToLLVM.cpp:
+ (JSC::FTL::LowerDFGToLLVM::compareEqObjectOrOtherToObject):
+
+2014-02-11 Filip Pizlo <fpi...@apple.com>
+
Use LLVM's dead store elimination
https://bugs.webkit.org/show_bug.cgi?id=128638
Modified: trunk/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp (163936 => 163937)
--- trunk/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp 2014-02-12 04:08:22 UTC (rev 163936)
+++ trunk/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp 2014-02-12 04:13:48 UTC (rev 163937)
@@ -3621,7 +3621,7 @@
void compareEqObjectOrOtherToObject(Edge leftChild, Edge rightChild)
{
LValue rightCell = lowCell(rightChild);
- LValue leftValue = lowJSValue(leftChild);
+ LValue leftValue = lowJSValue(leftChild, ManualOperandSpeculation);
speculateTruthyObject(rightChild, rightCell, SpecObject);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
