Title: [164578] trunk/Source/WebKit2
- Revision
- 164578
- Author
- carlo...@webkit.org
- Date
- 2014-02-24 01:31:16 -0800 (Mon, 24 Feb 2014)
Log Message
[GTK] Remove unneeded method webkitWebViewBaseRequestExitFullScreen
https://bugs.webkit.org/show_bug.cgi?id=129245
Reviewed by Sergio Villar Senin.
* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseKeyPressEvent): Call FullscreenManager::requestExitFullScreen() directly.
* UIProcess/API/gtk/WebKitWebViewBasePrivate.h:
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (164577 => 164578)
--- trunk/Source/WebKit2/ChangeLog 2014-02-24 09:31:12 UTC (rev 164577)
+++ trunk/Source/WebKit2/ChangeLog 2014-02-24 09:31:16 UTC (rev 164578)
@@ -1,3 +1,14 @@
+2014-02-24 Carlos Garcia Campos <cgar...@igalia.com>
+
+ [GTK] Remove unneeded method webkitWebViewBaseRequestExitFullScreen
+ https://bugs.webkit.org/show_bug.cgi?id=129245
+
+ Reviewed by Sergio Villar Senin.
+
+ * UIProcess/API/gtk/WebKitWebViewBase.cpp:
+ (webkitWebViewBaseKeyPressEvent): Call FullscreenManager::requestExitFullScreen() directly.
+ * UIProcess/API/gtk/WebKitWebViewBasePrivate.h:
+
2014-02-23 Dan Bernstein <m...@apple.com>
<rdar://problem/16144508> [iOS] Some definitions of INSTALL_PATH don’t account for INSTALL_PATH_PREFIX
Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp (164577 => 164578)
--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp 2014-02-24 09:31:12 UTC (rev 164577)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp 2014-02-24 09:31:16 UTC (rev 164578)
@@ -619,7 +619,7 @@
case GDK_KEY_Escape:
case GDK_KEY_f:
case GDK_KEY_F:
- webkitWebViewBaseRequestExitFullScreen(webViewBase);
+ priv->pageProxy->fullScreenManager()->requestExitFullScreen();
return TRUE;
default:
break;
@@ -1082,13 +1082,6 @@
#endif
}
-void webkitWebViewBaseRequestExitFullScreen(WebKitWebViewBase* webkitWebViewBase)
-{
-#if ENABLE(FULLSCREEN_API)
- webkitWebViewBase->priv->pageProxy->fullScreenManager()->requestExitFullScreen();
-#endif
-}
-
void webkitWebViewBaseInitializeFullScreenClient(WebKitWebViewBase* webkitWebViewBase, const WKFullScreenClientGtkBase* wkClient)
{
webkitWebViewBase->priv->fullScreenClient.initialize(wkClient);
Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBasePrivate.h (164577 => 164578)
--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBasePrivate.h 2014-02-24 09:31:12 UTC (rev 164577)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBasePrivate.h 2014-02-24 09:31:16 UTC (rev 164578)
@@ -45,7 +45,6 @@
void webkitWebViewBaseChildMoveResize(WebKitWebViewBase*, GtkWidget*, const WebCore::IntRect&);
void webkitWebViewBaseEnterFullScreen(WebKitWebViewBase*);
void webkitWebViewBaseExitFullScreen(WebKitWebViewBase*);
-void webkitWebViewBaseRequestExitFullScreen(WebKitWebViewBase*);
void webkitWebViewBaseInitializeFullScreenClient(WebKitWebViewBase*, const WKFullScreenClientGtkBase*);
void webkitWebViewBaseSetInspectorViewSize(WebKitWebViewBase*, unsigned size);
void webkitWebViewBaseSetActiveContextMenuProxy(WebKitWebViewBase*, WebKit::WebContextMenuProxyGtk*);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes