Title: [165026] trunk/Source/WebInspectorUI
- Revision
- 165026
- Author
- commit-qu...@webkit.org
- Date
- 2014-03-03 17:20:54 -0800 (Mon, 03 Mar 2014)
Log Message
Web Inspector: Better Debugger popovers for RegExp values
https://bugs.webkit.org/show_bug.cgi?id=129633
Patch by Jonathan Wells <jonowe...@apple.com> on 2014-03-03
Reviewed by Timothy Hatcher.
* UserInterface/Views/SourceCodeTextEditor.js:
(WebInspector.SourceCodeTextEditor.prototype._tokenTrackingControllerHighlightedJavaScriptExpression.populate):
(WebInspector.SourceCodeTextEditor.prototype._tokenTrackingControllerHighlightedJavaScriptExpression):
(WebInspector.SourceCodeTextEditor.prototype._showPopoverForRegExp):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (165025 => 165026)
--- trunk/Source/WebInspectorUI/ChangeLog 2014-03-04 01:20:31 UTC (rev 165025)
+++ trunk/Source/WebInspectorUI/ChangeLog 2014-03-04 01:20:54 UTC (rev 165026)
@@ -1,3 +1,15 @@
+2014-03-03 Jonathan Wells <jonowe...@apple.com>
+
+ Web Inspector: Better Debugger popovers for RegExp values
+ https://bugs.webkit.org/show_bug.cgi?id=129633
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Views/SourceCodeTextEditor.js:
+ (WebInspector.SourceCodeTextEditor.prototype._tokenTrackingControllerHighlightedJavaScriptExpression.populate):
+ (WebInspector.SourceCodeTextEditor.prototype._tokenTrackingControllerHighlightedJavaScriptExpression):
+ (WebInspector.SourceCodeTextEditor.prototype._showPopoverForRegExp):
+
2014-03-03 Timothy Hatcher <timo...@apple.com>
Don't try to parse legacy CSS gradients -- we don't support them.
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js (165025 => 165026)
--- trunk/Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js 2014-03-04 01:20:31 UTC (rev 165025)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js 2014-03-04 01:20:54 UTC (rev 165026)
@@ -1089,7 +1089,10 @@
this._showPopoverForFunction(data);
break;
case "object":
- this._showPopoverForObject(data);
+ if (data.subtype === "regexp")
+ this._showPopoverForRegExp(data);
+ else
+ this._showPopoverForObject(data);
break;
case "string":
this._showPopoverForString(data);
@@ -1198,6 +1201,15 @@
this._showPopover(content);
},
+ _showPopoverForRegExp: function(data)
+ {
+ var content = document.createElement("div");
+ content.className = "regexp console-formatted-regexp";
+ content.textContent = data.description;
+
+ this._showPopover(content);
+ },
+
_showPopoverForNumber: function(data)
{
var content = document.createElement("span");
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
