Title: [165249] trunk
Revision
165249
Author
fpi...@apple.com
Date
2014-03-06 22:16:31 -0800 (Thu, 06 Mar 2014)

Log Message

If the FTL is build-time enabled then it should be run-time enabled.

Rubber stamped by Geoffrey Garen.

Source/_javascript_Core: 

* runtime/Options.cpp:
(JSC::recomputeDependentOptions):
* runtime/Options.h:

Source/WebKit2: 

* Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::WebProcessCreationParameters):
(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):
* Shared/WebProcessCreationParameters.h:
* UIProcess/mac/WebContextMac.mm:
(WebKit::registerUserDefaultsIfNeeded):
(WebKit::WebContext::platformInitializeWebProcess):
* WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::platformInitializeWebProcess):

Tools: 

* Scripts/run-jsc-stress-tests:

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (165248 => 165249)


--- trunk/Source/_javascript_Core/ChangeLog	2014-03-07 05:42:57 UTC (rev 165248)
+++ trunk/Source/_javascript_Core/ChangeLog	2014-03-07 06:16:31 UTC (rev 165249)
@@ -1,3 +1,13 @@
+2014-03-06  Filip Pizlo  <fpi...@apple.com>
+
+        If the FTL is build-time enabled then it should be run-time enabled.
+
+        Rubber stamped by Geoffrey Garen.
+
+        * runtime/Options.cpp:
+        (JSC::recomputeDependentOptions):
+        * runtime/Options.h:
+
 2014-03-06  Joseph Pecoraro  <pecor...@apple.com>
 
         [OS X] Web Inspector: Allow Apps using _javascript_Core to access "com.apple.webinspector" mach port

Modified: trunk/Source/_javascript_Core/runtime/Options.cpp (165248 => 165249)


--- trunk/Source/_javascript_Core/runtime/Options.cpp	2014-03-07 05:42:57 UTC (rev 165248)
+++ trunk/Source/_javascript_Core/runtime/Options.cpp	2014-03-07 06:16:31 UTC (rev 165249)
@@ -182,6 +182,7 @@
 #if !ENABLE(JIT)
     Options::useJIT() = false;
     Options::useDFGJIT() = false;
+    Options::useFTLJIT() = false;
 #endif
 #if !ENABLE(YARR_JIT)
     Options::useRegExpJIT() = false;
@@ -189,6 +190,13 @@
 #if !ENABLE(CONCURRENT_JIT)
     Options::enableConcurrentJIT() = false;
 #endif
+#if !ENABLE(DFG_JIT)
+    Options::useDFGJIT() = false;
+    Options::useFTLJIT() = false;
+#endif
+#if !ENABLE(FTL_JIT)
+    Options::useFTLJIT() = false;
+#endif
     
     if (Options::showDisassembly()
         || Options::showDFGDisassembly()

Modified: trunk/Source/_javascript_Core/runtime/Options.h (165248 => 165249)


--- trunk/Source/_javascript_Core/runtime/Options.h	2014-03-07 05:42:57 UTC (rev 165248)
+++ trunk/Source/_javascript_Core/runtime/Options.h	2014-03-07 06:16:31 UTC (rev 165249)
@@ -140,7 +140,7 @@
     v(bool, enableOSREntryToDFG, true) \
     v(bool, enableOSREntryToFTL, true) \
     \
-    v(bool, useFTLJIT, false) \
+    v(bool, useFTLJIT, true) \
     v(bool, enableExperimentalFTLCoverage, false) \
     v(bool, useFTLTBAA, true) \
     v(bool, enableLLVMFastISel, false) \

Modified: trunk/Source/WebKit2/ChangeLog (165248 => 165249)


--- trunk/Source/WebKit2/ChangeLog	2014-03-07 05:42:57 UTC (rev 165248)
+++ trunk/Source/WebKit2/ChangeLog	2014-03-07 06:16:31 UTC (rev 165249)
@@ -1,3 +1,20 @@
+2014-03-06  Filip Pizlo  <fpi...@apple.com>
+
+        If the FTL is build-time enabled then it should be run-time enabled.
+
+        Rubber stamped by Geoffrey Garen.
+
+        * Shared/WebProcessCreationParameters.cpp:
+        (WebKit::WebProcessCreationParameters::WebProcessCreationParameters):
+        (WebKit::WebProcessCreationParameters::encode):
+        (WebKit::WebProcessCreationParameters::decode):
+        * Shared/WebProcessCreationParameters.h:
+        * UIProcess/mac/WebContextMac.mm:
+        (WebKit::registerUserDefaultsIfNeeded):
+        (WebKit::WebContext::platformInitializeWebProcess):
+        * WebProcess/cocoa/WebProcessCocoa.mm:
+        (WebKit::WebProcess::platformInitializeWebProcess):
+
 2014-03-06  Hyowon Kim  <hw1008....@samsung.com>
 
         [EFL] Move EvasGL classes from WebKit to WebCore namespace.

Modified: trunk/Source/WebKit2/Shared/WebProcessCreationParameters.cpp (165248 => 165249)


--- trunk/Source/WebKit2/Shared/WebProcessCreationParameters.cpp	2014-03-07 05:42:57 UTC (rev 165248)
+++ trunk/Source/WebKit2/Shared/WebProcessCreationParameters.cpp	2014-03-07 06:16:31 UTC (rev 165249)
@@ -41,7 +41,6 @@
     , shouldForceScreenFontSubstitution(false)
     , shouldEnableKerningAndLigaturesByDefault(false)
     , shouldEnableJIT(false)
-    , shouldEnableFTL(false)
 #endif
 #if ENABLE(NETWORK_PROCESS)
     , usesNetworkProcess(false)
@@ -111,7 +110,6 @@
     encoder << shouldForceScreenFontSubstitution;
     encoder << shouldEnableKerningAndLigaturesByDefault;
     encoder << shouldEnableJIT;
-    encoder << shouldEnableFTL;
 #endif
 
 #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
@@ -237,8 +235,6 @@
         return false;
     if (!decoder.decode(parameters.shouldEnableJIT))
         return false;
-    if (!decoder.decode(parameters.shouldEnableFTL))
-        return false;
 #endif
 
 #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)

Modified: trunk/Source/WebKit2/Shared/WebProcessCreationParameters.h (165248 => 165249)


--- trunk/Source/WebKit2/Shared/WebProcessCreationParameters.h	2014-03-07 05:42:57 UTC (rev 165248)
+++ trunk/Source/WebKit2/Shared/WebProcessCreationParameters.h	2014-03-07 06:16:31 UTC (rev 165249)
@@ -132,7 +132,6 @@
     bool shouldForceScreenFontSubstitution;
     bool shouldEnableKerningAndLigaturesByDefault;
     bool shouldEnableJIT;
-    bool shouldEnableFTL;
 #endif // PLATFORM(COCOA)
 
 #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)

Modified: trunk/Source/WebKit2/UIProcess/mac/WebContextMac.mm (165248 => 165249)


--- trunk/Source/WebKit2/UIProcess/mac/WebContextMac.mm	2014-03-07 05:42:57 UTC (rev 165248)
+++ trunk/Source/WebKit2/UIProcess/mac/WebContextMac.mm	2014-03-07 06:16:31 UTC (rev 165249)
@@ -67,7 +67,6 @@
 NSString *WebKitLocalCacheDefaultsKey = @"WebKitLocalCache";
 NSString *WebStorageDirectoryDefaultsKey = @"WebKitLocalStorageDatabasePathPreferenceKey";
 NSString *WebKitKerningAndLigaturesEnabledByDefaultDefaultsKey = @"WebKitKerningAndLigaturesEnabledByDefault";
-NSString *WebKitJSCFTLEnabledDefaultsKey = @"WebKitJSCFTLEnabledDefaultsKey";
 NSString *WebKitJSCJITEnabledDefaultsKey = @"WebKitJSCJITEnabledDefaultsKey";
 
 #if !PLATFORM(IOS)
@@ -100,7 +99,6 @@
 
 #if PLATFORM(IOS) || __MAC_OS_X_VERSION_MIN_REQUIRED >= 1090
     [registrationDictionary setObject:[NSNumber numberWithBool:YES] forKey:WebKitKerningAndLigaturesEnabledByDefaultDefaultsKey];
-    [registrationDictionary setObject:[NSNumber numberWithBool:NO] forKey:WebKitJSCFTLEnabledDefaultsKey];
 #endif
 
     [[NSUserDefaults standardUserDefaults] registerDefaults:registrationDictionary];
@@ -159,7 +157,6 @@
 #endif
     parameters.shouldEnableKerningAndLigaturesByDefault = [[NSUserDefaults standardUserDefaults] boolForKey:WebKitKerningAndLigaturesEnabledByDefaultDefaultsKey];
     parameters.shouldEnableJIT = [[NSUserDefaults standardUserDefaults] boolForKey:WebKitJSCJITEnabledDefaultsKey];
-    parameters.shouldEnableFTL = [[NSUserDefaults standardUserDefaults] boolForKey:WebKitJSCFTLEnabledDefaultsKey];
 
 #if HAVE(HOSTED_CORE_ANIMATION)
 #if !PLATFORM(IOS)

Modified: trunk/Source/WebKit2/WebProcess/cocoa/WebProcessCocoa.mm (165248 => 165249)


--- trunk/Source/WebKit2/WebProcess/cocoa/WebProcessCocoa.mm	2014-03-07 05:42:57 UTC (rev 165248)
+++ trunk/Source/WebKit2/WebProcess/cocoa/WebProcessCocoa.mm	2014-03-07 06:16:31 UTC (rev 165249)
@@ -180,9 +180,6 @@
     if (!JSC::Options::useJITWasOverridden())
         JSC::Options::useJIT() = parameters.shouldEnableJIT;
 
-    if (!JSC::Options::useFTLJITWasOverridden())
-        JSC::Options::useFTLJIT() = parameters.shouldEnableFTL;
-
     setEnhancedAccessibility(parameters.accessibilityEnhancedUserInterfaceEnabled);
 
 #if USE(APPKIT)

Modified: trunk/Tools/ChangeLog (165248 => 165249)


--- trunk/Tools/ChangeLog	2014-03-07 05:42:57 UTC (rev 165248)
+++ trunk/Tools/ChangeLog	2014-03-07 06:16:31 UTC (rev 165249)
@@ -1,3 +1,11 @@
+2014-03-06  Filip Pizlo  <fpi...@apple.com>
+
+        If the FTL is build-time enabled then it should be run-time enabled.
+
+        Rubber stamped by Geoffrey Garen.
+
+        * Scripts/run-jsc-stress-tests:
+
 2014-03-06  Mark Hahnenberg  <mhahnenb...@apple.com>
 
         detectFailures in run-jsc-stress-tests can report everything was ok if too many tests fail

Modified: trunk/Tools/Scripts/run-jsc-stress-tests (165248 => 165249)


--- trunk/Tools/Scripts/run-jsc-stress-tests	2014-03-07 05:42:57 UTC (rev 165248)
+++ trunk/Tools/Scripts/run-jsc-stress-tests	2014-03-07 06:16:31 UTC (rev 165249)
@@ -180,6 +180,8 @@
 
 EAGER_OPTIONS = ["--thresholdForJITAfterWarmUp=10", "--thresholdForJITSoon=10", "--thresholdForOptimizeAfterWarmUp=20", "--thresholdForOptimizeAfterLongWarmUp=20", "--thresholdForOptimizeSoon=20", "--thresholdForFTLOptimizeAfterWarmUp=20", "--thresholdForFTLOptimizeSoon=20"]
 
+NO_FTL_OPTIONS = ["--useFTLJIT=false"]
+
 FTL_OPTIONS = ["--useFTLJIT=true", "--enableExperimentalFTLCoverage=true"]
 
 $runlist = []
@@ -514,7 +516,7 @@
 end
 
 def run(kind, *options)
-    addRunCommand(kind, [pathToVM.to_s] + options + [$benchmark.to_s], silentOutputHandler, simpleErrorHandler)
+    addRunCommand(kind, [pathToVM.to_s] + NO_FTL_OPTIONS + options + [$benchmark.to_s], silentOutputHandler, simpleErrorHandler)
 end
 
 def runDefault
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to