Title: [165320] trunk/Source/_javascript_Core
- Revision
- 165320
- Author
- msab...@apple.com
- Date
- 2014-03-07 19:33:44 -0800 (Fri, 07 Mar 2014)
Log Message
.cfi directives in LowLevelInterpreter.cpp are providing no benefit
https://bugs.webkit.org/show_bug.cgi?id=129945
Reviewed by Mark Lam.
Removed .cfi directive. Verified that stack traces didn't regress in crash reporter
or in lldb.
* llint/LowLevelInterpreter.cpp:
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (165319 => 165320)
--- trunk/Source/_javascript_Core/ChangeLog 2014-03-08 03:05:34 UTC (rev 165319)
+++ trunk/Source/_javascript_Core/ChangeLog 2014-03-08 03:33:44 UTC (rev 165320)
@@ -1,3 +1,15 @@
+2014-03-07 Michael Saboff <msab...@apple.com>
+
+ .cfi directives in LowLevelInterpreter.cpp are providing no benefit
+ https://bugs.webkit.org/show_bug.cgi?id=129945
+
+ Reviewed by Mark Lam.
+
+ Removed .cfi directive. Verified that stack traces didn't regress in crash reporter
+ or in lldb.
+
+ * llint/LowLevelInterpreter.cpp:
+
2014-03-07 Oliver Hunt <oli...@apple.com>
Continue hangs when performing for-of over arguments
Modified: trunk/Source/_javascript_Core/llint/LowLevelInterpreter.cpp (165319 => 165320)
--- trunk/Source/_javascript_Core/llint/LowLevelInterpreter.cpp 2014-03-08 03:05:34 UTC (rev 165319)
+++ trunk/Source/_javascript_Core/llint/LowLevelInterpreter.cpp 2014-03-08 03:33:44 UTC (rev 165320)
@@ -492,17 +492,8 @@
//
// These are for building an interpreter from generated assembly code:
-#if CPU(X86_64) && COMPILER(CLANG)
-#define OFFLINE_ASM_BEGIN asm ( \
- ".cfi_startproc\n"
-
-#define OFFLINE_ASM_END \
- ".cfi_endproc\n" \
- );
-#else
#define OFFLINE_ASM_BEGIN asm (
#define OFFLINE_ASM_END );
-#endif
#define OFFLINE_ASM_OPCODE_LABEL(__opcode) OFFLINE_ASM_GLOBAL_LABEL(llint_##__opcode)
#define OFFLINE_ASM_GLUE_LABEL(__opcode) OFFLINE_ASM_GLOBAL_LABEL(__opcode)
@@ -515,15 +506,6 @@
".thumb\n" \
".thumb_func " THUMB_FUNC_PARAM(label) "\n" \
SYMBOL_STRING(label) ":\n"
-#elif CPU(XXX86_64) && COMPILER(CLANG)
-#define OFFLINE_ASM_GLOBAL_LABEL(label) \
- ".text\n" \
- ".globl " SYMBOL_STRING(label) "\n" \
- HIDE_SYMBOL(label) "\n" \
- SYMBOL_STRING(label) ":\n" \
- ".cfi_def_cfa_offset 16\n" \
- ".cfi_offset %rbp, -16\n" \
- ".cfi_def_cfa_register rbp\n"
#else
#define OFFLINE_ASM_GLOBAL_LABEL(label) \
".text\n" \
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
