Title: [165614] trunk/Source/WebCore
- Revision
- 165614
- Author
- zandober...@gmail.com
- Date
- 2014-03-14 04:58:54 -0700 (Fri, 14 Mar 2014)
Log Message
Unnecessary ImplementationLacksVTable IDL attribute used for RTCConfiguration, RTCIceServer
https://bugs.webkit.org/show_bug.cgi?id=130230
Reviewed by Philippe Normand.
The RTCConfiguration and RTCIceServer classes do not own virtual tables, so using the
ImplementationLacksVTable attribute in the IDL interface leads to a compile-time assertion
failure in the generates JSC wrappers because none of the classes is polymorphic.
* Modules/mediastream/RTCConfiguration.idl:
* Modules/mediastream/RTCIceServer.idl:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (165613 => 165614)
--- trunk/Source/WebCore/ChangeLog 2014-03-14 10:46:00 UTC (rev 165613)
+++ trunk/Source/WebCore/ChangeLog 2014-03-14 11:58:54 UTC (rev 165614)
@@ -1,3 +1,17 @@
+2014-03-14 Zan Dobersek <zdober...@igalia.com>
+
+ Unnecessary ImplementationLacksVTable IDL attribute used for RTCConfiguration, RTCIceServer
+ https://bugs.webkit.org/show_bug.cgi?id=130230
+
+ Reviewed by Philippe Normand.
+
+ The RTCConfiguration and RTCIceServer classes do not own virtual tables, so using the
+ ImplementationLacksVTable attribute in the IDL interface leads to a compile-time assertion
+ failure in the generates JSC wrappers because none of the classes is polymorphic.
+
+ * Modules/mediastream/RTCConfiguration.idl:
+ * Modules/mediastream/RTCIceServer.idl:
+
2014-03-14 Javier Fernandez <jfernan...@igalia.com>
[CSS Grid Layout] the "grid-template-areas" is not identified as computable property.
Modified: trunk/Source/WebCore/Modules/mediastream/RTCConfiguration.idl (165613 => 165614)
--- trunk/Source/WebCore/Modules/mediastream/RTCConfiguration.idl 2014-03-14 10:46:00 UTC (rev 165613)
+++ trunk/Source/WebCore/Modules/mediastream/RTCConfiguration.idl 2014-03-14 11:58:54 UTC (rev 165614)
@@ -28,7 +28,6 @@
[
Conditional=MEDIA_STREAM,
- ImplementationLacksVTable,
NoInterfaceObject,
] interface RTCConfiguration {
readonly attribute RTCIceServer[] iceServers;
Modified: trunk/Source/WebCore/Modules/mediastream/RTCIceServer.idl (165613 => 165614)
--- trunk/Source/WebCore/Modules/mediastream/RTCIceServer.idl 2014-03-14 10:46:00 UTC (rev 165613)
+++ trunk/Source/WebCore/Modules/mediastream/RTCIceServer.idl 2014-03-14 11:58:54 UTC (rev 165614)
@@ -25,7 +25,6 @@
[
Conditional=MEDIA_STREAM,
- ImplementationLacksVTable,
NoInterfaceObject,
] interface RTCIceServer {
readonly attribute DOMString[] urls;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
